fix(android): show password action only for locked channels

apps/chanora_flutter/lib/main.dart

@@ -2152,13 +2152,14 @@ class _SnapshotView extends StatelessWidget {
                   : Row(
                       mainAxisSize: MainAxisSize.min,
                       children: [
-                        IconButton(
+                        if (ch.hasPassword)
-                          icon: const Icon(Icons.lock_outline),
+                          IconButton(
-                          tooltip: l10n.channelPasswordTitle,
+                            icon: const Icon(Icons.lock_outline),
-                          onPressed: hasJoinPending
+                            tooltip: l10n.channelPasswordTitle,
-                              ? null
+                            onPressed: hasJoinPending
-                              : () => onJoinChannelWithPassword(ch),
+                                ? null
-                        ),
+                                : () => onJoinChannelWithPassword(ch),
+                          ),
                         IconButton(
                           icon: Icon(
                             ch.id == pendingVoiceChannelId

apps/chanora_flutter/lib/src/rust/api.dart

@@ -314,16 +314,24 @@ class BridgeChannel {
   /// Server-side ordering hint.
   final PlatformInt64 order;
 
+  /// True when the server marks the channel as password-protected.
+  final bool hasPassword;
+
   const BridgeChannel({
     required this.id,
     required this.parent,
     required this.name,
     required this.order,
+    required this.hasPassword,
   });
 
   @override
   int get hashCode =>
-      id.hashCode ^ parent.hashCode ^ name.hashCode ^ order.hashCode;
+      id.hashCode ^
+      parent.hashCode ^
+      name.hashCode ^
+      order.hashCode ^
+      hasPassword.hashCode;
 
   @override
   bool operator ==(Object other) =>
@@ -333,7 +341,8 @@ class BridgeChannel {
           id == other.id &&
           parent == other.parent &&
           name == other.name &&
-          order == other.order;
+          order == other.order &&
+          hasPassword == other.hasPassword;
 }
 
 /// Client as seen by Dart.

apps/chanora_flutter/lib/src/rust/frb_generated.dart

@@ -1157,13 +1157,14 @@ class RustLibApiImpl extends RustLibApiImplPlatform implements RustLibApi {
   BridgeChannel dco_decode_bridge_channel(dynamic raw) {
     // Codec=Dco (DartCObject based), see doc to use other codecs
     final arr = raw as List<dynamic>;
-    if (arr.length != 4)
+    if (arr.length != 5)
-      throw Exception('unexpected arr length: expect 4 but see ${arr.length}');
+      throw Exception('unexpected arr length: expect 5 but see ${arr.length}');
     return BridgeChannel(
       id: dco_decode_u_64(arr[0]),
       parent: dco_decode_u_64(arr[1]),
       name: dco_decode_String(arr[2]),
       order: dco_decode_i_64(arr[3]),
+      hasPassword: dco_decode_bool(arr[4]),
     );
   }
 
@@ -1518,11 +1519,13 @@ class RustLibApiImpl extends RustLibApiImplPlatform implements RustLibApi {
     var var_parent = sse_decode_u_64(deserializer);
     var var_name = sse_decode_String(deserializer);
     var var_order = sse_decode_i_64(deserializer);
+    var var_hasPassword = sse_decode_bool(deserializer);
     return BridgeChannel(
       id: var_id,
       parent: var_parent,
       name: var_name,
       order: var_order,
+      hasPassword: var_hasPassword,
     );
   }
 

core/chanora_core/src/lib.rs

@@ -2021,12 +2021,14 @@ mod tests {
                     parent: chanora_protocol::ChannelId(0),
                     name: "a".into(),
                     order: 0,
+                    has_password: false,
                 },
                 ChannelInfo {
                     id: chanora_protocol::ChannelId(2),
                     parent: chanora_protocol::ChannelId(0),
                     name: "b".into(),
                     order: 1,
+                    has_password: false,
                 },
             ],
             clients: vec![ClientInfo {
@@ -2057,12 +2059,14 @@ mod tests {
                     parent: chanora_protocol::ChannelId(0),
                     name: "b".into(),
                     order: 1,
+                    has_password: false,
                 },
                 ChannelInfo {
                     id: chanora_protocol::ChannelId(1),
                     parent: chanora_protocol::ChannelId(0),
                     name: "a".into(),
                     order: 0,
+                    has_password: false,
                 },
             ],
             clients: vec![],

crates/chanora_bridge/src/api.rs

@@ -355,6 +355,8 @@ pub struct BridgeChannel {
     pub name: String,
     /// Server-side ordering hint.
     pub order: i64,
+    /// True when the server marks the channel as password-protected.
+    pub has_password: bool,
 }
 
 /// Client as seen by Dart.
@@ -406,6 +408,7 @@ impl From<chanora_protocol::ServerSnapshot> for BridgeSnapshot {
                     parent: c.parent.0,
                     name: c.name,
                     order: c.order,
+                    has_password: c.has_password,
                 })
                 .collect(),
             clients: s

crates/chanora_bridge/src/frb_generated.rs

@@ -1275,11 +1275,13 @@ impl SseDecode for crate::api::BridgeChannel {
         let mut var_parent = <u64>::sse_decode(deserializer);
         let mut var_name = <String>::sse_decode(deserializer);
         let mut var_order = <i64>::sse_decode(deserializer);
+        let mut var_has_password = <bool>::sse_decode(deserializer);
         return crate::api::BridgeChannel {
             id: var_id,
             parent: var_parent,
             name: var_name,
             order: var_order,
+            has_password: var_has_password,
         };
     }
 }
@@ -1800,6 +1802,7 @@ impl flutter_rust_bridge::IntoDart for crate::api::BridgeChannel {
             self.parent.into_into_dart().into_dart(),
             self.name.into_into_dart().into_dart(),
             self.order.into_into_dart().into_dart(),
+            self.has_password.into_into_dart().into_dart(),
         ]
         .into_dart()
     }
@@ -2180,6 +2183,7 @@ impl SseEncode for crate::api::BridgeChannel {
         <u64>::sse_encode(self.parent, serializer);
         <String>::sse_encode(self.name, serializer);
         <i64>::sse_encode(self.order, serializer);
+        <bool>::sse_encode(self.has_password, serializer);
     }
 }
 

crates/chanora_protocol/src/adapter.rs

@@ -864,6 +864,7 @@ fn build_snapshot(con: &Connection) -> Result<ServerSnapshot, ProtocolError> {
             parent: ChannelId(c.parent.0),
             name: sanitize(&c.name),
             order: c.order.0 as i64,
+            has_password: c.has_password.unwrap_or(false),
         })
         .collect();
 

crates/chanora_protocol/src/dto.rs

@@ -23,6 +23,8 @@ pub struct ChannelInfo {
     pub name: String,
     /// Server-side ordering hint.
     pub order: i64,
+    /// True when the server marks the channel as password-protected.
+    pub has_password: bool,
 }
 
 /// One connected client on the server.