chanora

137 Commits 17 Branches 3 Tags

3 Commits

Include renames

Author	SHA1	Message	Date
EdisonJwa	2511b24982	fix(audio,protocol,ui): TC-2.3 + TC-10 + TC-13 + channel tree hierarchy Five user-reported defects + one auto-test regression-catcher. == TC-2.3: capability badge stuck at L0Focused on Korean Win 11 == Root cause: in WindowsRawInputBackend::start() (and the parallel WindowsHookBackend), the worker thread's armed.store(ok, ...) only ran AFTER GetMessageW returned (i.e. on WM_QUIT). During normal arming the message pump runs forever, so armed stayed at its initial false value, and descriptor() reported L0Focused even though RegisterRawInputDevices had succeeded. Fix: run_raw_input_loop and run_hook_loop now take armed as a parameter and flip it to true inside the loop right after the successful registration, before blocking on GetMessageW. The outer setter is kept as a belt-and-braces clear-on-failure path. Also drops the redundant outer 'Raw Input armed' / 'low-level hook armed' log lines — the in-loop 'Raw Input devices registered' / 'low-level hooks installed' messages already convey arming success with full context. New tests raw_input_backend_start_flips_armed_to_l2 and hook_backend_start_flips_armed_to_l2 call real start(), sleep 80 ms, assert descriptor().level == L2GlobalHoldToTalk. Replaces the previous #[ignore]'d real-start smoke test which never asserted on the descriptor. == TC-10: no-permission channel rejection invisible == Root cause 1: chanora_protocol::adapter::move_self_to used the fire-and-forget send() on the client_move command. TS3 server replies with a typed error event the adapter discarded, and move_to_channel returned Ok regardless. Root cause 2: even when chanora_core::voice_join detected the non-confirmation via snapshot polling, the rolled-back error flowed into the connect-form-area _error string which is hidden post-connect. The user saw no feedback. Fix: * New ProtocolError::ServerRejected { code: u32, message: String } carries the canonical TS3 error code per the official catalogue at https://github.com/ReSpeak/tsdeclarations (Errors.csv). * move_self_to now uses send_with_result, returns a MessageHandle. The connection-task loop holds a pending_moves HashMap keyed by MessageHandle, services StreamItem::MessageResult by looking up and resolving the reply with either Ok or the typed ServerRejected. * Pending entries have a 3 s deadline so a server that never replies doesn't leak the reply channel — expired entries fall back to Ok and let the snapshot poll handle confirmation. * voice_join short-circuits on ServerRejected (no need for the full snapshot poll), still polls for confirmation as a belt-and-braces fallback for legacy servers; on poll failure emits ServerRejected with sentinel code 0x0001 (undefined). * New BridgeError::ServerRejected mirror with the same fields; CoreError → BridgeError mapping preserves the typed variant. * Flutter _onJoinChannel shows a floating SnackBar with a localised message selected by error code (channelJoinFailed* l10n entries). 6 known codes mapped to specific messages (insufficient permission, wrong password, channel full, family limit, private channel, timeout); everything else falls back to the server-supplied generic message. == TC-13: mouse side-button capture only works on text field == The _PttBindingCaptureDialog wrapped its Column with a Listener using the default HitTestBehavior.deferToChild. Pointer events landing on the dialog's empty padding regions weren't claimed by any child and so were never delivered to the Listener. Fix: explicit HitTestBehavior.opaque so the entire dialog area catches PointerDown events regardless of where the cursor sits. == Channel tree hierarchy == Reported issue: tree rendered as flat list, no indication of parent-child nesting. The bridge already carries the field; the renderer just ignored it. Fix in _SnapshotView: walk the (already DFS-sorted) channel list and compute each row's depth from its parent's depth. Render left-padding of depth * 18 dp. Cap depth at 6 to keep deep hierarchies visually bounded; the cap plateaus silently (no glyph, channel still tappable, data carries the real depth). == Responsive layout == Connected layout is now LayoutBuilder-driven. Below 840 dp wide (Material's tablet/desktop breakpoint) the original stacked column layout is used (Voice Bar on top, channel tree below). At 840 dp and above the layout becomes a side-by-side Row with the Voice Bar pinned at 320 dp on the left and the channel tree Expanded on the right. Verification - cargo check --workspace: clean. - cargo test --workspace --lib: 80 / 0 / 1 (unchanged Linux total; +2 new Windows-only tests not counted here). - flutter analyze: clean (6 pre-existing Radio.groupValue infos). - FRB bindings regenerated to expose BridgeError_ServerRejected.	2026-05-16 03:27:25 +08:00
EdisonJwa	0bef61aea2	feat(core): A.6 — supervisor reconnect with watchdog and event stream Adds an end-to-end auto-reconnect path so a brief network outage no longer leaves the client wedged in a half-dead state. The flow has three layers, each motivated by a real failure mode observed on the Moto G live test: * `chanora_protocol::DisconnectReason` (`UserRequested` / `StreamEnded` / `Error(String)`) is reported on a `oneshot` when the per-connection task exits, so the supervisor can tell user intent apart from a real loss. * `chanora_core` spawns a supervisor task per `ChanoraSession`. It listens for the loss notifier AND runs a watchdog that issues `snapshot()` probes every 5s with a 4s timeout — three consecutive misses synthesise a `DisconnectReason::Error(...)` and trigger the reconnect path. The watchdog catches the "ghost connected" case where tsclientlib silently resets internal state but the event stream never errors. Backoff schedule: 1s, 2s, 5s, 15s, 30s, 60s (capped). On success the supervisor swaps the dead `ProtocolClient` for the new one in place and, if audio was running, restarts the audio engine bound to the new `voice_in`/`voice_out` channels. * `SessionEvent` (Connected / Lost / Reconnecting / Disconnected / AudioStarted / AudioStopped) is broadcast on a 64-slot channel. `chanora_bridge` re-exports it as `BridgeEvent` and exposes `events_stream(StreamSink)`; the Flutter side subscribes from `initState` and renders a reconnect banner with attempt count and delay. New `SnapshotProbe` exposes a clone-friendly snapshot path so the watchdog can probe without holding `&self` across awaits. Localization adds `statusReconnecting` and `statusConnectionLost` keys to `app_en.arb` and `app_zh.arb`. Verified on Moto G Stylus 5G (Android 14) against cn.teamspeak.app: killed Wi-Fi + cellular for ~70 s; watchdog declared loss at three misses, supervisor walked the backoff schedule, and the UI reconnected automatically once the radios came back. Snapshot tree re-rendered without user action.	2026-05-15 01:06:07 +08:00
EdisonJwa	4915ec0a1b	feat(alpha): wire connect→snapshot→disconnect end-to-end (v0.1.0-alpha.1) First Internal Alpha build per DEC-001. Closes the milestone of 'Flutter UI calls Rust via the typed bridge, Rust connects to a TeamSpeak-compatible server through tsclientlib, returns a typed snapshot, and disconnects cleanly.' Audio remains Beta scope. Promotions from PoC: poc/tsclientlib-connect-spike → crates/chanora_protocol/ New product code: crates/chanora_protocol/src/{dto.rs,adapter.rs} — typed boundary over tsclientlib. Tokio task owns the Connection; public handle communicates via mpsc/oneshot. No tsclientlib types cross out of the crate (SAD-067 / SysDes-011 / SysDes-029). core/chanora_core/src/lib.rs — ChanoraSession composes the protocol crate, enforces the DEC-006 single-connection invariant. crates/chanora_bridge/src/{api.rs,frb_generated.rs} — FRB 2.12.0 bridge per DEC-014. cdylib + staticlib + rlib. Typed BridgeSnapshot / BridgeChannel / BridgeClient / BridgeError DTOs. Process-wide OnceLock<Runtime> + OnceLock<ChanoraSession>. flutter_rust_bridge.yaml at repo root. apps/chanora_flutter/lib/main.dart — Alpha UI: server form, connect button, channel tree, disconnect. apps/chanora_flutter/lib/l10n/app_{en,zh}.arb expanded with the Alpha key set; ARB metadata reaffirms ADR-008 for server-provided content. Generated Dart bindings under apps/chanora_flutter/lib/src/rust/. Empirical verification (2026-05-14): Workspace: cargo check + cargo test clean (workspace tests: all green). Bridge cdylib: target/release/libchanora_bridge.so produced (~15 MB). Flutter: flutter analyze clean; flutter test runs 3/3 green including the alpha_e2e_test that drives the full Dart → FRB → chanora_bridge → chanora_core → chanora_protocol → tsclientlib → UDP → cn.teamspeak.app path. The captured logcat/stdout shows the tsproto resender transitioning Connected → Disconnecting → Disconnected on clean teardown. Architecture changes: - Removed the chanora_core ↔ chanora_bridge cyclic dependency. chanora_core no longer knows the bridge exists; the bridge maps from CoreError. - chanora_bridge crate's #![forbid(unsafe_code)] lint relaxed because FRB-generated glue legitimately uses unsafe at the FFI boundary. Hand-written code remains unsafe-free. Open follow-ups (NOT in this Alpha): - Audio capture/playback wiring into chanora_audio (Beta scope per DEC-001). - Identity persistence via chanora_storage (currently regenerated on every connect). - Per-message diagnostics + redaction (chanora_diagnostics still scaffold). - Reconnect / network-loss recovery. - Mobile (Android) build of the bridge cdylib + UI verification.	2026-05-14 21:37:06 +08:00

Author

SHA1

Message

Date

EdisonJwa

2511b24982

fix(audio,protocol,ui): TC-2.3 + TC-10 + TC-13 + channel tree hierarchy

Five user-reported defects + one auto-test regression-catcher.

== TC-2.3: capability badge stuck at L0Focused on Korean Win 11 ==
Root cause: in WindowsRawInputBackend::start() (and the parallel
WindowsHookBackend), the worker thread's armed.store(ok, ...) only
ran AFTER GetMessageW returned (i.e. on WM_QUIT). During normal
arming the message pump runs forever, so armed stayed at its
initial false value, and descriptor() reported L0Focused even
though RegisterRawInputDevices had succeeded.

Fix: run_raw_input_loop and run_hook_loop now take armed as a
parameter and flip it to true inside the loop right after the
successful registration, before blocking on GetMessageW. The
outer setter is kept as a belt-and-braces clear-on-failure path.

Also drops the redundant outer 'Raw Input armed' / 'low-level
hook armed' log lines — the in-loop 'Raw Input devices
registered' / 'low-level hooks installed' messages already
convey arming success with full context.

New tests raw_input_backend_start_flips_armed_to_l2 and
hook_backend_start_flips_armed_to_l2 call real start(), sleep
80 ms, assert descriptor().level == L2GlobalHoldToTalk. Replaces
the previous #[ignore]'d real-start smoke test which never
asserted on the descriptor.

== TC-10: no-permission channel rejection invisible ==
Root cause 1: chanora_protocol::adapter::move_self_to used the
fire-and-forget send() on the client_move command. TS3 server
replies with a typed error event the adapter discarded, and
move_to_channel returned Ok regardless.

Root cause 2: even when chanora_core::voice_join detected the
non-confirmation via snapshot polling, the rolled-back error
flowed into the connect-form-area _error string which is hidden
post-connect. The user saw no feedback.

Fix:
* New ProtocolError::ServerRejected { code: u32, message: String }
  carries the canonical TS3 error code per the official catalogue
  at https://github.com/ReSpeak/tsdeclarations (Errors.csv).
* move_self_to now uses send_with_result, returns a MessageHandle.
  The connection-task loop holds a pending_moves HashMap keyed by
  MessageHandle, services StreamItem::MessageResult by looking up
  and resolving the reply with either Ok or the typed
  ServerRejected.
* Pending entries have a 3 s deadline so a server that never
  replies doesn't leak the reply channel — expired entries fall
  back to Ok and let the snapshot poll handle confirmation.
* voice_join short-circuits on ServerRejected (no need for the
  full snapshot poll), still polls for confirmation as a
  belt-and-braces fallback for legacy servers; on poll failure
  emits ServerRejected with sentinel code 0x0001 (undefined).
* New BridgeError::ServerRejected mirror with the same fields;
  CoreError → BridgeError mapping preserves the typed variant.
* Flutter _onJoinChannel shows a floating SnackBar with a
  localised message selected by error code (channelJoinFailed*
  l10n entries). 6 known codes mapped to specific messages
  (insufficient permission, wrong password, channel full,
  family limit, private channel, timeout); everything else
  falls back to the server-supplied generic message.

== TC-13: mouse side-button capture only works on text field ==
The _PttBindingCaptureDialog wrapped its Column with a Listener
using the default HitTestBehavior.deferToChild. Pointer events
landing on the dialog's empty padding regions weren't claimed by
any child and so were never delivered to the Listener.

Fix: explicit HitTestBehavior.opaque so the entire dialog area
catches PointerDown events regardless of where the cursor sits.

== Channel tree hierarchy ==
Reported issue: tree rendered as flat list, no indication of
parent-child nesting. The bridge already carries the
field; the renderer just ignored it.

Fix in _SnapshotView: walk the (already DFS-sorted) channel list
and compute each row's depth from its parent's depth. Render
left-padding of depth * 18 dp. Cap depth at 6 to keep deep
hierarchies visually bounded; the cap plateaus silently (no
glyph, channel still tappable, data carries the real depth).

== Responsive layout ==
Connected layout is now LayoutBuilder-driven. Below 840 dp wide
(Material's tablet/desktop breakpoint) the original stacked
column layout is used (Voice Bar on top, channel tree below).
At 840 dp and above the layout becomes a side-by-side Row with
the Voice Bar pinned at 320 dp on the left and the channel tree
Expanded on the right.

Verification
- cargo check --workspace: clean.
- cargo test --workspace --lib: 80 / 0 / 1 (unchanged Linux total;
  +2 new Windows-only tests not counted here).
- flutter analyze: clean (6 pre-existing Radio.groupValue infos).
- FRB bindings regenerated to expose BridgeError_ServerRejected.

2026-05-16 03:27:25 +08:00

EdisonJwa

0bef61aea2

feat(core): A.6 — supervisor reconnect with watchdog and event stream

Adds an end-to-end auto-reconnect path so a brief network outage no
longer leaves the client wedged in a half-dead state. The flow has
three layers, each motivated by a real failure mode observed on the
Moto G live test:

* `chanora_protocol::DisconnectReason` (`UserRequested` /
  `StreamEnded` / `Error(String)`) is reported on a `oneshot` when
  the per-connection task exits, so the supervisor can tell user
  intent apart from a real loss.
* `chanora_core` spawns a supervisor task per `ChanoraSession`. It
  listens for the loss notifier AND runs a watchdog that issues
  `snapshot()` probes every 5s with a 4s timeout — three consecutive
  misses synthesise a `DisconnectReason::Error(...)` and trigger the
  reconnect path. The watchdog catches the "ghost connected" case
  where tsclientlib silently resets internal state but the event
  stream never errors. Backoff schedule: 1s, 2s, 5s, 15s, 30s, 60s
  (capped). On success the supervisor swaps the dead `ProtocolClient`
  for the new one in place and, if audio was running, restarts the
  audio engine bound to the new `voice_in`/`voice_out` channels.
* `SessionEvent` (Connected / Lost / Reconnecting / Disconnected /
  AudioStarted / AudioStopped) is broadcast on a 64-slot channel.
  `chanora_bridge` re-exports it as `BridgeEvent` and exposes
  `events_stream(StreamSink)`; the Flutter side subscribes from
  `initState` and renders a reconnect banner with attempt count and
  delay. New `SnapshotProbe` exposes a clone-friendly snapshot path
  so the watchdog can probe without holding `&self` across awaits.

Localization adds `statusReconnecting` and `statusConnectionLost`
keys to `app_en.arb` and `app_zh.arb`.

Verified on Moto G Stylus 5G (Android 14) against cn.teamspeak.app:
killed Wi-Fi + cellular for ~70 s; watchdog declared loss at three
misses, supervisor walked the backoff schedule, and the UI
reconnected automatically once the radios came back. Snapshot tree
re-rendered without user action.

2026-05-15 01:06:07 +08:00

EdisonJwa

4915ec0a1b

feat(alpha): wire connect→snapshot→disconnect end-to-end (v0.1.0-alpha.1)

First Internal Alpha build per DEC-001. Closes the milestone of
'Flutter UI calls Rust via the typed bridge, Rust connects to a
TeamSpeak-compatible server through tsclientlib, returns a typed
snapshot, and disconnects cleanly.' Audio remains Beta scope.

Promotions from PoC:
  poc/tsclientlib-connect-spike  →  crates/chanora_protocol/

New product code:
  crates/chanora_protocol/src/{dto.rs,adapter.rs} — typed boundary
    over tsclientlib. Tokio task owns the Connection; public
    handle communicates via mpsc/oneshot. No tsclientlib types
    cross out of the crate (SAD-067 / SysDes-011 / SysDes-029).
  core/chanora_core/src/lib.rs — ChanoraSession composes the
    protocol crate, enforces the DEC-006 single-connection
    invariant.
  crates/chanora_bridge/src/{api.rs,frb_generated.rs} — FRB 2.12.0
    bridge per DEC-014. cdylib + staticlib + rlib. Typed
    BridgeSnapshot / BridgeChannel / BridgeClient / BridgeError
    DTOs. Process-wide OnceLock<Runtime> + OnceLock<ChanoraSession>.
  flutter_rust_bridge.yaml at repo root.
  apps/chanora_flutter/lib/main.dart — Alpha UI: server form,
    connect button, channel tree, disconnect.
  apps/chanora_flutter/lib/l10n/app_{en,zh}.arb expanded with the
    Alpha key set; ARB metadata reaffirms ADR-008 for
    server-provided content.
  Generated Dart bindings under apps/chanora_flutter/lib/src/rust/.

Empirical verification (2026-05-14):
  Workspace: cargo check + cargo test clean
    (workspace tests: all green).
  Bridge cdylib: target/release/libchanora_bridge.so produced
    (~15 MB).
  Flutter: flutter analyze clean; flutter test runs 3/3 green
    including the alpha_e2e_test that drives the full
      Dart → FRB → chanora_bridge → chanora_core → chanora_protocol
        → tsclientlib → UDP → cn.teamspeak.app
    path. The captured logcat/stdout shows the tsproto resender
    transitioning Connected → Disconnecting → Disconnected on
    clean teardown.

Architecture changes:
  - Removed the chanora_core ↔ chanora_bridge cyclic dependency.
    chanora_core no longer knows the bridge exists; the bridge
    maps from CoreError.
  - chanora_bridge crate's #![forbid(unsafe_code)] lint relaxed
    because FRB-generated glue legitimately uses unsafe at the
    FFI boundary. Hand-written code remains unsafe-free.

Open follow-ups (NOT in this Alpha):
  - Audio capture/playback wiring into chanora_audio
    (Beta scope per DEC-001).
  - Identity persistence via chanora_storage
    (currently regenerated on every connect).
  - Per-message diagnostics + redaction
    (chanora_diagnostics still scaffold).
  - Reconnect / network-loss recovery.
  - Mobile (Android) build of the bridge cdylib + UI verification.

2026-05-14 21:37:06 +08:00