From 00c8b5ae3a0853985a00acf0ce47662954c7bc6b Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 3 Mar 2026 13:38:06 +0800 Subject: [PATCH] [Chore] (MG_Backend/DirectVulkan): get rid of unused functions --- .../DirectVulkan/Renderer/VulkanRenderer.cpp | 42 ------------------- .../DirectVulkan/Renderer/VulkanRenderer.h | 7 ---- 2 files changed, 49 deletions(-) diff --git a/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.cpp b/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.cpp index 5ab70d3e..763cc678 100644 --- a/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.cpp +++ b/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.cpp @@ -224,48 +224,6 @@ namespace MobileGL::MG_Backend::DirectVulkan { MGLOG_I("VulkanRenderer shut down completed"); } - void VulkanRenderer::TransitionSwapchainImageToColorAttachment(VkCommandBuffer commandBuffer, Uint32 imageIndex) { - auto layout = m_swapchainObject.GetImageLayout(imageIndex); - Bool ok = VkTextureManager::TransitionImageLayout(commandBuffer, m_swapchainObject.GetImage(imageIndex), - layout, VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL, - VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, - 0, VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, - VK_IMAGE_ASPECT_COLOR_BIT); - MOBILEGL_ASSERT(ok, "TransitionSwapchainImageToColorAttachment failed"); - m_swapchainObject.SetImageLayout(imageIndex, VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL); - } - - void VulkanRenderer::TransitionDepthStencilImageToAttachment(VkCommandBuffer commandBuffer, Uint32 imageIndex) { - if (m_swapchainObject.GetDepthStencilFormat() == VK_FORMAT_UNDEFINED) { - return; - } - - VkImageAspectFlags aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT; - const auto depthStencilFormat = m_swapchainObject.GetDepthStencilFormat(); - if (depthStencilFormat == VK_FORMAT_D24_UNORM_S8_UINT || depthStencilFormat == VK_FORMAT_D32_SFLOAT_S8_UINT) { - aspectMask |= VK_IMAGE_ASPECT_STENCIL_BIT; - } - - auto oldLayout = m_swapchainObject.GetDepthStencilImageLayout(imageIndex); - Bool ok = VkTextureManager::TransitionImageLayout( - commandBuffer, m_swapchainObject.GetDepthStencilImage(imageIndex), - oldLayout, VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL, - VK_PIPELINE_STAGE_TOP_OF_PIPE_BIT, - VK_PIPELINE_STAGE_EARLY_FRAGMENT_TESTS_BIT | VK_PIPELINE_STAGE_LATE_FRAGMENT_TESTS_BIT, 0, - VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, aspectMask); - MOBILEGL_ASSERT(ok, "TransitionDepthStencilImageToAttachment failed"); - m_swapchainObject.SetDepthStencilImageLayout(imageIndex, VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL); - } - - void VulkanRenderer::EndFrameRecordingIfNeeded() { - auto& frame = m_frameContext.GetCurrent(); - if (!frame.isCommandRecording) { - return; - } - - m_frameContext.EndCommandRecording(); - } - void VulkanRenderer::DeferDestroyBuffer(VkBufferObject& buffer) { if (!buffer.IsValid()) { return; diff --git a/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.h b/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.h index 1b2672ff..01b4aad5 100644 --- a/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.h +++ b/MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.h @@ -100,15 +100,11 @@ namespace MobileGL::MG_Backend::DirectVulkan { VkInstance m_instance = VK_NULL_HANDLE; VkDebugUtilsMessengerEXT m_debugMessenger = VK_NULL_HANDLE; PhysicalDevice m_physicalDevice; - // VkPhysicalDevice m_physicalDevice = VK_NULL_HANDLE; VkDevice m_device = VK_NULL_HANDLE; VmaAllocator m_allocator = nullptr; VkSurfaceKHR m_surface = VK_NULL_HANDLE; SwapchainObject m_swapchainObject; - // Vector m_queueFamilies; - // QueueFamilyIndices m_queueFamilyIndices; - VkQueue m_graphicsQueue = VK_NULL_HANDLE; VkQueue m_presentQueue = VK_NULL_HANDLE; Bool m_drawIndirectCountExtensionEnabled = false; @@ -159,9 +155,6 @@ namespace MobileGL::MG_Backend::DirectVulkan { const MG_State::GLState::VertexArrayObject& vao, const MG_State::GLState::FramebufferObject& drawFbo); - void TransitionSwapchainImageToColorAttachment(VkCommandBuffer commandBuffer, Uint32 imageIndex); - void TransitionDepthStencilImageToAttachment(VkCommandBuffer commandBuffer, Uint32 imageIndex); - void EndFrameRecordingIfNeeded(); void DeferDestroyBuffer(VkBufferObject& buffer); void CollectDeferredBufferReleases(Uint32 frameIndex); Bool EnsureFrameUploadBufferCapacity(Uint32 frameIndex, Bool isIndexBuffer, VkDeviceSize requiredEndOffset,