From 0650608ddc44219a13934f6700361f34808ac016 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Fri, 9 Oct 2026 14:29:53 -0400 Subject: [PATCH] User guide: env fallback now read consistently. --- userguide/android-plugin.md | 3 ++- userguide/building.md | 4 ++-- userguide/troubleshooting.md | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/userguide/android-plugin.md b/userguide/android-plugin.md index 354b021f..bc590050 100644 --- a/userguide/android-plugin.md +++ b/userguide/android-plugin.md @@ -74,7 +74,8 @@ latency. The plugin's launcher environment includes `MOBILEGL_TRANSPORT=inproc` **only if** the APK was built with `-Pmobilegl.buildDisaggregated=ON` or `-Pmobilegl.buildDisaggregatedInproc=ON` passed explicitly -(the CI build of `feat/disaggregated` does this). A plain `gradle :app:assemblePluginRelease` +(or the matching `MOBILEGL_BUILD_DISAGGREGATED` / `MOBILEGL_BUILD_DISAGGREGATED_INPROC` environment +variable set to `ON`; the CI build of `feat/disaggregated` does this). A plain `gradle :app:assemblePluginRelease` still builds the split layer into the library, but the launcher environment then omits the transport and the plugin runs monolith. Either rebuild with the property, or add `MOBILEGL_TRANSPORT=inproc` in the launcher's environment editor. diff --git a/userguide/building.md b/userguide/building.md index 2d747d6a..ac07948e 100644 --- a/userguide/building.md +++ b/userguide/building.md @@ -168,8 +168,8 @@ Pass with `-P=`. Some can also come from an environment variable. | `mobilegl.apkSuffix` | `MOBILEGL_APK_SUFFIX` | git short hash | Suffix in the APK file name | | `mobilegl.debuggableRelease` | | `false` | Make the release build debuggable | -Prefer the `-P` form for `mobilegl.buildDisaggregated`: the plugin's two Gradle scripts read the -environment fallback differently. +A `-P` property wins over its environment variable. The plugin's Gradle scripts and the library's script +all read the `MOBILEGL_BUILD_DISAGGREGATED` and `MOBILEGL_BUILD_DISAGGREGATED_INPROC` fallbacks. ## CMake options diff --git a/userguide/troubleshooting.md b/userguide/troubleshooting.md index 0905dec8..de86ab85 100644 --- a/userguide/troubleshooting.md +++ b/userguide/troubleshooting.md @@ -51,7 +51,7 @@ The renderer string does not mention Espryt or Magma. - `Config: MOBILEGL_TRANSPORT='unix:...' names a transport ... staying on monolith`: put the endpoint in `MOBILEGL_IPC_CONTROL` and set `MOBILEGL_TRANSPORT=spawn`. - The plugin runs monolith in the launcher although you expected `inproc`: the APK was built without - an explicit `-Pmobilegl.buildDisaggregated=ON`, so its launcher environment has no + an explicit `-Pmobilegl.buildDisaggregated=ON` (or `MOBILEGL_BUILD_DISAGGREGATED=ON` in the environment), so its launcher environment has no `MOBILEGL_TRANSPORT`. Rebuild, or add `MOBILEGL_TRANSPORT=inproc` in the launcher's environment editor.