mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-17 23:13:22 +09:00
[MG_IntegrationTest, docs] (P7): the upload-shape gate was measuring its own bounding box; inset the scatter so the box/rect decision is reachable
Rework round 2 of 4 after the D2 review (fable, ID-P7-8), which found that this gate's
numbers were right and its SUBJECT was wrong.
The scatter wrote 40 2x2 rects at x=((i*7)%32)*2, y=((i*5)%32)*2 into a 64-px atlas.
Both strides are surjective onto 0..31 over 40 iterations - rect 9 lands at x=62, rect 19
at y=62 - so the rects' union box covered the WHOLE LEVEL, and the server's subRectEligible
(Managers.cpp:8486-8491) requires !dirtyRegion.CoversWholeLevel, a BOUNDING-BOX test
(MipmapStorage.h:30-33). Both scatter textures were rect-INELIGIBLE on every arm before
:8649's unpack-ring policy was ever consulted. The box-versus-rect decision the scenario
exists to pin was never reached for the two textures it scatters into, and the only
texture that could move under any red-once was the contiguous control band - which is
exactly what the old substitute red-once's box=6 rect=3 jobs=12 was.
kScatterMargin insets the scatter by one rect: same 40 writes, same coarse stride, union
box bounded at (2,2)..(62,54). The gold row is UNCHANGED at emit=9 box=9 rect=0 jobs=9 on
all four arms - but it now means what it says.
THE RED-ONCE IS NOW ZERO-PATCH, which is stronger than the throwaway source edit it
replaces: MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1 alone gives box=3 rect=6 jobs=183 with
bytes/f[tex] falling from 104448 to 9024, while all 26 pixel cases stay green. BOTH
SCATTER TEXTURES moved - box=3 is the contiguous band alone, rect=6 is the plain atlas
AND the atlas written through the glTextureView, and jobs=183 = 3 + 6x30 confirms thirty
rects per scatter emission. The same knob was green before the inset, which is the
evidence that CoversWholeLevel was short-circuiting the decision.
The three prose sites are rewritten accordingly: the scenario's gold-table rationale, the
MEASUREMENTS.md 13.1 reading and the package note's red-once section now explain
attempts 1-3 as mutations of a decision the client already makes correctly, and attempt 4
by CoversWholeLevel rather than by the ring.
Also PipeStatsWindow gains LastFrom{Client,Server}LogSince, and the gate reads its two
role windows since a mark taken before the counted workload. The server writes an EMPTY
teardown window after the counted one, so "the last line in the file" is one shutdown
away from reporting four zeroes as the workload's shape. Moving to a marked read exposed
a second latent defect in the same assertion: ASSERT_TRUE(clientWindow.found) over the
whole file was satisfied by the "counters ON" BANNER in all three split arms, claiming a
window had been read when none had. The assertion is now on the window that actually
carries the tex[] bracket.
This commit is contained in:
@@ -790,12 +790,22 @@ P6(spawn transport)的实现包(a6 / c6 / lk / so / sm / cp / hs / dl / st
|
||||
P4a 的记录是两张纹理、无 client emitter 的 `emit=6 box=6 rect=0 jobs=6`(`ctu=0`),与本行
|
||||
**不可比**:工作负载不同。
|
||||
|
||||
`rect=0` 不是散点图案的偶然,而是 unpack-ring 策略的既定输出:`Managers.cpp:8652` 在
|
||||
`UnpackRingAvailable()` 时把 `dirtyRectCount` 清零("One box, one job",即 Mali 悬崖的既有缓解),
|
||||
`:8764` 的 `rectShape` 还要求 `dirtyRectCount >= 2`。因此**客户端任何谓词翻转都动不了这四个数**
|
||||
——翻转 `summedArea*4 >= unionArea*3` 全绿,见 `notes/p34b/espryt-d2.md` 的四次尝试。红一次由
|
||||
"把 union box 切成两半 + `MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1`"做到:`box=6 rect=3 jobs=12`,
|
||||
而 26 个像素用例全绿。
|
||||
`rect=0` 是 **unpack-ring 策略的既定输出**:client 确实建出 30 个 rect(2 texel 间隙,
|
||||
`RegionsTouch` 不合并;summed area 120 远低于 union box 的 3/4,两道 client 侧谓词都不取 box 臂),
|
||||
记录把 30 个 region 全部带过去;是 server 在 `Managers.cpp:8649` 的
|
||||
`if (UnpackRingAvailable()) dirtyRectCount = 0;` 决定取 box——"One box, one job",Mali 悬崖的既有
|
||||
缓解。门钉的就是这个策略的输出。
|
||||
|
||||
**散点图案本身是被修过的(评审 fable 指出)**:原来的 stride `x=((i*7)%32)*2` / `y=((i*5)%32)*2`
|
||||
在 64 px 图集里会打到 x=62、y=62,union box 覆盖整个 level,而 server 的 `subRectEligible`
|
||||
(`Managers.cpp:8486-8491`)要求 `!dirtyRegion.CoversWholeLevel`(`MipmapStorage.h:30-33`,**包围盒**
|
||||
判据)——两张散点纹理在 ring 策略之前就已经 rect-ineligible,金标数字一样但量的不是同一件事。
|
||||
内缩一个 rect(`kScatterMargin`)后 union box 落在 (2,2)..(62,54),决策点才真正带电。
|
||||
|
||||
红一次因此是**零补丁**的:`MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1` 一个环境变量就把两张散点纹理
|
||||
从 box 翻成 rect——`box=3 rect=6 jobs=183`(3 = 连续带 x3 帧;6 = 两张散点 x3 帧;183 = 3 + 6x30),
|
||||
`bytes/f[tex]` 同时从 104448 降到 9024,而 26 个像素用例全绿。内缩之前同一个变量是全绿的,这正是
|
||||
`CoversWholeLevel` 把决策点短路掉的证据。
|
||||
|
||||
### 13.2 client 半边的读法(本包的修正)
|
||||
|
||||
|
||||
@@ -138,42 +138,54 @@ client's true count in every arm, because the test process is the client under a
|
||||
|
||||
### Red-once (R-16)
|
||||
|
||||
**The prescribed flip does not reach this workload, and that is a finding.** Flipping
|
||||
`summedArea * 4 >= unionArea * 3` in `MipmapStorage::GetDirtyRects` leaves the gate GREEN. Four
|
||||
attempts, in order, all green:
|
||||
**The prescribed flip does not reach this workload — but not for the reason this note first
|
||||
gave.** Flipping `summedArea * 4 >= unionArea * 3` in `MipmapStorage::GetDirtyRects` leaves the
|
||||
gate green, and so do two other client-side mutations:
|
||||
|
||||
1. flip `summedArea*4 >= unionArea*3` → green
|
||||
2. `rects.size() < 2` → `rects.empty()` → green
|
||||
3. remove the union-box re-seed in `MarkDirtyRegion` → green
|
||||
4. `MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1` alone → green
|
||||
1. flip `summedArea*4 >= unionArea*3` -> green
|
||||
2. `rects.size() < 2` -> `rects.empty()` -> green
|
||||
3. remove the union-box re-seed in `MarkDirtyRegion` -> green
|
||||
4. `MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1` alone -> green **(before the geometry fix)**
|
||||
|
||||
The reason is two gates downstream of the predicate, either of which alone forces the box arm:
|
||||
The first three are green because they are mutations of a decision the CLIENT has already made
|
||||
correctly: with the inset scatter the client hands over thirty rects, and none of those three
|
||||
predicates is the one that takes the box arm. Attempt 4 was green for a completely different and
|
||||
much worse reason, and finding it is the reviewer's (fable, ID-P7-8):
|
||||
|
||||
* `Managers.cpp:8764` `rectShape = subRectEligible && dirtyRectCount >= 2` — the SERVER needs at
|
||||
least two rects, and the client's list collapses to one for this workload; and
|
||||
* `Managers.cpp:8652` `if (BufferImpl::UnpackRingAvailable()) dirtyRectCount = 0;` — **by design**:
|
||||
"through the unpack ring every glTexSubImage is a GPU copy job (Mali), so ~100 sprite rects
|
||||
become ~100 jobs whose fixed cost dwarfs the union box's extra bytes… One box, one job."
|
||||
> the original stride `x = ((i*7) % 32) * 2`, `y = ((i*5) % 32) * 2` reaches x=62 (rect 9) and
|
||||
> y=62 (rect 19) in a 64-px atlas, so the rects' union box covered the WHOLE LEVEL — and the
|
||||
> server's `subRectEligible` (`Managers.cpp:8486-8491`) requires
|
||||
> `!dirtyRegion.CoversWholeLevel`, a **bounding-box** test (`MipmapStorage.h:30-33`). Both
|
||||
> scatter textures were rect-INELIGIBLE before `:8649`'s ring policy was consulted.
|
||||
|
||||
So `box=9 rect=0` is not an accident of the scatter pattern: it is the unpack-ring policy's
|
||||
intended output, and no client-side predicate can move it while the ring is available. The gold
|
||||
row pins the policy's output, which is the right thing to pin.
|
||||
So the gate's numbers were right and its subject was wrong: the box-versus-rect decision it
|
||||
exists to pin was never reached for the two textures the workload scatters into, and the only
|
||||
texture that could move under any red-once was the contiguous control band. The first
|
||||
substitute red-once's `box=6 rect=3 jobs=12` was exactly that band (64x8, cut in two, three
|
||||
frames) — **neither scatter texture moved**, which is what gave the wrong explanation away.
|
||||
|
||||
The red-once that DOES bite makes `GetDirtyRects` hand back the union box cut in two AND disables
|
||||
the unpack ring:
|
||||
**The fix** is `kScatterMargin`: inset the scatter by one rect so the union box bounds at
|
||||
`(2,2)..(62,54)` and covers no level. Same 40 writes, same coarse stride, decision point live.
|
||||
The gold row is UNCHANGED at `emit=9 box=9 rect=0 jobs=9` — but it now means what it says, and
|
||||
`rect=0` is genuinely the unpack-ring policy's output rather than a bounding-box accident.
|
||||
|
||||
**The red-once after the fix is ZERO-PATCH**, which is stronger than any throwaway source edit:
|
||||
|
||||
```
|
||||
DirectGLES.TextureUploadShape. ... FAILED
|
||||
the BOX/RECT split moved: 6 box emissions against a gold of 9
|
||||
the BOX/RECT split moved: 3 rect-list emissions against a gold of 0
|
||||
the JOB count moved: 12 against a gold of 9
|
||||
tex[emit=9 box=6 rect=3 jobs=12]
|
||||
MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1
|
||||
tex[emit=9 box=3 rect=6 jobs=183] bytes/f[tex=9024, was 104448]
|
||||
the BOX/RECT split moved: 3 box emissions against a gold of 9
|
||||
the BOX/RECT split moved: 6 rect-list emissions against a gold of 0
|
||||
the JOB count moved: 183 against a gold of 9
|
||||
```
|
||||
|
||||
and all 26 pixel cases of `TextureView` / `TextureViewAlias` / `SampledSetStaleness` /
|
||||
`ImageSizeAfterRespec` / `CopyImageLevelRange` / `ClearThenReadPixels` stay GREEN under the same
|
||||
patch — the required property, and the point of the gate: SSIM and every pixel assertion are blind
|
||||
to a shape that inverted.
|
||||
**Which texture moved: BOTH SCATTER TEXTURES.** `box=3` is the contiguous control band alone
|
||||
(one contiguous region -> one rect -> not >= 2 -> box), `rect=6` is the plain scatter atlas AND
|
||||
the atlas written through the `glTextureView`, three frames each, and `jobs=183 = 3 + 6 x 30`
|
||||
confirms thirty rects per scatter emission. All 26 pixel cases of `TextureView` /
|
||||
`TextureViewAlias` / `SampledSetStaleness` / `ImageSizeAfterRespec` / `CopyImageLevelRange` /
|
||||
`ClearThenReadPixels` stay GREEN under the same knob — the required property, and the point of
|
||||
the gate: every pixel assertion is blind to a shape that inverted.
|
||||
|
||||
### The Mali frame-time delta is NOT published
|
||||
|
||||
|
||||
Reference in New Issue
Block a user