From 10220b564e8429c00abe4dc8d0863a3f68da11e1 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 22 Sep 2026 21:53:26 -0400 Subject: [PATCH] [tools] (P7): the merged server-log fatal names MOBILEGL_IPC_CONTROL, so the tcp arm's red still says tcp - the round-2 merge folded "TCP session has no forwarded server log" into the one server-log check for every transport, and its message named only MOBILEGL_TRANSPORT - which is `spawn` for the tcp arm too (tcp = spawn + MOBILEGL_IPC_CONTROL=tcp://), so the tcp arm's missing forwarded log read as a plain spawn red - the message carries MOBILEGL_IPC_CONTROL='...' after the transport (empty for inproc and plain spawn); message only, no check moved --- tools/trace_replay/run_trace_case.cmake | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/trace_replay/run_trace_case.cmake b/tools/trace_replay/run_trace_case.cmake index c479227d..d5936128 100644 --- a/tools/trace_replay/run_trace_case.cmake +++ b/tools/trace_replay/run_trace_case.cmake @@ -380,9 +380,14 @@ if(DEFINED ENV{MOBILEGL_TRANSPORT} AND NOT "$ENV{MOBILEGL_TRANSPORT}" STREQUAL " # failure also leaves no server log; checked first, this would report "the server left # no file" for a run whose more specific diagnosis is "resolved, but carries no spawn # ARMED", and send the reader to the wrong process. + # THE MESSAGE NAMES MOBILEGL_IPC_CONTROL AS WELL. The tcp arm is MOBILEGL_TRANSPORT=spawn + # plus MOBILEGL_IPC_CONTROL=tcp://..., so the transport alone reads the same for the spawn + # arm and for the tcp arm, whose missing file is the fixture's forwarded server log (the + # check this one absorbed used to say "TCP session has no forwarded server log"). if(NOT EXISTS "${mobilegl_server_log}") message(FATAL_ERROR - "${split_case}: MOBILEGL_TRANSPORT=$ENV{MOBILEGL_TRANSPORT} but the run wrote no " + "${split_case}: MOBILEGL_TRANSPORT=$ENV{MOBILEGL_TRANSPORT} " + "MOBILEGL_IPC_CONTROL='$ENV{MOBILEGL_IPC_CONTROL}' but the run wrote no " "${mobilegl_server_log}, so the server role's Fatal{ and MGWIRE-FLOOR lines " "cannot be counted. A split retrace with no server log cannot be counted as a " "clean one.")