swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-09-07 19:58:32 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] (ShaderTranspiler): count a 64-bit integer vector as two locations in the XFB flattener's LocationSpan - it read 64-bitness off the element's float type alone, so an i64vec3/4 member packed the members after it onto locations it already owns

Browse Source
This commit is contained in:
swung0x48
2026-08-28 06:22:11 -04:00
parent bf9cfb3079
commit 1c113e4b26
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Util/ShaderTranspiler/SpirvPasses/FlattenXfbInterfaceBlocksPass.cpp
+10 -4
View File
@@ -78,9 +78,9 @@ namespace MobileGL {
} }
// Locations one value of `type` occupies (GL 4.6 core 11.1.2.1 / 15.2): a // Locations one value of `type` occupies (GL 4.6 core 11.1.2.1 / 15.2): a
// matrix takes one per column, a double-precision vector wider than two takes // matrix takes one per column, a 64-bit vector wider than two takes two, an
// two, an array takes its element's span once per element. 0 means "this pass // array takes its element's span once per element. 0 means "this pass cannot
// cannot place it", which declines the whole block rather than guessing. // place it", which declines the whole block rather than guessing.
Uint32 LocationSpan(const analysis::Type* type) { Uint32 LocationSpan(const analysis::Type* type) {
if (type == nullptr) return 0; if (type == nullptr) return 0;
if (type->AsFloat() != nullptr || type->AsInteger() != nullptr || if (type->AsFloat() != nullptr || type->AsInteger() != nullptr ||
@@ -93,8 +93,14 @@ namespace MobileGL {
element->AsBool() == nullptr) { element->AsBool() == nullptr) {
return 0; return 0;
} }
// 64-bit INTEGERS span two locations exactly like doubles do:
// ARB_gpu_shader_int64 extends 11.1.2.1's double-precision rule
// verbatim to i64/u64. Answering 1 for an i64vec4 would pack the
// members after it onto locations that varying already owns.
const auto* elementFloat = element->AsFloat(); const auto* elementFloat = element->AsFloat();
const Bool is64Bit = elementFloat != nullptr && elementFloat->width() == 64; const auto* elementInteger = element->AsInteger();
const Bool is64Bit = (elementFloat != nullptr && elementFloat->width() == 64) ||
(elementInteger != nullptr && elementInteger->width() == 64);
return (is64Bit && vector->element_count() > 2) ? 2u : 1u; return (is64Bit && vector->element_count() > 2) ? 2u : 1u;
} }
if (const auto* matrix = type->AsMatrix()) { if (const auto* matrix = type->AsMatrix()) {