mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-17 15:03:25 +09:00
[MG_IntegrationTest, docs] (P7): the whole integration binary runs under Magma split, and it is one red
Tier 2 replays the split-arm registrations - ~100 scenarios, the set Espryt's disaggregation work
has carried since P5 - and it measured green on Magma across all three transports. That is a real
result but it is NOT exit gate 1. The gate says the INTEGRATION BINARY is green under Magma split,
and the set that names is the one the monolith DirectVulkan. arm runs: the whole suite minus
MGL_ITEST_MONOLITH_MECHANISM_FILTER. 510 cases against tier 2's 102, and the readback matrices,
the same-texture copy shapes and the odd-offset uniform ranges are in it and nowhere else in the
disaggregated registry.
integration-magma-full-{split,spawn,tcp}, in no gating step, private log per entry through a list
of its own. THE RESULT: 453/0/57 on inproc, 453/0/57 on spawn, 454/1/57 on tcp - and not one of
the 1530 entries reaches any of the tree's fifteen @P7 named refusals. The single red is
IterationRPProgram203Scenario.FixedCompleteInputProducesFixedCompleteGoldenOutput on the TCP arm:
one texel of 262656, texel 0, which is the case's own exposure value
(IterationRPProgram203Scenario.cpp:371, actual half bits (0x357a, 0x4b65) against golden
(0x3a74, 0x4821)). Deterministic 5/5 on tcp; 5/5 GREEN on inproc, on spawn and on the monolith
control. spawn and tcp differ only in MOBILEGL_IPC_DATA, so the suspicion is the STREAM data path
and not "two processes"; the GLES tcp lane is green in the same run, so it is not the fixture.
Not fixed here - it is what the census is for.
TWO ENVIRONMENT DIFFERENCES FROM THE GATED TIERS, both measured rather than assumed:
* NO MGITEST_SPLIT_LANE=1. That marker arms ScenarioFixture's destructor assertion - a case in
an armed split lane must have moved the client encoder's record ordinal - which is right for
a curated lane and wrong for a whole-binary census. With it set, the first run produced 13
reds, all `EmitSeq was 20 at SetUp and is 20 now`: AdvertisedLimitsScenario (8),
SpirvShaderBinaryScenario (4) and ProgramPipelineScenario.AReservedName - a limits query is
answered from the client's CapsMirror and a shader-binary error surface never reaches a verb.
Those 13 would red on a DirectGLES census too. What it gives up is stated in the comment: this
tier does not prove its records crossed, and the tcp topology proof is inert in it.
* DualBlockScenario.* filtered out. Its green REQUIRES MOBILEGL_IPC_ROLE_SPLIT_STATE=1 and a
census must not set that knob; without it the case is red by name, which is its documented
negative-control behaviour. The monolith arm skips it for the same class of reason.
CtWireScenario gets MOBILEGL_TEST_SERVER_COUNTERS=1 in this tier - a switch that makes a counter
readable, not an oracle that asserts - because without it the spawn arm's ApplierReset case reds
on "server control-record telemetry missing", which says nothing about Magma. The strict-arming,
pmap and persistent-map-arm markers stay out.
The inproc-only exclusion in spawn_lane_parity.py is now PER TIER: in the gated tier the two
scenarios are registered on the inproc arm alone, in the census they are on every arm and simply
skip, so excluding them there would manufacture a spurious "extra".
Measured after the change: every pre-existing lane unchanged and green (magma-split 73,
spawn 52, tcp 54, all-* 102/102/104, GLES 186/102/104, buffers 19, runahead 14, caches 7), the
dual-block census 257 green / 2 skipped / 0 red with an empty ratchet, both new CI steps green,
parity RC=0 across all three tiers, G14 4155 -> 6095 with removed=0.
The note now carries the grouped red list, the 57 named skips by reason, the four pieces of
evidence that the tcp red is a defect and not plumbing, and six findings - the first being that
wave 2's clusters cannot be scheduled from this lane's red list, because on lavapipe there is
essentially none.
This commit is contained in:
@@ -3090,6 +3090,89 @@ if (MOBILEGL_BUILD_DISAGGREGATED)
|
||||
endforeach()
|
||||
endif()
|
||||
|
||||
# =====================================================================================
|
||||
# P7 PACKAGE L: THE WHOLE INTEGRATION BINARY UNDER MAGMA SPLIT - TIER 3, INFORMATIONAL
|
||||
# =====================================================================================
|
||||
#
|
||||
# WHY A THIRD TIER, AND WHY IT IS THE ONE THAT ANSWERS THE EXIT GATE. Tier 2 above replays the
|
||||
# split-arm registrations, which is ~100 scenarios - the set Espryt's disaggregation work has
|
||||
# been carrying since P5. It measured GREEN on Magma, all three transports, and that is a real
|
||||
# result but it is NOT exit gate 1. The gate says the INTEGRATION BINARY is green under Magma
|
||||
# split, and the set that phrase names is the one the monolith `DirectVulkan.` arm runs: the
|
||||
# whole suite minus MGL_ITEST_MONOLITH_MECHANISM_FILTER (the mechanism oracles, which toggle
|
||||
# process-local push masks, pointer-key ABA, direct persistent adoption or synchronous stats
|
||||
# slots and therefore must not inherit a transport). 511 cases, against tier 2's 102.
|
||||
#
|
||||
# THIS IS WHERE THE @P7 REFUSALS LIVE. None of tier 2's scenarios reaches one; the readback
|
||||
# matrices, the same-texture copy shapes and the odd-offset uniform ranges do, and they are in
|
||||
# this set and nowhere else in the disaggregated registry. THE FIRST RUN'S RED LIST IS WHAT
|
||||
# WAVE 2's CLUSTERS ARE SCHEDULED FROM - see notes/p7/magma-two-process-first-run.md.
|
||||
#
|
||||
# IN NO CI GATING STEP, and that is the whole design: a lane that must be green cannot carry a
|
||||
# census. A case leaves this tier for a gated one with the commit that retires its blocker.
|
||||
# The label spelling follows tier 2's rule (`ctest -L` is a regex, ID-131): the tier word goes
|
||||
# in the MIDDLE, so `-L integration-magma-split` and `-L integration-magma-all-split` cannot
|
||||
# reach `integration-magma-full-split` and vice versa.
|
||||
#
|
||||
# THE SAME PRIVATE-LOG DISCIPLINE as every other split-family entry, through a list of its own
|
||||
# rather than the shared MGL_SPLIT_ARM_TEST_LISTS: that list ALSO carries the per-entry lane
|
||||
# markers (strict-arming, pmap, server counters) and applying them to a census would arm three
|
||||
# unrelated oracles on cases that are here to be read, not to assert. SplitLogPaths.cmake.in
|
||||
# walks this list for the log path alone.
|
||||
#
|
||||
# PLACED AFTER TIER 2 AND BEFORE THE configure_file, for that file's stated reason.
|
||||
#
|
||||
# TWO DIFFERENCES FROM TIERS 1 AND 2's ENVIRONMENT, BOTH MEASURED RATHER THAN ASSUMED.
|
||||
#
|
||||
# 1. NO MGITEST_SPLIT_LANE=1. That marker arms ScenarioFixture's destructor assertion
|
||||
# (ScenarioFixture.h:85-100): a case in an armed split lane must have MOVED the client
|
||||
# encoder's record ordinal, because "the workload drew, cleared and read pixels, so
|
||||
# records were due". That is exactly right for a CURATED lane, where every entry draws.
|
||||
# It is wrong for a whole-binary census, which also contains query-only cases: the first
|
||||
# run of this tier with the marker set produced 13 reds - AdvertisedLimitsScenario (8),
|
||||
# SpirvShaderBinaryScenario (4) and ProgramPipelineScenario.AReservedName… - every one of
|
||||
# them `EmitSeq was 20 at SetUp and is 20 now`, because a limits query is answered from
|
||||
# the client's CapsMirror and a shader-binary error surface never reaches a verb. Those
|
||||
# 13 would red on a DirectGLES census too; they are a property of the census, not of
|
||||
# Magma, and leaving them in would have buried the real list under noise.
|
||||
# WHAT THIS GIVES UP, stated rather than discovered later: this tier does not prove its
|
||||
# records crossed the wire, and the tcp arm's "Dial=Connect created no local server child"
|
||||
# topology proof (ScenarioFixture.h:160-171, inside the same armed block) is inert here.
|
||||
# Tiers 1 and 2 keep both, and they are the tiers that gate. MGITEST_TCP_LANE is still in
|
||||
# the shared tcp fragment - it simply has no reader in this tier.
|
||||
# 2. DualBlockScenario.* IS FILTERED OUT. Its green REQUIRES MOBILEGL_IPC_ROLE_SPLIT_STATE=1,
|
||||
# and a census must not set that knob - under it every barrier-pulled read aborts, which
|
||||
# would replace this tier's subject with a different experiment. Without the knob the case
|
||||
# is RED BY NAME (`MGPipeRoleSplitRehearsalActive() is false`), which is its documented
|
||||
# negative-control behaviour and not a finding. The monolith `DirectVulkan.` arm has the
|
||||
# same case and it SKIPS there, because that runtime is not split at all. Its own lane,
|
||||
# `integration-dualblock-split`, is where it is read.
|
||||
if (MOBILEGL_BUILD_DISAGGREGATED)
|
||||
set(MGL_MAGMA_FULL_TEST_LISTS "")
|
||||
foreach(mglItestArm IN LISTS MGL_ITEST_MAGMA_ARMS)
|
||||
mgl_itest_magma_arm_shape(${mglItestArm})
|
||||
string(TOUPPER "${mglItestArm}" mglItestArmUpper)
|
||||
mgl_itest_join_environment(mglItestMagmaFullEnvironment
|
||||
"MOBILEGL_BACKEND_TYPE=DirectVulkan" "MOBILEGL_ITEST_REQUIRE_GPU=1"
|
||||
${MGL_ITEST_CAPABILITY_ENV} ${MGL_ITEST_VULKAN_ENV} ${mglItestArmTransportEnv})
|
||||
gtest_discover_tests(MobileGLIntegrationTest
|
||||
TEST_PREFIX "DirectVulkan.${mglItestArm}.Full."
|
||||
TEST_LIST "MGL_MAGMA_FULL_TESTS_${mglItestArmUpper}"
|
||||
TEST_FILTER "-${MGL_ITEST_MONOLITH_MECHANISM_FILTER}:DualBlockScenario.*"
|
||||
DISCOVERY_TIMEOUT 30
|
||||
PROPERTIES
|
||||
LABELS "integration-magma-full-${mglItestArmLower}"
|
||||
TIMEOUT ${MGL_ITEST_TIMEOUT}
|
||||
${mglItestArmProperties}
|
||||
ENVIRONMENT "${mglItestMagmaFullEnvironment}"
|
||||
)
|
||||
list(APPEND MGL_MAGMA_FULL_TEST_LISTS "MGL_MAGMA_FULL_TESTS_${mglItestArmUpper}")
|
||||
endforeach()
|
||||
message(STATUS "Integration tests: P7 package L tier 3 - the whole integration binary on "
|
||||
"DirectVulkan x {inproc, spawn, tcp} under the informational "
|
||||
"integration-magma-full-{split,spawn,tcp} labels (no CI gate)")
|
||||
endif()
|
||||
|
||||
if (MOBILEGL_BUILD_DISAGGREGATED)
|
||||
# LAST, so every mgl_itest_register_split_arms call above has already contributed its list
|
||||
# name. Apply per-entry paths after GoogleTest discovery has populated the TEST_LISTs.
|
||||
|
||||
@@ -29,6 +29,29 @@ foreach(listName IN ITEMS @MGL_SPLIT_ARM_TEST_LISTS@)
|
||||
endif()
|
||||
endforeach()
|
||||
endforeach()
|
||||
# P7 package L tier 3: the whole-suite Magma census. A LIST OF ITS OWN, and the log path is the
|
||||
# ONLY property it gets - the loop above also arms the strict-arming, pmap and server-counter
|
||||
# lane markers by entry name, and a census is here to be READ, not to assert three unrelated
|
||||
# oracles it never opted into. The path itself is not optional: these entries are
|
||||
# DirectVulkan.{Split,Spawn,Tcp}. names, so split_log_paths.py's ownership gate requires exactly
|
||||
# one absolute private path each, and on the spawn and tcp arms two processes append to it.
|
||||
#
|
||||
# ONE EXCEPTION, AND IT IS TELEMETRY RATHER THAN AN ORACLE: CtWireScenario reads the server's
|
||||
# own control-record tallies, and without MOBILEGL_TEST_SERVER_COUNTERS=1 they are not published
|
||||
# at all - the case then reds on `server control-record telemetry missing`, which says nothing
|
||||
# about Magma. Measured: that is exactly what the spawn arm's ApplierReset case did on this
|
||||
# tier's first run. A switch that makes a counter readable is not the same kind of thing as the
|
||||
# strict-arming, pmap or persistent-map-arm markers above, which make a case ASSERT something it
|
||||
# never opted into, and those stay out of the census.
|
||||
foreach(listName IN ITEMS @MGL_MAGMA_FULL_TEST_LISTS@)
|
||||
foreach(entry IN LISTS ${listName})
|
||||
set_tests_properties("${entry}" PROPERTIES ENVIRONMENT
|
||||
"MOBILEGL_LOG_FILE_PATH=@CMAKE_CURRENT_BINARY_DIR@/split-logs/${entry}.log")
|
||||
if(entry MATCHES "CtWireScenario\\.")
|
||||
set_tests_properties("${entry}" PROPERTIES ENVIRONMENT "MOBILEGL_TEST_SERVER_COUNTERS=1")
|
||||
endif()
|
||||
endforeach()
|
||||
endforeach()
|
||||
foreach(entry IN LISTS MGL_SPLIT_PA_STRICT_DRAW_TESTS MGL_SPLIT_PA_STRICT_DISPATCH_TESTS)
|
||||
set_tests_properties("${entry}" PROPERTIES ENVIRONMENT
|
||||
"MOBILEGL_LOG_FILE_PATH=@CMAKE_CURRENT_BINARY_DIR@/split-logs/${entry}.log")
|
||||
|
||||
Reference in New Issue
Block a user