mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-16 14:33:24 +09:00
[MG_Pipe, MG_Impl, MG_State, MG_Remote, MG_Backend, MG_Test] (Disaggregated): P5e sb - set_shader_buffers is emitted, routed and applied
- MGPShaderBuffers::WritableMask is Uint32[3] and the POD grows 32 -> 40 (ID-104). One Uint32 could describe only the first 32 of an 84-point window, so a storage buffer bound at point 32 or above read as unwritable with nothing able to see it; the ruling widens the field rather than narrowing the window, which would change what an application may bind. MGPipeShaderBufferMaskHas / ...Set are the one spelling of the mask, so the emitter, the applier and the four backend sites cannot disagree about which word a point lives in. - MGPipeApplySetShaderBuffers has its body: per-class window, Start/Count validated against the capacity, the mask copied by word, ONE ShaderBuffersSerial advanced on every applied record and ADVANCED - never zeroed - by both resets, which also clear the three windows. - Route rows for opcode 38 on both arms (Mono_ and Wire_) and the server sink in the wire codec's decode switch, which is where a kCtxState row's sink lives - PipeApplier.cpp's ServerVerbSink has no method for it and the brief's "OnSetShaderBuffers" names no code. The codec also bounds Class and Start+Count where Count becomes a byte length. - New MG_Impl/Pipe/ShaderBufferEmit.h: one record per class, window = the touched high-water mark clamped to 84, zero early-out before any hash, a BASE binding travelling as kMGPipeWholeBuffer so the server re-resolves the extent at use, three suppressor slots (ruling 11), and the writable mask that replaces the backend's GPU-write walk. - BufferState gains a per-target bind-point generation (push-only, G1) and dirty bits 15/16/17 shutter on it instead of the buffer CONTENT aggregate. That aggregate answered the wrong question in both directions: any glBufferSubData fired all three, and glBindBufferBase fired none of them, because it mutates a binding point through a returned reference. Same defect class as P4a's glBindSampler hole. - Init.cpp publishes consumer bit 13 for DirectGLES and not for Magma (ID-106), in the same commit as the wired constant, and PipeFill's liveness gate asks R-8 for bit 13 in particular plus bit 13-requires-bit-7. - `Touch` joins the dirty-surface scanner's mutator prefixes; TouchBufferBindingPoint gets its row and SetNamedTransformFeedbackBinding's is rewritten now that bit 17 reads a generation a binding moves. Negative control 6 is re-pointed: the pair it used to refute is a live answer, and a control that has quietly become positive is what the self-test is for.
This commit is contained in:
@@ -652,6 +652,17 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
// (MGPipeTypes.h:820-823), because the two arrays stay index-aligned; a third
|
||||
// value would let a record describe spans for ranges it does not have.
|
||||
const auto& p = *static_cast<const MGPShaderBuffers*>(payload);
|
||||
// P5e (sb, CONTRACT-P5E.md §1): the class and the window, bounded HERE as well as
|
||||
// in the applier and for the reason SetShaderImages' Count is bounded here - this
|
||||
// is the arm that turns Count into a byte length, so a forged count has to be
|
||||
// refused before it is multiplied rather than after.
|
||||
if (p.Class >= kMGPipeShaderBufferClassCount) {
|
||||
WireProtocolFatalAt("SetShaderBuffers.Class", p.Class, kMGPipeShaderBufferClassCount);
|
||||
}
|
||||
if (static_cast<Uint64>(p.Start) + p.Count > kMGPipeMaxBufferBindingPoints) {
|
||||
WireProtocolFatalAt("SetShaderBuffers.Count", static_cast<Uint64>(p.Start) + p.Count,
|
||||
kMGPipeMaxBufferBindingPoints);
|
||||
}
|
||||
if (p.HostSpanCount != 0 && p.HostSpanCount != p.Count) {
|
||||
WireProtocolFatalAt("SetShaderBuffers.HostSpanCount", p.HostSpanCount, p.Count);
|
||||
}
|
||||
@@ -1830,16 +1841,17 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
return true;
|
||||
|
||||
case MGPWireOp::SetShaderBuffers: {
|
||||
// NO APPLIER ENTRY POINT EXISTS, and P5 does not invent one: the call is on
|
||||
// BRIEF §4's exclusion list, so a consumer written here would be a semantics
|
||||
// nobody can test this phase. What the record needs and cannot get later is its
|
||||
// TAIL ARITHMETIC, which MGPipeWireRecordLayout above has already run - including
|
||||
// the HostSpanCount-is-0-or-Count rule, the thing that keeps the two arrays
|
||||
// index-aligned.
|
||||
// P5e (sb, MG_Remote/CONTRACT-P5E.md §5.6): THE APPLIER ENTRY POINT EXISTS NOW and
|
||||
// this is the row's sink. The paragraph that stood here said "no applier entry
|
||||
// point exists, and P5 does not invent one: the call is on BRIEF §4's exclusion
|
||||
// list" - true for the whole of P5 through P5d, and withdrawn by the phase whose
|
||||
// entire point is that the server stops walking the client's binding-point table.
|
||||
//
|
||||
// kCapNeedsHostUboBytes is 0 for the whole of P5 (table 0), so the second tail is
|
||||
// always absent here; the honesty pass below is what says so out loud if it ever
|
||||
// is not.
|
||||
// THE HOST-SPAN PASS STILL RUNS FIRST, and it runs whether or not the record is
|
||||
// applied: kCapNeedsHostUboBytes is 0 for the whole of P5 (table 0), so the second
|
||||
// tail is always absent here, and this pass is what says so out loud if it ever is
|
||||
// not. A span that was going to be refused must be refused BEFORE the applier has
|
||||
// stored the window it rides with.
|
||||
if (layout.TailCount == 2 && layout.TailBytes[1] != 0) {
|
||||
const auto* spans = reinterpret_cast<const MGHostSpan*>(tailAt(1));
|
||||
const Uint64 count = layout.TailBytes[1] / sizeof(MGHostSpan);
|
||||
@@ -1853,11 +1865,16 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
CheckHostSpanIsHonest(span, *m_segments);
|
||||
}
|
||||
}
|
||||
return false;
|
||||
MGPipeApplySetShaderBuffers(*static_cast<const MGPShaderBuffers*>(payload),
|
||||
reinterpret_cast<const MGPBufferRange*>(tailAt(0)));
|
||||
return true;
|
||||
}
|
||||
|
||||
case MGPWireOp::SetStreamOutputTargets:
|
||||
// Same as above: no applier, off the reduced path, both tails validated.
|
||||
// No applier entry point, off the reduced path, both tails validated. UNLIKE
|
||||
// set_shader_buffers above this row stays unemitted for the whole of P5e (§5.7):
|
||||
// XFB is lockstep, its capture points are span-scoped state latched at Begin, and
|
||||
// the payload carries a Generation that no applier state has a home for.
|
||||
return false;
|
||||
|
||||
case MGPWireOp::SetProgramBindings: {
|
||||
|
||||
Reference in New Issue
Block a user