From 30d4964a5e3a6ab515c8c96c372778652a19d4ab Mon Sep 17 00:00:00 2001 From: BZLZHH Date: Fri, 3 Oct 2025 12:25:36 +0800 Subject: [PATCH] [Improvement] (MG_State/RenderState): Remove redundant cullFaceEnabled setter/getter. --- MobileGL/MG_State/GLState/Core.cpp | 8 -------- MobileGL/MG_State/GLState/Core.h | 2 -- MobileGL/MG_State/GLState/RenderState/RenderState.cpp | 10 ++-------- MobileGL/MG_State/GLState/RenderState/RenderState.h | 2 -- 4 files changed, 2 insertions(+), 20 deletions(-) diff --git a/MobileGL/MG_State/GLState/Core.cpp b/MobileGL/MG_State/GLState/Core.cpp index 3cf82ed3..460ae78f 100644 --- a/MobileGL/MG_State/GLState/Core.cpp +++ b/MobileGL/MG_State/GLState/Core.cpp @@ -281,14 +281,6 @@ namespace MobileGL { return m_renderState.GetCullFaceMode(); } - void GLContext::SetCullFaceEnabled(Bool enabled) { - m_renderState.SetCullFaceEnabled(enabled); - } - - Bool GLContext::IsCullFaceEnabled() const { - return m_renderState.IsCullFaceEnabled(); - } - // Framebuffer Vector GLContext::GenFramebufferNames(Uint number) { return m_framebufferState.GenerateNames(number); diff --git a/MobileGL/MG_State/GLState/Core.h b/MobileGL/MG_State/GLState/Core.h index b526686d..9405dbcf 100644 --- a/MobileGL/MG_State/GLState/Core.h +++ b/MobileGL/MG_State/GLState/Core.h @@ -90,8 +90,6 @@ namespace MobileGL { Int GetPixelStoreParam(PixelStoreParam param) const; void SetCullFaceMode(CullFaceMode mode); CullFaceMode GetCullFaceMode() const; - void SetCullFaceEnabled(Bool enabled); - Bool IsCullFaceEnabled() const; // Framebuffer Vector GenFramebufferNames(Uint number); diff --git a/MobileGL/MG_State/GLState/RenderState/RenderState.cpp b/MobileGL/MG_State/GLState/RenderState/RenderState.cpp index 84087ec5..7c51da2d 100644 --- a/MobileGL/MG_State/GLState/RenderState/RenderState.cpp +++ b/MobileGL/MG_State/GLState/RenderState/RenderState.cpp @@ -50,6 +50,8 @@ namespace MobileGL { return m_blendEnabled; case CapabilityInput::DepthTest: return m_depthTestEnabled; + case CapabilityInput::CullFace: + return m_cullFaceEnabled; default: return false; } @@ -132,14 +134,6 @@ namespace MobileGL { CullFaceMode RenderState::GetCullFaceMode() const { return m_cullFaceMode; } - - void RenderState::SetCullFaceEnabled(Bool enabled) { - m_cullFaceEnabled = enabled; - } - - Bool RenderState::IsCullFaceEnabled() const { - return m_cullFaceEnabled; - } } // namespace GLState } // namespace MG_State } // namespace MobileGL diff --git a/MobileGL/MG_State/GLState/RenderState/RenderState.h b/MobileGL/MG_State/GLState/RenderState/RenderState.h index d250067d..90f7a51f 100644 --- a/MobileGL/MG_State/GLState/RenderState/RenderState.h +++ b/MobileGL/MG_State/GLState/RenderState/RenderState.h @@ -150,8 +150,6 @@ namespace MobileGL { // Cull Face void SetCullFaceMode(CullFaceMode mode); CullFaceMode GetCullFaceMode() const; - void SetCullFaceEnabled(Bool enabled); - Bool IsCullFaceEnabled() const; private: // Rasterization