swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-11-11 12:03:24 +09:00
Code Issues Packages Projects Releases Wiki Activity

[MG_Remote, MG_Test] (Disaggregated): P5f fs - keep applier diagnostics within each role

Browse Source
This commit is contained in:
swung0x48
2026-09-19 23:49:45 -04:00
parent b420504279
commit 35ad51d8f7
3 changed files with 52 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Remote/Client/ClientSession.cpp
+14 -4
View File
@@ -19,6 +19,7 @@
#include "WireTables.h"
#include <MGGitHash.h>
#include <MG_Backend/MGPipe/PipeInputs.h>
#include <MG_Impl/GLImpl/Framebuffer/GL_Framebuffer.h>
#include <MG_Impl/Pipe/ResourceTracker.h>
#include <MG_Pipe/MGPipeCallbacks.h>
@@ -116,6 +117,10 @@ namespace MobileGL::MG_Remote::Client {
// thread inside the applier" - see ClientSession::InBarrierWait's note.
thread_local Bool g_inBarrierWait = false;
std::atomic<Bool> g_applyThreadInsideApplier{false};
// A split client cannot observe a server's process-local diagnostic. The
// role-local value remains useful to the applier itself; ordering between
// roles is carried by the ring watermarks, not by this instrumentation.
thread_local Bool g_roleInsideApplier = false;
struct BarrierWaitScope {
BarrierWaitScope() { g_inBarrierWait = true; }
@@ -1280,10 +1285,11 @@ namespace MobileGL::MG_Remote::Client {
// THE CLIENT'S FLAG IS THREAD-LOCAL AND THE SERVER'S IS NOT, and the asymmetry is the
// point: "am I inside a barrier wait" is a question about the calling thread, while "is the
// apply thread inside the applier" is a question the GL thread asks about a DIFFERENT
// thread - so the second has to be a shared atomic and the first must not be, or a second
// GL thread would see the first one's wait as its own.
// thread in the shared-block control. Under role split each thread instead observes only
// its own diagnostic; the client writes a different block and waits through appliedSeq.
Bool ClientSession::InBarrierWait() { return g_inBarrierWait; }
Bool ClientSession::ApplyThreadIsInsideApplier() {
if (MG_Pipe::MGPipeRoleSplitActive()) return g_roleInsideApplier;
return g_applyThreadInsideApplier.load(std::memory_order_acquire);
}
@@ -1379,10 +1385,14 @@ namespace MobileGL::MG_Remote::Client {
std::abort();
}
void ClientSession::NoteApplyThreadEnteredApplier() {
g_applyThreadInsideApplier.store(true, std::memory_order_release);
g_roleInsideApplier = true;
if (!MG_Pipe::MGPipeRoleSplitActive())
g_applyThreadInsideApplier.store(true, std::memory_order_release);
}
void ClientSession::NoteApplyThreadLeftApplier() {
g_applyThreadInsideApplier.store(false, std::memory_order_release);
g_roleInsideApplier = false;
if (!MG_Pipe::MGPipeRoleSplitActive())
g_applyThreadInsideApplier.store(false, std::memory_order_release);
}
Uint32 ClientSession::PumpControlPlane() {