From 4196f0e90252e1f94d51f12fdcf24cffeb9d38e9 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 22 Sep 2026 20:43:39 -0400 Subject: [PATCH] [MG_Backend] (P7): the image-flags decline's comment says it was one of five Shape* exits with no shipped line, not the one Fable review of the B3 rework, nit: the comment over the ShapeImageFlags- Unsupported site called it "the one Shape* exit that left no line on the builds that ship". At 0d425499 SyncWireTextureShape had five such exits: ViewOf (bare return false), NoLevels (bare return false), preserve-flush (bare return false), image flags (MGLOG_D, compiled away in Release) and preserve-copy (bare return false). The comment now names all five. Comment-only, inside the disaggregated-only SyncWireTextureShape; pull build unaffected. --- .../MG_Backend/DirectVulkan/Renderer/VkTextureManager.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/MobileGL/MG_Backend/DirectVulkan/Renderer/VkTextureManager.cpp b/MobileGL/MG_Backend/DirectVulkan/Renderer/VkTextureManager.cpp index 2c0e73f7..a1261718 100644 --- a/MobileGL/MG_Backend/DirectVulkan/Renderer/VkTextureManager.cpp +++ b/MobileGL/MG_Backend/DirectVulkan/Renderer/VkTextureManager.cpp @@ -2315,8 +2315,9 @@ namespace MobileGL::MG_Backend::DirectVulkan { } if (imageFormatResult != VK_SUCCESS || (isMultisample && (imageFormatProperties.sampleCounts & resolvedSampleCount) == 0)) { - // Was an MGLOG_D, which a Release build compiles away: the one Shape* exit that - // left no line on the builds that ship. + // Was an MGLOG_D, which a Release build compiles away, so on the builds that ship + // this exit left no line - one of five Shape* exits that did (with ViewOf, + // NoLevels, preserve-flush and preserve-copy) before B3's review round. MGL_WIRE_DECLINE_AT(ShapeImageFlagsUnsupported, "texture {slot=%u, gen=%u}: image flags=0x%x sampleCount=%d are unsupported " "by the device",