mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-19 16:01:57 +09:00
[Feat] (Metrics, Config): make the boundary-counter summary cadence a knob, because the device harness never reaches the teardown dump
- MOBILEGL_PIPE_STATS_PERIOD (default 120, clamped to [1, 1000000]) sets the frames per summary line; Init() latches it and a zero falls back to the default - the trace APK's replay never tears MobileGL down, so MOBILEGL_PIPE_STATS_FILE never fires on device and a fixture shorter than the period (create-indirect) reported nothing - PipeStatsTest pins the latch and the zero fallback
This commit is contained in:
@@ -130,6 +130,8 @@ namespace MobileGL::MG_Util::PipeStats {
|
||||
Uint64 g_windowBaseFrames = 0;
|
||||
Bool g_shutdownDone = false;
|
||||
|
||||
// Frames per summary line, latched by Init() from MOBILEGL_PIPE_STATS_PERIOD.
|
||||
Uint64 g_summaryPeriod = kDefaultSummaryFramePeriod;
|
||||
inline void Bump(Counter& counter, Uint64 amount) {
|
||||
counter.fetch_add(amount, std::memory_order_relaxed);
|
||||
}
|
||||
@@ -253,14 +255,19 @@ namespace MobileGL::MG_Util::PipeStats {
|
||||
ResetCounters();
|
||||
g_shutdownDone = false;
|
||||
g_pipeStatsEnabled = MG_Config::Features.PipeStats;
|
||||
g_summaryPeriod = MG_Config::Features.PipeStatsPeriod == 0
|
||||
? kDefaultSummaryFramePeriod
|
||||
: static_cast<Uint64>(MG_Config::Features.PipeStatsPeriod);
|
||||
if (g_pipeStatsEnabled) {
|
||||
MGLOG_I("MGPipe stats: counters ON (MOBILEGL_PIPE_STATS), summary every %llu frames%s%s",
|
||||
static_cast<unsigned long long>(kSummaryFramePeriod),
|
||||
static_cast<unsigned long long>(g_summaryPeriod),
|
||||
MG_Config::Features.PipeStatsFile.empty() ? "" : ", JSON dump to ",
|
||||
MG_Config::Features.PipeStatsFile.c_str());
|
||||
}
|
||||
}
|
||||
|
||||
Uint64 SummaryFramePeriod() { return g_summaryPeriod; }
|
||||
|
||||
void Shutdown() {
|
||||
if (!g_pipeStatsEnabled || g_shutdownDone) {
|
||||
return;
|
||||
@@ -336,7 +343,7 @@ namespace MobileGL::MG_Util::PipeStats {
|
||||
#endif
|
||||
}
|
||||
const Uint64 frames = g_frameCount.fetch_add(1, std::memory_order_relaxed) + 1;
|
||||
if (frames % kSummaryFramePeriod == 0) {
|
||||
if (frames % g_summaryPeriod == 0) {
|
||||
EmitSummaryLine();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -129,7 +129,10 @@ namespace MobileGL::MG_Util::PipeStats {
|
||||
inline constexpr Uint32 kPayloadHistogramBuckets = 24;
|
||||
|
||||
// Frames between two summary lines when MOBILEGL_PIPE_STATS=1.
|
||||
inline constexpr Uint64 kSummaryFramePeriod = 120;
|
||||
inline constexpr Uint64 kDefaultSummaryFramePeriod = 120;
|
||||
// The period Init() latched from MOBILEGL_PIPE_STATS_PERIOD (kDefaultSummaryFramePeriod
|
||||
// when unset); never 0.
|
||||
Uint64 SummaryFramePeriod();
|
||||
|
||||
// The latch. Read directly by Enabled() so the off path is a global load and a
|
||||
// predicted branch - do not turn this into a function call.
|
||||
|
||||
Reference in New Issue
Block a user