mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-19 07:51:57 +09:00
[docs, MG_IntegrationTest] (P7): magma-b2.md carries review round 4 - the transport gate loses a conjunct nothing reaches, and the debt lines cite by symbol
- review round 4 nit: the second gate of the flipped multisample resolve case read `!SplitLane::IsSplitLane() && !PeekSplitRuntime().transportResolved`; the marker term is dead - with the marker set and no transport resolved, the fixture's SetUp already skipped through SplitLane::SkipReasonForSplitOnlyAssertions() -> SplitRuntimeSkipReason(), so Ready() is false and the gate is never reached; in every reachable state it equals `!PeekSplitRuntime().transportResolved`, which is what it now says (the SplitLane.h include goes with it), and the comment no longer describes an unreachable branch; behaviour unchanged - monolith entries still Skipped with the same text, the Full entries still Passed - review round 4 nit: magma-b2.md §6 items 1, 2, 3 cited WireFramebuffer.inc by line numbers that round 3 had already moved; they now name the arm inside BlitWireFramebuffers's `blit` lambda and the MGLOG_E_ONCE / RecordTextureCopyError text, and the monolith cross-reference names VulkanRenderer::BlitFramebuffer's vkCmdResolveImage + vkCmdBlitImage instead of pipe line numbers - §2.11 records the round: the should-fix (window primed magenta/0.625, the one-shot wrong-surface demonstration and its readings), the two nits, and a round 4 line under §7 with this tree's readings - test and docs only; no backend source touched (G1 unaffected)
This commit is contained in:
@@ -44,7 +44,6 @@
|
||||
|
||||
#include "../Harness/HeadlessGL.h"
|
||||
#include "../Harness/ScenarioFixture.h"
|
||||
#include "../Harness/SplitLane.h"
|
||||
|
||||
#ifdef GLAPI
|
||||
#undef GLAPI
|
||||
@@ -444,8 +443,12 @@ namespace MGITest {
|
||||
// `DirectVulkan.{Split,Spawn,Tcp}.Full.` census and the `DirectVulkan.VerifySplit.` lane run
|
||||
// inproc/spawn/tcp WITHOUT it on purpose (their CMake blocks say why), and a marker gate
|
||||
// skipped this case there with a message about a monolith that was not running. The marker
|
||||
// is still honoured on its own: a curated lane that asked for split keeps running the case,
|
||||
// and its fixture's arming assertion is what says whether it got what it asked for.
|
||||
// plays no part in this gate at all (review round 4): when it is set and the transport did
|
||||
// not resolve, the fixture's SetUp has already skipped the case through
|
||||
// SplitLane::SkipReasonForSplitOnlyAssertions() -> SplitRuntimeSkipReason() ("MG_Config::
|
||||
// Transport resolved to 'monolith', not to a split transport"), so Ready() is false and this
|
||||
// line is never reached - a `!IsSplitLane() &&` conjunct here could only ever be true, and
|
||||
// round 3's comment described a branch nothing reaches.
|
||||
TEST_F(DepthStencilReadbackMatrixScenario, AFlippedMultisampleResolveMirrorsTheBandsAndAScaleDeclines) {
|
||||
if (!Ready()) return;
|
||||
if (Gl().BackendName() != "DirectVulkan") {
|
||||
@@ -453,7 +456,7 @@ namespace MGITest {
|
||||
"flipped multisample depth resolve writes nothing with no error and a scaled "
|
||||
"one raises no INVALID_OPERATION - a P3b/P4b debt (notes/p7/magma-b2.md §6)";
|
||||
}
|
||||
if (!SplitLane::IsSplitLane() && !PeekSplitRuntime().transportResolved) {
|
||||
if (!PeekSplitRuntime().transportResolved) {
|
||||
GTEST_SKIP() << "the monolith DirectVulkan transport (this process resolved no split "
|
||||
"transport, so BlitFramebuffer takes the monolith arm) refuses a flipped "
|
||||
"depth blit (\"depth blits with flipped rectangles are not supported yet\", "
|
||||
|
||||
Reference in New Issue
Block a user