mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-18 23:43:23 +09:00
[MG_Pipe, MG_Impl, MG_Test, docs] (P7): D-K2's dependency rule in one table, with the case that fails when the two readers disagree
P3b/P4b R-5 (and R-3's cheap half), landing under the P7 program (PLAN-PH-P34B-P7.md
1.2, wave 2-D package D2).
The rule had SIX statements and nothing compared them, and two of the four prose ones
were wrong in the same way: MG_Pipe/MGPipe.h and MG_Backend/DirectGLES/Managers.h both
said "THREE OF THEM HAVE A DEPENDENCY" (there are six rows) and both said "the mirror
pairs (10 without 11, ...) are all fine" - when 10-without-11 is precisely D-K2's FOURTH
row (ID-14/ID-15), refused by the server and withheld by the client, with PipeFill.cpp
saying so out loud: "The brief's original 'bit 10 without 11 is fine' is WITHDRAWN for
P4a as built." Neither wrong comment could fail anything; Managers.h's copy sits in the
header of the file that implements the refusal.
The rows, once, in MG_Pipe/SubsystemDeps.def (X-macro, FatalFamilies.def's convention),
expanded by MGPipe.h into kMGPipeSubsystemDependencies[] / MGPipeSubsystemRequires() /
MGPipeSubsystemDependenciesAreSet() with four static_asserts. Six rows: 8->7, 9->10,
10->{7,11}, 11->10, 12->none (a ROW, not an absence), 13->7. Bits 8 and 13 are the two
the old comment did not know about; bit 13's row lived fifteen lines further down in the
same header, which is how "THREE OF THEM" survived two phases.
THE TWO READERS DO NOT YET READ IT, deliberately: MG_Impl/Pipe/PipeFill.cpp is the
contract package's file for the whole phase (TextureEmit.h states that rule) and
MG_Backend/DirectGLES/Managers.cpp belongs to wave 2-D package D1 while it is in flight.
Switching them is two one-line changes for the integrator. The anti-drift property does
not wait: MG_Test/Backend/DirectGLES/SubsystemDepsTest.cpp is the first thing in the tree
that calls BOTH readers at the same mask - sweeping the phase constants, the two
documented refusal lanes and one mask per row - and compares each against the .def. It
lives in that binary because that binary links both sides.
Both comparisons are one-directional, each for a measured reason. The server resolvers
also fold in the family's own bit and D-C3's wire-caps refusal, so a resolver may say NO
for its own reasons but never YES where the table refuses. MGPipeP4aFamilyEmits is a
QUADRUPLE and the first version of this case asserted equality and reddened at 0x1fff on
the sampler and program families because a bare unit binary registers no consumer - the
assertion being wrong, not the product, and recorded in the note because the temptation
to assert equality here is strong.
Red-once (R-16), twice: dropping the fourth row from the .def fails at COMPILE time
(MGPipe.h's static_asserts); making the server's ResolveSamplerSubsystemArm stop checking
bit 10 (throwaway, reverted) reds the runtime case and names the mask - 0x9ff, which is
exactly the lane CMakeLists.txt already pins for G12.
R-3's cheap half: CONTRACT-P5.md claimed the image-access, sampler-view-target and
draw-buffer encodings as contract by pointing at package-header LINE RANGES, and all
three had drifted (ImageEmit.h:146-159 no longer holds the encoding at all). All three
rows now state the encoding by enumerator and function name, and the two confusable
siblings are named. The remaining half - MGPSamplerView::Target still has no Count bound,
no ...IsValid and no Fatal for an out-of-range value - is stated in the row rather than
closed, being an MG_Pipe change outside this package's footprint.
Managers.h:690-695's copy of the wrong prose is NOT corrected here: it is package D1's
file, and its two defects are named in notes/p34b/espryt-d2.md so the integrator can take
them in one line.
G1 after this change: pull .text 10822147 = 0xa52203, nm --defined-only identical to
~/w7/p7-before/pull-syms.txt (30570 symbols) - the new inline constexpr table does not
reach the pull build.
This commit is contained in:
@@ -195,3 +195,148 @@ probe hits (`MGITEST_PIPE_CLIENT_TEXTURE_UPLOAD_EMITTER_PRESENT=1` is in every l
|
||||
lands"). The `else()` arm is KEPT — it is what makes the arming decision falsifiable in both
|
||||
directions — but it is unreachable on this tree and now says so.
|
||||
* `notes/p4a/p4a-results/gates-v1.md`'s re-run table
|
||||
|
||||
---
|
||||
|
||||
## Slice 3 — the memo purity gate
|
||||
|
||||
`scripts/ci/espryt_memo_purity.py`, a sibling of `link_seam_purity.py`, wired into `test.yml`
|
||||
beside it. Scoped to the BRACES of the families the plan names (`ResolvedTextureBindingMemo`,
|
||||
`SamplerPassMemo`, `UnitSamplerLookupMemo`, `TwinLookupMemo`, `StateBackendObjectRegistry`) plus
|
||||
the image sweep's seven file statics, because these two files pass frontend pointers around
|
||||
legitimately in hundreds of places and a file-wide grep would be a list of exceptions.
|
||||
|
||||
Guard-awareness is a small conditional walker, not a preprocessor: it recognises
|
||||
`#if MOBILEGL_PIPE_LEGACY_MEMOS`, `#if !MOBILEGL_BUILD_DISAGGREGATED` and the `#else` of
|
||||
`#if MOBILEGL_BUILD_DISAGGREGATED`, which is every spelling these files use.
|
||||
|
||||
**Six allow-list entries, each with its reason.** The two that matter:
|
||||
`StateBackendObjectRegistry`'s `UnorderedMap<StateObject*, Entry>` (`Managers.h:330`, and the
|
||||
`m_entries` member behind it) and `ResolvedTextureBindingMemo`'s type-erased `const void* program`
|
||||
are the PULL build's only arms — deleting them moves pull `.text` and fails G1, so they retire
|
||||
with the pull path (P13). The other four are memo VALUES rather than keys.
|
||||
|
||||
**Red-once (R-16)**: 7 negative controls in `--self-test`, 4 positive controls (a
|
||||
`LEGACY_MEMOS` arm, the `#else` of a `DISAGGREGATED` arm, the allow-listed type-erased key, and a
|
||||
frontend pointer outside every memo family) — plus one taken against the real tree: injecting
|
||||
`MG_State::GLState::ProgramObject* regressionKey` into the actual `ResolvedTextureBindingMemo`
|
||||
reddens the gate and names `DirectGLES.cpp:7266`.
|
||||
|
||||
**What the sweep found that is NOT in scope**: seven unguarded frontend-pointer-keyed containers
|
||||
under `MG_Backend/DirectVulkan` (`VkTextureManager`'s five `TextureIdentity`-keyed containers,
|
||||
`VkClearManager`'s two, `VkRenderPassManager`'s two raw `RenderbufferObject*` maps, and
|
||||
`VulkanRenderer::VaoDrawMemo`'s `vaoKey`+`vaoLifetimeId` pair sitting beside the correctly fenced
|
||||
handle key). Magma's key inventory is P7 wave 2's, so the gate does not look there; recorded here
|
||||
so the next pass meets a known list.
|
||||
|
||||
---
|
||||
|
||||
## Slice 4 — R-5 (D-K2's dependency rule in one place) and R-3
|
||||
|
||||
### R-5
|
||||
|
||||
The rule had **six** statements and nothing compared them, and **two of the four prose ones were
|
||||
wrong in the same way**: `MG_Pipe/MGPipe.h:115-125` and `MG_Backend/DirectGLES/Managers.h:690-695`
|
||||
both said "THREE OF THEM HAVE A DEPENDENCY" (there are six rows) and both said "the mirror pairs
|
||||
(10 without 11, ...) are all fine" — when 10-without-11 is precisely D-K2's FOURTH row
|
||||
(ID-14/ID-15), refused by the server and withheld by the client, with `PipeFill.cpp` saying so out
|
||||
loud: "The brief's original 'bit 10 without 11 is fine' is WITHDRAWN for P4a as built." Neither
|
||||
wrong comment could fail anything. `Managers.h`'s copy is in the header of the file that
|
||||
implements the refusal.
|
||||
|
||||
**The rows, once**, in `MG_Pipe/SubsystemDeps.def` (X-macro, `FatalFamilies.def`'s convention),
|
||||
expanded by `MGPipe.h` into `kMGPipeSubsystemDependencies[]` / `MGPipeSubsystemRequires()` /
|
||||
`MGPipeSubsystemDependenciesAreSet()`, with four `static_assert`s over it:
|
||||
|
||||
| family | requires |
|
||||
|---|---|
|
||||
| bit 8 VertexInput | bit 7 |
|
||||
| bit 9 Framebuffer | bit 10 |
|
||||
| bit 10 TextureResources | bit 7 **and bit 11** |
|
||||
| bit 11 Samplers | bit 10 |
|
||||
| bit 12 Programs | — (a ROW, not an absence) |
|
||||
| bit 13 BufferBindings | bit 7 |
|
||||
|
||||
Bits 8 and 13 were the two the old comment did not know about; bit 13's row lived fifteen lines
|
||||
further down in `MGPipe.h`, which is how "THREE OF THEM" survived two phases.
|
||||
|
||||
**The two readers do NOT yet read it, deliberately.** `MG_Impl/Pipe/PipeFill.cpp` is the contract
|
||||
package's file for the whole phase (`TextureEmit.h` states that rule) and
|
||||
`MG_Backend/DirectGLES/Managers.cpp` belongs to package D1 while it is in flight. Switching them
|
||||
is two one-line changes for the integrator. **The anti-drift property does not wait for it**:
|
||||
`MG_Test/Backend/DirectGLES/SubsystemDepsTest.cpp` is the first thing in the tree that calls BOTH
|
||||
readers at the same mask, sweeping the phase constants, the two documented refusal lanes and one
|
||||
mask per row, and compares each against the `.def`. It is in that binary because that binary is
|
||||
the one that links both sides.
|
||||
|
||||
Both comparisons are **one-directional**, and each for a measured reason:
|
||||
|
||||
* the server resolvers also fold in the family's own bit and (for the framebuffer one) D-C3's
|
||||
separate wire-caps refusal, so a resolver may say NO for a reason of its own but may never say
|
||||
YES at a mask the table refuses;
|
||||
* `MGPipeP4aFamilyEmits` is a QUADRUPLE — the operator's bit, the wired constant, a registered
|
||||
consumer, and the dependency rule — and the first version of this case asserted equality and
|
||||
reddened at `0x1fff` on the sampler and program families because a bare unit binary registers no
|
||||
consumer. That was the assertion being wrong, not the product; it is recorded because the
|
||||
temptation to assert equality here is strong and wrong.
|
||||
|
||||
**Red-once (R-16), twice:**
|
||||
|
||||
1. drop D-K2's fourth row from the `.def` → **compile-time** failure, `MGPipe.h:225` and `:230`
|
||||
("D-K2's fourth row (bit 10 requires bit 11) has gone missing again").
|
||||
2. make the SERVER's `ResolveSamplerSubsystemArm` stop checking bit 10 (throwaway patch to
|
||||
`Managers.cpp`, reverted) → `TheServerConsumerGateNeverArmsAFamilyTheTableRefuses` reds and
|
||||
names the mask: "at MOBILEGL_PIPE_PUSH=0x9ff the SERVER's ResolveSamplerSubsystemArm ARMED the
|
||||
handle arm for family 0x800 while MG_Pipe/SubsystemDeps.def says its dependency bits are not
|
||||
all set." `0x9ff` is exactly the lane `CMakeLists.txt` already pins for G12.
|
||||
|
||||
Stale prose corrected in `MGPipe.h` (both blocks), `MG_Impl/Pipe/PipeFill.h` and
|
||||
`MG_Impl/Pipe/TextureEmit.h`. **`MG_Backend/DirectGLES/Managers.h:690-695` is NOT corrected here**
|
||||
— it is package D1's file. Its two defects are named above so the integrator can take them in one
|
||||
line.
|
||||
|
||||
### R-3 (the cheap half)
|
||||
|
||||
`MG_Remote/CONTRACT-P5.md` already claimed the image-access, sampler-view-target and draw-buffer
|
||||
encodings as contract, but did so **by pointing at package-header line ranges, and all three had
|
||||
drifted** — `ImageEmit.h:146-159` no longer holds the encoding at all, `SamplerEmit.h:900` is off
|
||||
by six lines, `FramebufferEmit.h:146-163` by one. That is the exact failure the table's own
|
||||
`MGPSubData::Target` row warns about.
|
||||
|
||||
All three rows now state the encoding **by enumerator and function name** rather than by line, and
|
||||
the two confusable siblings are named out loud: `MGPImageBind::Access` carries the raw GL token
|
||||
(not this encoding), and `SamplerEmit.h`'s `SamplerTarget[]` is a different, biased encoding of the
|
||||
same enum living 200 lines from the wire one.
|
||||
|
||||
**The remaining half of R-3 is stated, not closed**: `MGPSamplerView::Target` has no `Count`
|
||||
bound, no `...IsValid` predicate and no `Fatal{ProtocolCorruption}` for an out-of-range value,
|
||||
unlike `MGPipeResourceTarget`. Giving it the `MGPipeImageAccess` treatment in
|
||||
`MGPipeValueTypes.h` is a `MG_Pipe` change outside this package's declared footprint.
|
||||
|
||||
---
|
||||
|
||||
## Slice 5 — the raw-depth-fetch sampler, step 1 only
|
||||
|
||||
Step 1 done: `ContextEpochTest` gains a case that drives `GetRawDepthFetchSampler()` on BOTH arms
|
||||
in one process and asserts they are two different `BackendSamplerObject`s — the observable form of
|
||||
`DirectGLES.cpp:334-336`'s prose claim that the legacy pair "is not constructed or consulted by
|
||||
the server".
|
||||
|
||||
**Step 2 NOT done, and the package's own condition is why.** Every deletion candidate — the two
|
||||
file-static `SharedPtr`s (`DirectGLES.cpp:82-83`), the monolith arm (`:361-371`),
|
||||
`NeedsRawDepthFetchSampler` (`:393-399`) and the pre-handle sampler-pass branch (`:8015-8024`) —
|
||||
is UNCONDITIONAL code. None sits behind `#if !MOBILEGL_BUILD_DISAGGREGATED`; the pull build
|
||||
(`DISAGGREGATED=OFF`, `PIPE_PUSH=OFF`) compiles and links all of it, and the monolith arm is the
|
||||
ENTIRE body `GetRawDepthFetchSampler` has there. Deleting any of it moves pull `.text` and fails
|
||||
G1's 0/0/0/0 — `ARCHITECTURE.md:340` states that rule for exactly this class of
|
||||
retired-but-compiled code. Filed as **P13**, beside the existing S7 entry in
|
||||
`notes/p5f/f0-statics.md`.
|
||||
|
||||
---
|
||||
|
||||
## Slice 6 — the census
|
||||
|
||||
`notes/p34b/split-scenario-census.md` carries the table. Twelve scenarios newly gating in the
|
||||
three GLES split arms; `ProgramPipelineScenario`'s nine non-storage-block cases deliberately not
|
||||
registered (ScenarioFixture's armed-lane rule); DirectVulkan arms deliberately none, with the
|
||||
tier-2 informational replay named as the reason it is not a coverage hole.
|
||||
|
||||
Reference in New Issue
Block a user