mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-16 06:23:23 +09:00
[MG_IntegrationTest, docs] (P7): the texture upload shape becomes a gate, with the view remap inside the workload
P3b/P4b R-11 / D-D4, landing under the P7 program (PLAN-PH-P34B-P7.md 1.2, wave 2-D
package D2). P4a recorded the emission shape rather than gating it because the
per-storage-owner cursor with view/owner remapping was the next phase's and gating an
unfinished shape pins a non-answer. That work landed, so the RecordProperty block is
now EXPECT_EQ against a gold row MEASURED on this cursor, and the workload carries a
third texture written through a glTextureView so the remap is inside the counted
window.
The gold row, identical on monolith / inproc / spawn / tcp:
emit=9 box=9 rect=0 jobs=9, client emitter 9
keyed on the workload constants by static_assert. P4a's emit=6 box=6 rect=0 jobs=6
was a two-texture workload with no client emitter and is not comparable.
The client half is read from MGPipeTextureEmitter::SubDataCount() rather than from
ctu=, and that is a correction: under spawn and tcp the two roles are two processes
whose PipeStats windows close on different Present cadences (measured ctu=13 against
emit=9, and usually not yet written when the case reads), so ctu == emit is not a
well-posed comparison there. The log field is kept as a record and asserted only
where the transport says the two are window-aligned - asking the NUMBER was the first
mistake, because the server publishes a readable ctu=0 under spawn and the comparison
silently became 0 == 9. PipeStatsWindow gains LastFromClientLog/LastFromServerLog.
Split/spawn/tcp arms added as explicit per-arm blocks rather than through
mgl_itest_register_split_arms: the macro hands every arm the shared environment, and
this case needs a lane marker, PipeStats period 1, a push mask and above all a
MOBILEGL_LOG_FILE_PATH private to the arm - the library opens the log "w", so two
entries sharing a path truncate each other and the failure looks exactly like "the
counter was never emitted".
Red-once (R-16): the prescribed flip of summedArea*4 >= unionArea*3 leaves the gate
GREEN, and that is a finding. Two gates downstream dominate it - the server needs
dirtyRectCount >= 2, and UnpackRingAvailable() zeroes the rect list by design ("one
box, one job", the existing Mali-cliff mitigation). So rect=0 is the policy's
intended output, not an accident of the scatter pattern. The red-once that bites
splits the union box in two AND disables the unpack ring: box=6 rect=3 jobs=12
against the gold, while 26 pixel cases stay green. Four attempts and their reasons
are in the note.
The Mali frame-time delta D-D4 asks for beside the gold is NOT schedulable - one
Redmi, an Adreno, no Mali part - and is recorded as a declared deviation in the
scenario header and MEASUREMENTS.md 13.3 rather than modelled.
Also corrects the three places that said the client emitter had not landed: the
scenario header, the CMake probe's comment, and gates-v1.md's re-run table.
TextureEmit.h's EmitOneLevel has been incrementing it.
This commit is contained in:
@@ -772,3 +772,50 @@ P6(spawn transport)的实现包(a6 / c6 / lk / so / sm / cp / hs / dl / st
|
||||
- **门 8① 的两种门铃只在一条负载、一台设备上比过**,且参照注记里的 1600 spins/帧 属于更重的场景;若存在差异,应在每帧会合次数更多的负载上才看得见。
|
||||
- **spawn client 的窗口化字段仍不可信**,而且这一项是**结构**不是缺陷:要让 spawn client 推进窗口,得让 client 进程到达一次 `PipeStats::OnPresent`,而 client 的帧边界在 spawn 下是 `EmitPresent`(每条 present 记录一次)——接上去会与 backend 的帧边界重复计数。**不要顺手接**。
|
||||
- **`MOBILEGL_IPC_STAGE_MB` 同时是 arena 大小与 chunk 预算的来源**,所以分块的净效果没有被单变量隔离(§12.5 的 `tex` +194%)。
|
||||
|
||||
## 13. P3b/P4b wave 2-D 包 D2(`7ed5da52`,WSL 桌面 lavapipe/llvmpipe)
|
||||
|
||||
### 13.1 上传形状金标(R-11 / D-D4,`TextureUploadShapeScenario` 由记录升为门)
|
||||
|
||||
工作负载常量 `kScatteredRects=40`、`kFrames=3`、一条连续带、**三张**纹理(第三张经
|
||||
`glTextureView` 的 level 1 上传,使 view/属主重映射落在被计数的窗口内)。
|
||||
|
||||
| 臂 | emit | box | rect | jobs | client emitter |
|
||||
|---|---|---|---|---|---|
|
||||
| `DirectGLES.TextureUploadShape.`(monolith) | 9 | 9 | 0 | 9 | 9 |
|
||||
| `DirectGLES.Split.`(inproc) | 9 | 9 | 0 | 9 | 9 |
|
||||
| `DirectGLES.Spawn.` | 9 | 9 | 0 | 9 | 9 |
|
||||
| `DirectGLES.Tcp.` | 9 | 9 | 0 | 9 | 9 |
|
||||
|
||||
P4a 的记录是两张纹理、无 client emitter 的 `emit=6 box=6 rect=0 jobs=6`(`ctu=0`),与本行
|
||||
**不可比**:工作负载不同。
|
||||
|
||||
`rect=0` 不是散点图案的偶然,而是 unpack-ring 策略的既定输出:`Managers.cpp:8652` 在
|
||||
`UnpackRingAvailable()` 时把 `dirtyRectCount` 清零("One box, one job",即 Mali 悬崖的既有缓解),
|
||||
`:8764` 的 `rectShape` 还要求 `dirtyRectCount >= 2`。因此**客户端任何谓词翻转都动不了这四个数**
|
||||
——翻转 `summedArea*4 >= unionArea*3` 全绿,见 `notes/p34b/espryt-d2.md` 的四次尝试。红一次由
|
||||
"把 union box 切成两半 + `MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1`"做到:`box=6 rect=3 jobs=12`,
|
||||
而 26 个像素用例全绿。
|
||||
|
||||
### 13.2 client 半边的读法(本包的修正)
|
||||
|
||||
`ctu=` 与 `tex[]` 是否在同一个窗口里,按传输分:
|
||||
|
||||
| 臂 | `tex[]` 在哪 | `ctu=` 在哪 |
|
||||
|---|---|---|
|
||||
| monolith | 唯一日志 | 同一行 |
|
||||
| inproc | **server** 日志(两个文件、一个进程、一套计数器) | 同一行 |
|
||||
| spawn / tcp | **server** 日志 | client 进程自己的计数器,**Present 节奏不同**——实测 `ctu=13` 对 `emit=9`,且用例读取时通常还没写出 |
|
||||
|
||||
这与 §12.7 最后一条"spawn client 的窗口化字段仍不可信(是结构不是缺陷)"是同一件事,从集成用例
|
||||
这一侧再次证实。因此断言改读**进程内的 `MGPipeTextureEmitter::SubDataCount()`**(同一个计数器的源
|
||||
头,测试进程在四个臂下都是 client),`ctu=` 只在窗口对齐时断言;是否对齐由
|
||||
`PeekSplitRuntime()` 回答的传输决定,**不是**由数值是否 >= 0 决定——spawn 下 server 会发布一个
|
||||
完全可读的 `ctu=0`,按数值判会把比较悄悄变成 `0 == 9`。
|
||||
|
||||
### 13.3 未跑项 / 不可调度项
|
||||
|
||||
- **Mali 帧时增量(D-D4 要求与金标并列)不可调度。** 本阶段只有一台 Redmi(Adreno 830v2),
|
||||
**无任何 Mali 设备**。按 Adreno 记录形状,偏差在此与场景头部注明:**Adreno-only; Mali delta
|
||||
deferred**。不建模、不从 2026 年那次测量的条件推算。形状是悬崖的**因**,帧时是它在某一家硬件
|
||||
上的**果**——门守的是因。
|
||||
|
||||
@@ -98,3 +98,100 @@ from `os.environ` and strips only the transport keys). A feature knob that reach
|
||||
three is the worst of the three states: the lane is green and tests nothing.
|
||||
|
||||
---
|
||||
|
||||
## Slice 2 — `TextureUploadShapeScenario` promoted from record to gate (R-11 / D-D4)
|
||||
|
||||
`RecordProperty` → `EXPECT_EQ` against a gold row measured on this cursor, plus a third texture
|
||||
uploaded through a `glTextureView` so the view/owner remap is inside the counted workload.
|
||||
|
||||
### The gold row
|
||||
|
||||
Workload constants `kScatteredRects=40`, `kFrames=3`, one contiguous band, three textures.
|
||||
|
||||
| | emit | box | rect | jobs | client emitter |
|
||||
|---|---|---|---|---|---|
|
||||
| **gold (this cursor)** | **9** | **9** | **0** | **9** | **9** |
|
||||
| P4a's record (two textures, no client emitter) | 6 | 6 | 0 | 6 | ctu=0 |
|
||||
|
||||
Identical on all four arms — `DirectGLES.TextureUploadShape.` (monolith), `.Split.`, `.Spawn.`,
|
||||
`.Tcp.`.
|
||||
|
||||
### The client half is read from the emitter, not from `ctu=`
|
||||
|
||||
Measured, and it is a correction rather than a preference:
|
||||
|
||||
| arm | where `tex[]` is | where `ctu=` is |
|
||||
|---|---|---|
|
||||
| monolith | the one log | same line |
|
||||
| inproc | the SERVER's log (two files, one process, one counter set) | same line |
|
||||
| spawn / tcp | the SERVER's log | the CLIENT process's own counters, on a **different Present cadence** — measured `ctu=13` against `emit=9`, and usually not yet written at all when the case reads |
|
||||
|
||||
So `ctu == emit` is not a well-posed comparison under spawn/tcp from the summary lines. The log
|
||||
field is kept as a RECORD and asserted only where the two are window-aligned (decided by asking
|
||||
`PeekSplitRuntime()` which transport resolved — **not** by testing whether the number is >= 0,
|
||||
which was this case's first mistake: the server publishes a perfectly readable `ctu=0` under
|
||||
spawn and the comparison silently became `0 == 9`). The ASSERTION reads
|
||||
`MGPipeTextureEmitter::SubDataCount()` in-process, which is the same counter's source and is the
|
||||
client's true count in every arm, because the test process is the client under all four.
|
||||
|
||||
`Harness/PipeStatsWindow.h` gains `LastFromClientLog()` / `LastFromServerLog()` for this.
|
||||
|
||||
### Red-once (R-16)
|
||||
|
||||
**The prescribed flip does not reach this workload, and that is a finding.** Flipping
|
||||
`summedArea * 4 >= unionArea * 3` in `MipmapStorage::GetDirtyRects` leaves the gate GREEN. Four
|
||||
attempts, in order, all green:
|
||||
|
||||
1. flip `summedArea*4 >= unionArea*3` → green
|
||||
2. `rects.size() < 2` → `rects.empty()` → green
|
||||
3. remove the union-box re-seed in `MarkDirtyRegion` → green
|
||||
4. `MOBILEGL_ESPRYT_DISABLE_UNPACK_RING=1` alone → green
|
||||
|
||||
The reason is two gates downstream of the predicate, either of which alone forces the box arm:
|
||||
|
||||
* `Managers.cpp:8764` `rectShape = subRectEligible && dirtyRectCount >= 2` — the SERVER needs at
|
||||
least two rects, and the client's list collapses to one for this workload; and
|
||||
* `Managers.cpp:8652` `if (BufferImpl::UnpackRingAvailable()) dirtyRectCount = 0;` — **by design**:
|
||||
"through the unpack ring every glTexSubImage is a GPU copy job (Mali), so ~100 sprite rects
|
||||
become ~100 jobs whose fixed cost dwarfs the union box's extra bytes… One box, one job."
|
||||
|
||||
So `box=9 rect=0` is not an accident of the scatter pattern: it is the unpack-ring policy's
|
||||
intended output, and no client-side predicate can move it while the ring is available. The gold
|
||||
row pins the policy's output, which is the right thing to pin.
|
||||
|
||||
The red-once that DOES bite makes `GetDirtyRects` hand back the union box cut in two AND disables
|
||||
the unpack ring:
|
||||
|
||||
```
|
||||
DirectGLES.TextureUploadShape. ... FAILED
|
||||
the BOX/RECT split moved: 6 box emissions against a gold of 9
|
||||
the BOX/RECT split moved: 3 rect-list emissions against a gold of 0
|
||||
the JOB count moved: 12 against a gold of 9
|
||||
tex[emit=9 box=6 rect=3 jobs=12]
|
||||
```
|
||||
|
||||
and all 26 pixel cases of `TextureView` / `TextureViewAlias` / `SampledSetStaleness` /
|
||||
`ImageSizeAfterRespec` / `CopyImageLevelRange` / `ClearThenReadPixels` stay GREEN under the same
|
||||
patch — the required property, and the point of the gate: SSIM and every pixel assertion are blind
|
||||
to a shape that inverted.
|
||||
|
||||
### The Mali frame-time delta is NOT published
|
||||
|
||||
D-D4 asks for the +6 ms/frame reading beside the gold. **Not schedulable**: this phase has one
|
||||
device, a Redmi with an Adreno, and no Mali part. Recorded as a declared deviation in the scenario
|
||||
header and in `docs/Disaggregated/MEASUREMENTS.md` as "Adreno-only; Mali delta deferred" rather
|
||||
than modelled or copied from the 2026 measurement's conditions. What the gate pins is the SHAPE,
|
||||
on the reasoning that the shape is the cliff's cause and the frame time is its consequence on one
|
||||
vendor's hardware.
|
||||
|
||||
### Stale prose corrected
|
||||
|
||||
All three said the client emitter had not landed. `MG_Impl/Pipe/TextureEmit.h`'s `EmitOneLevel`
|
||||
increments `CallClass::ClientTextureUploadEmissions` on every piece it emits, and the build's own
|
||||
probe hits (`MGITEST_PIPE_CLIENT_TEXTURE_UPLOAD_EMITTER_PRESENT=1` is in every lane's environment).
|
||||
|
||||
* `Scenarios/TextureUploadShapeScenario.cpp` header and the client-half comment block
|
||||
* `MG_IntegrationTest/CMakeLists.txt`, the probe's comment ("Once package B's texture emitter
|
||||
lands"). The `else()` arm is KEPT — it is what makes the arming decision falsifiable in both
|
||||
directions — but it is unreachable on this tree and now says so.
|
||||
* `notes/p4a/p4a-results/gates-v1.md`'s re-run table
|
||||
|
||||
@@ -446,7 +446,7 @@ run against the finished code):
|
||||
|---|---|
|
||||
| `ctest --test-dir build-verify -R 'HandleRecycle'` | the six ABA cases' `Handles` arm and the seven leak cases **arm themselves** when D and E land. The leak cases are the phase's only defence against P3a's C-1 shape, on both backends |
|
||||
| `ctest --test-dir build-push -R 'ObjectSubsystemControl'` and `MOBILEGL_PIPE_PUSH=0x9ff ctest -R 'ObjectSubsystemControl'` | both cases SKIP today; the On/Off A/B arms when B and C land, the refusal when D lands. The refusal lane already pins `0x9ff` itself, so D.3's separate `0x9ff` invocation is a second reading of the same thing rather than the only one |
|
||||
| `ctest --test-dir build-push -R 'TextureUploadShape'` | the client half (`ctu=`) is zero today; once B lands, the `ctu == emit` assertion is live and is the client/server shape comparison D-L exists for. **Record the new numbers** — the P4a baseline is `emit=6 box=6 rect=0 jobs=6` |
|
||||
| `ctest --test-dir build-push -R 'TextureUploadShape'` | ~~the client half (`ctu=`) is zero today; once B lands, the `ctu == emit` assertion is live~~ **DONE, P3b/P4b wave 2-D (R-11).** The client emitter landed (`MG_Impl/Pipe/TextureEmit.h`'s `EmitOneLevel`), the `ctu == emit` comparison is live, and the scenario is now a GATE against a gold row rather than a record. The workload gained a third texture written through a `glTextureView`, so the numbers are not comparable to the P4a baseline `emit=6 box=6 rect=0 jobs=6`: the row measured on `7ed5da52` is **`emit=9 box=9 rect=0 jobs=9`, client emitter 9**, identical on monolith / inproc / spawn / tcp. See `notes/p34b/espryt-d2.md` |
|
||||
| `bash scripts/p4a_descriptor_negative_control.sh build-push` | exits 2 today because both emit headers are the contract's stubs. It becomes a real G7 control the moment B and C fill them in, and it is **not** a CI lane (it rebuilds the library up to four times) |
|
||||
| `bash scripts/p4a_untouched_regions.sh 37da3c3a HEAD` | this is the gate D and E can break. It is rc 0 here because nothing on the list has been touched yet |
|
||||
| `ctest --test-dir build-push -R 'TextureParamsWithoutASamplerView'` | green here; after `esprytobj` it is the regression net that says the parameter sync did not move onto the sampler view |
|
||||
|
||||
Reference in New Issue
Block a user