From 701e93f26d8e50eafc58d965adbea2c25e4344a1 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Mon, 25 Aug 2025 17:34:53 +0800 Subject: [PATCH 1/2] [Fix] (buildsystem): add /EHsc for msvc --- CMakeLists.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7a684afa..0ecc1352 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -12,6 +12,10 @@ set(CMAKE_EXPORT_COMPILE_COMMANDS ON) set(CMAKE_POSITION_INDEPENDENT_CODE ON) +if (MSVC) + set(CMAKE_CXX_FLAGS "/EHsc ${CMAKE_CXX_FLAGS}") +endif() + set(SPIRV_CROSS_STATIC ON CACHE BOOL "Build SPIRV-Cross as static library") set(SPIRV_CROSS_CLI OFF CACHE BOOL "Build SPIRV-Cross command line tool") @@ -134,6 +138,15 @@ target_link_libraries(${CMAKE_PROJECT_NAME}_s spirv-cross-c ) +if (ANDROID) + target_link_libraries(${CMAKE_PROJECT_NAME} PUBLIC + android + log + ) + target_link_libraries(${CMAKE_PROJECT_NAME}_s PUBLIC + android + log) +endif() set(BUILD_TEST ON CACHE BOOL "Build the tests") set(BUILD_BENCHMARK ON CACHE BOOL "Build the benchmarks") From 445f55af925e26bcb4813db9a2b55994fb04aaaf Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Mon, 25 Aug 2025 20:08:42 +0800 Subject: [PATCH 2/2] [Fix]: guard against dlsym --- MobileGL/MG_Impl/EGLImpl/Temporary/TemporaryEGLImpl.cpp | 2 +- MobileGL/MG_Impl/GLXImpl/LookUp/LookUp.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MobileGL/MG_Impl/EGLImpl/Temporary/TemporaryEGLImpl.cpp b/MobileGL/MG_Impl/EGLImpl/Temporary/TemporaryEGLImpl.cpp index 28f9444e..b53a80c0 100644 --- a/MobileGL/MG_Impl/EGLImpl/Temporary/TemporaryEGLImpl.cpp +++ b/MobileGL/MG_Impl/EGLImpl/Temporary/TemporaryEGLImpl.cpp @@ -102,7 +102,7 @@ namespace MobileGL { __eglMustCastToProperFunctionPointerType GetProcAddress(const char* name) { MGLOG_D("eglGetProcAddress(%s)", name); -#ifndef WIN32 +#if !defined(WIN32) && !defined(__APPLE__) void* proc = dlsym(RTLD_DEFAULT, (const char*)name); #else void* proc = NULL; diff --git a/MobileGL/MG_Impl/GLXImpl/LookUp/LookUp.cpp b/MobileGL/MG_Impl/GLXImpl/LookUp/LookUp.cpp index a09a111b..48145548 100644 --- a/MobileGL/MG_Impl/GLXImpl/LookUp/LookUp.cpp +++ b/MobileGL/MG_Impl/GLXImpl/LookUp/LookUp.cpp @@ -5,7 +5,7 @@ namespace MG_Impl::GLXImpl { void* GetProcAddress(const char* name) { MGLOG_D("glXGetProcAddress(\"%s\")", name); -#ifndef WIN32 +#if !defined(WIN32) && !defined(__APPLE__) void* proc = dlsym(RTLD_DEFAULT, (const char*)name); #else void* proc = NULL;