From 5c9ad5b499094b069f5fc7cd7db958ce4204c3c8 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 29 Sep 2026 12:16:55 -0400 Subject: [PATCH] [Test] (P11 M2): RemoteGuards pins GetStorageDirtyFootprint on the apply thread as Fatal{RoleViolation, "texture-legacy-arm"}, beside the rest of the dirty model's rows --- MobileGL/MG_Test/Wire/RemoteClientTest.cpp | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MobileGL/MG_Test/Wire/RemoteClientTest.cpp b/MobileGL/MG_Test/Wire/RemoteClientTest.cpp index 987c67d3..2880bad1 100644 --- a/MobileGL/MG_Test/Wire/RemoteClientTest.cpp +++ b/MobileGL/MG_Test/Wire/RemoteClientTest.cpp @@ -2582,7 +2582,7 @@ TEST(RemoteGuards, CapsMirrorFallbackWithNoServerBackendIsFatalByName) { // // AllocateStorage, TruncateMipmapLevels, UpdateMipmapSubData, MapMipmapData, // MarkStorageDirty, MarkStorageDirtyRegion, IsStorageDirty, GetStorageDirtyRegion, -// GetStorageDirtyRects +// GetStorageDirtyRects, GetStorageDirtyFootprint (P11 M2) // // P5e (tx2): THE SHAPE READS JOIN THE LIST, and the sentence that stood here is why they could // not before - "the per-draw binding walk reads them every draw". P5e is the commit that makes @@ -2638,6 +2638,13 @@ MGL_TEXTURE_GUARD_TEST(TextureGetStorageDirtyRegionFromTheApplyThreadIsFatalByNa MGL_TEXTURE_GUARD_TEST(TextureGetStorageDirtyRectsFromTheApplyThreadIsFatalByName, 719, (void)texture.GetStorageDirtyRects(TextureUploadTarget::Texture2D, 0, nullptr, 0)) +// P11 M2: dev 9524c688's exact dirty footprint joins the dirty model's rows. The server's +// footprint is the record's region list (Managers.cpp's handle arm), never this accessor. +MGL_TEXTURE_GUARD_TEST(TextureGetStorageDirtyFootprintFromTheApplyThreadIsFatalByName, 720, + ([&texture] { + Vector footprint; + texture.GetStorageDirtyFootprint(TextureUploadTarget::Texture2D, 0, footprint); + }())) // ---- P5e (tx2): the seven shape reads the P4a/P5c list exempted ---------------------------- MGL_TEXTURE_GUARD_TEST(TextureGetMipmapLevelCountFromTheApplyThreadIsFatalByName, 721, (void)texture.GetMipmapLevelCount())