swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-09-12 06:08:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] (MG_Backend/DirectVulkan): blendEnable was baked into pipelines without checking VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT; disable blending on formats that lack it

Browse Source
This commit is contained in:
swung0x48
2026-07-17 20:03:53 -04:00
parent 48568cdb89
commit 6b223e4d23
1 changed files with 24 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Backend/DirectVulkan/Renderer/VulkanRenderer.cpp
+24 -11
View File
@@ -3183,17 +3183,30 @@ void main() {
colorAttachmentFormat = textureResource->format; colorAttachmentFormat = textureResource->format;
} }
#if MOBILEGL_LOG_ACTIVE_LEVEL <= MOBILEGL_LOG_LEVEL_DEBUG // Blending on an attachment whose format lacks
VkFormatProperties formatProperties{}; // VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT is invalid pipeline state
vkGetPhysicalDeviceFormatProperties(m_physicalDevice.handle, colorAttachmentFormat, &formatProperties); // (blend support is optional for e.g. 32-bit float formats on some GPUs);
MOBILEGL_ASSERT( // force-disable it instead of baking undefined behavior into the pipeline.
(formatProperties.optimalTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT) != 0, static UnorderedMap<Int, Bool> formatBlendSupport;
"GetOrCreatePipeline: blend is enabled on color attachment %u for format=%d textureId=%d, but the format lacks VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT (program=%u)", auto blendSupportIt = formatBlendSupport.find(static_cast<Int>(colorAttachmentFormat));
i, if (blendSupportIt == formatBlendSupport.end()) {
static_cast<Int>(colorAttachmentFormat), VkFormatProperties formatProperties{};
textureExternalIndex, vkGetPhysicalDeviceFormatProperties(m_physicalDevice.handle, colorAttachmentFormat,
program.GetExternalIndex()); &formatProperties);
#endif const Bool blendable =
(formatProperties.optimalTilingFeatures & VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT) != 0;
blendSupportIt =
formatBlendSupport.emplace(static_cast<Int>(colorAttachmentFormat), blendable).first;
if (!blendable) {
MGLOG_E("GetOrCreatePipeline: format=%d lacks VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT; "
"disabling blending on attachments with this format (first hit: attachment %u textureId=%d program=%u)",
static_cast<Int>(colorAttachmentFormat), i, textureExternalIndex,
program.GetExternalIndex());
}
}
if (!blendSupportIt->second) {
effectiveBlendEnabled = false;
}
} }
// Dual-source blending (GL_SRC1_* factors from glBlendFunc paired with // Dual-source blending (GL_SRC1_* factors from glBlendFunc paired with
// glBindFragDataLocationIndexed) requires the dualSrcBlend device feature. It is detected at // glBindFragDataLocationIndexed) requires the dualSrcBlend device feature. It is detected at