mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-21 00:41:57 +09:00
[Feat] (GL): apply glClipControl on both backends and advertise ARB_clip_control
This commit is contained in:
@@ -1337,6 +1337,52 @@ TEST(TessellationCapabilities, FollowTheVersionOrTheExtension) {
|
||||
EXPECT_TRUE(es32.SupportsTessellationShader);
|
||||
}
|
||||
|
||||
// glClipControl is forwarded only to a driver that both advertises GL_EXT_clip_control and
|
||||
// resolves its entry point.
|
||||
TEST(ClipControlCapabilities, NeedTheExtensionAndTheEntryPoint) {
|
||||
auto withEntryPoint = MakeFakeGLESFunctions();
|
||||
withEntryPoint.glClipControlEXT = [](GLenum, GLenum) {};
|
||||
|
||||
ResetFakeDriver();
|
||||
g_fake.maxVertexSsboBlocks = 0;
|
||||
MobileGL::MG_External::GLESCapabilities noExtension;
|
||||
ASSERT_TRUE(MobileGL::MG_Util::BackendLoader::FillInGLESCapabilities(noExtension, withEntryPoint));
|
||||
EXPECT_FALSE(noExtension.SupportsClipControl);
|
||||
|
||||
ResetFakeDriver();
|
||||
g_fake.maxVertexSsboBlocks = 0;
|
||||
g_fake.extensions.emplace_back("GL_EXT_clip_control");
|
||||
MobileGL::MG_External::GLESCapabilities noEntryPoint;
|
||||
ASSERT_TRUE(MobileGL::MG_Util::BackendLoader::FillInGLESCapabilities(noEntryPoint, MakeFakeGLESFunctions()));
|
||||
EXPECT_FALSE(noEntryPoint.SupportsClipControl);
|
||||
|
||||
ResetFakeDriver();
|
||||
g_fake.maxVertexSsboBlocks = 0;
|
||||
g_fake.extensions.emplace_back("GL_EXT_clip_control");
|
||||
MobileGL::MG_External::GLESCapabilities both;
|
||||
ASSERT_TRUE(MobileGL::MG_Util::BackendLoader::FillInGLESCapabilities(both, withEntryPoint));
|
||||
EXPECT_TRUE(both.SupportsClipControl);
|
||||
}
|
||||
|
||||
// DirectGLES advertises ARB_clip_control on the driver's extension; DirectVulkan always, since it
|
||||
// applies clip control in its own position fixup.
|
||||
TEST(CoreSurfaceAdvertisement, ClipControlFollowsTheBackendsRoute) {
|
||||
const auto contains = [](const MobileGL::Vector<MobileGL::GLExtension>& extensions,
|
||||
MobileGL::GLExtension wanted) {
|
||||
return std::find(extensions.begin(), extensions.end(), wanted) != extensions.end();
|
||||
};
|
||||
EXPECT_FALSE(contains(MobileGL::MG_Backend::DirectGLES::BuildAdvertisedExtensions(false, false, false, false,
|
||||
false, false),
|
||||
MobileGL::E_GL_ARB_clip_control));
|
||||
const MobileGL::MG_Backend::AdvertisedFeatureSupport clipControl{.ClipControl = true};
|
||||
EXPECT_TRUE(contains(MobileGL::MG_Backend::DirectGLES::BuildAdvertisedExtensions(false, false, false, false,
|
||||
false, false, clipControl),
|
||||
MobileGL::E_GL_ARB_clip_control));
|
||||
EXPECT_TRUE(contains(MobileGL::MG_Backend::DirectVulkan::BuildAdvertisedExtensions(false, false, false, false,
|
||||
false),
|
||||
MobileGL::E_GL_ARB_clip_control));
|
||||
}
|
||||
|
||||
// Minecraft 26.3 checks ARB_draw_indirect before it considers the already-advertised
|
||||
// ARB_multi_draw_indirect, then separately requires ARB_base_instance before enabling its terrain
|
||||
// indirect path. Pin both strings and, just as importantly, the non-zero firstInstance gate.
|
||||
|
||||
@@ -111,3 +111,23 @@ void main() {
|
||||
}
|
||||
)");
|
||||
}
|
||||
|
||||
// glClipControl rides on the position fixup's two bits. An upper-left origin toggles the Y flip
|
||||
// (an FBO gains one, the default framebuffer loses its own), a [0, 1] depth mode drops the
|
||||
// depth remap, and nothing else - the rotation and gl_FragCoord bits - moves.
|
||||
TEST(ClipControlTransformFlags, OriginTogglesTheFlipAndDepthModeDropsTheRemap) {
|
||||
using Bit = MG_Backend::DirectVulkan::ProgramFactory::CompileOptionBit;
|
||||
const auto apply = MG_Backend::DirectVulkan::ProgramFactory::ApplyClipControlToTransformFlags;
|
||||
const Uint32 fbo = static_cast<Uint32>(Bit::PositionZRemap);
|
||||
const Uint32 window = static_cast<Uint32>(Bit::PositionZRemap) | static_cast<Uint32>(Bit::PositionYFlip) |
|
||||
static_cast<Uint32>(Bit::FragCoordYFlip) | static_cast<Uint32>(Bit::SurfaceRotate90);
|
||||
|
||||
EXPECT_EQ(apply(fbo, GL_LOWER_LEFT, GL_NEGATIVE_ONE_TO_ONE), fbo);
|
||||
EXPECT_EQ(apply(window, GL_LOWER_LEFT, GL_NEGATIVE_ONE_TO_ONE), window);
|
||||
EXPECT_EQ(apply(fbo, GL_UPPER_LEFT, GL_NEGATIVE_ONE_TO_ONE), fbo | static_cast<Uint32>(Bit::PositionYFlip));
|
||||
EXPECT_EQ(apply(window, GL_UPPER_LEFT, GL_NEGATIVE_ONE_TO_ONE),
|
||||
window & ~static_cast<Uint32>(Bit::PositionYFlip));
|
||||
EXPECT_EQ(apply(fbo, GL_LOWER_LEFT, GL_ZERO_TO_ONE), 0u);
|
||||
EXPECT_EQ(apply(window, GL_UPPER_LEFT, GL_ZERO_TO_ONE),
|
||||
static_cast<Uint32>(Bit::FragCoordYFlip) | static_cast<Uint32>(Bit::SurfaceRotate90));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user