mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-20 00:11:56 +09:00
[Fix] (Magma, MG_IntegrationTest): drop the fourth ABA-control consumer, which was unreachable, and the scenario comment its own body contradicts
- VulkanRenderer::LookupVaoDrawMemo's legacy arm read MG_Config::Features.PipeHandleAbaControl
a fourth time, bypassing the one-question accessor MagmaPipeAbaControlDefeatsIdentity that
55d2af9b's own message says all the control's sites go through. It could never be false
there: the control's early return fires ahead of BOTH arms, so a run that reaches the legacy
compare has the knob off. The compare is unconditional again, with a note saying where the
question is answered and to route through the accessor if that early return is ever narrowed
- which is the trap the dead line was, since narrowing it would have silently restored D18's
retired semantics at this one site.
- HandleRecycleScenario's vertex-array case still said "BOTH the VAO and the buffer are
recycled here so that a key built out of raw addresses matches", which the body has
contradicted since 55d2af9b: both buffers are created before the ABA window and neither is
deleted inside it, deliberately, so that no buffer traffic moves VkBufferManager's
slice-epoch counter inside the window. Only the VAO is recycled, and only its GL name - the
heap block is not handed back, which is why the knob rather than the allocator constructs the
AbaControl arms' collision.
This commit is contained in:
@@ -477,8 +477,12 @@ void main() { oColor = texture(uTex, vUv); }
|
||||
// ------------------------------------------------------------------------------------
|
||||
// 1. The vertex array. This is the case the AbaControl knob targets: DirectVulkan keys
|
||||
// VertexInputStateFactory's cache on the attribute's buffer identity and VaoDrawMemo
|
||||
// on the VAO's, and BOTH the VAO and the buffer are recycled here so that a key built
|
||||
// out of raw addresses matches while the bytes behind it do not.
|
||||
// on the VAO's. Only the VAO is recycled here: both buffers are created before the
|
||||
// window and neither is deleted inside it, because buffer traffic in the window moves
|
||||
// VkBufferManager's slice-epoch counter and that gate is not an identity gate (see
|
||||
// the two MakeQuadBuffer calls). What is recycled is the GL NAME; the heap block is
|
||||
// not handed back, which is why the knob - not the allocator - constructs the
|
||||
// AbaControl arms' collision.
|
||||
// ------------------------------------------------------------------------------------
|
||||
TEST_F(HandleRecycleScenario, AVertexArrayAtARecycledAddressDoesNotInheritItsPredecessorsVertexInput) {
|
||||
if (!Ready()) return;
|
||||
|
||||
Reference in New Issue
Block a user