swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-09-12 14:18:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] (MG_Impl): stop treating an empty buffer mapping access mask as a bad enum

Browse Source 
glMapBufferRange and glMapNamedBufferRange rejected an access of zero with INVALID_ENUM.
Zero is a perfectly well-formed bitfield value - it contains no invalid flags - and what it
violates is the separate rule that a mapping has to ask for read or write access, which GL
reports as INVALID_OPERATION. Both callers already checked that rule immediately after, so
the validator was reporting the wrong error for a case its callers were about to handle
correctly.

direct_state_access.buffers_errors passes, which puts the whole buffers group at 4 of 4 on
both backends.
This commit is contained in:
BZLZHH
2026-08-05 00:13:51 -04:00
parent d96acb7972
commit 764a44f589
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Impl/GLImpl/Buffer/Validators.cpp
+4 -8
View File
@@ -112,14 +112,10 @@ namespace MobileGL::MG_Impl::GLImpl::BufferImpl {
} }
Bool ValidateBufferMappingAccess(Flags<BufferMappingAccessBit> accessBits) { Bool ValidateBufferMappingAccess(Flags<BufferMappingAccessBit> accessBits) {
if (accessBits == BufferMappingAccessBit::Null) { // An empty mask is a legal value for a bitfield - it just fails the rule that a mapping
MG_State::pGLContext->RecordError(ErrorCode::InvalidEnum, // must ask for read or write access, which is INVALID_OPERATION and belongs to the callers
MakeUnique<GenericErrorInfo>("MG_Impl/GLImpl/BufferImpl", // (both of them check it immediately after this). Rejecting it here as INVALID_ENUM
"ValidateBufferMappingAccess", // reported the wrong error and hid theirs.
"Access bits cannot be null."));
return false;
}
const auto validBits = BufferMappingAccessBit::Read | BufferMappingAccessBit::Write | const auto validBits = BufferMappingAccessBit::Read | BufferMappingAccessBit::Write |
BufferMappingAccessBit::InvalidateRange | BufferMappingAccessBit::InvalidateBuffer | BufferMappingAccessBit::InvalidateRange | BufferMappingAccessBit::InvalidateBuffer |
BufferMappingAccessBit::FlushExplicit | BufferMappingAccessBit::Unsynchronized | BufferMappingAccessBit::FlushExplicit | BufferMappingAccessBit::Unsynchronized |