From 781a7446c49610fda844b357085b1f187e0f67c6 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Wed, 7 Oct 2026 19:49:33 -0400 Subject: [PATCH] [CI] (Magma): the run-ahead and cache sync-validation gates turn on submit-time validation, without which a cross-submission hazard is never reported (a broken upload barrier now reds the run-ahead gate). --- scripts/ci/magma_cache_checks.py | 5 +++++ scripts/ci/magma_runahead_checks.py | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/scripts/ci/magma_cache_checks.py b/scripts/ci/magma_cache_checks.py index dc22601f..e90bcd46 100644 --- a/scripts/ci/magma_cache_checks.py +++ b/scripts/ci/magma_cache_checks.py @@ -32,6 +32,11 @@ REQUIRED = {PREFIX + "MagmaWireCacheScenario." + name for name in CASES} SETTINGS = { "VK_INSTANCE_LAYERS": "VK_LAYER_KHRONOS_validation", "VK_LAYER_ENABLES": "VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT", + # Submit-time validation is OFF by default in the layer, and without it a hazard between two + # queue submissions is never reported - measured (P14): a Magma upload barrier with its source + # scope broken stayed green until it was set. The heuristic tracks accesses through descriptors. + "VK_KHRONOS_VALIDATION_SYNCVAL_SUBMIT_TIME_VALIDATION": "true", + "VK_KHRONOS_VALIDATION_SYNCVAL_SHADER_ACCESSES_HEURISTIC": "true", "VK_LOADER_DEBUG": "layer", } REQUIRED_ENV = { diff --git a/scripts/ci/magma_runahead_checks.py b/scripts/ci/magma_runahead_checks.py index 85d98544..3bfa9e39 100644 --- a/scripts/ci/magma_runahead_checks.py +++ b/scripts/ci/magma_runahead_checks.py @@ -202,6 +202,11 @@ def validation(tests, build, out): settings = { "VK_INSTANCE_LAYERS": "VK_LAYER_KHRONOS_validation", "VK_LAYER_ENABLES": "VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT", + # Submit-time validation is OFF by default in the layer, and without it a hazard between two + # queue submissions is never reported - measured (P14): a Magma upload barrier with its source + # scope broken stayed green until it was set. The heuristic tracks accesses through descriptors. + "VK_KHRONOS_VALIDATION_SYNCVAL_SUBMIT_TIME_VALIDATION": "true", + "VK_KHRONOS_VALIDATION_SYNCVAL_SHADER_ACCESSES_HEURISTIC": "true", # Loader diagnostics prove the layer was inserted, rather than merely installed. "VK_LOADER_DEBUG": "layer", }