From 845f699e3fbffd4a68a577d5b5c5d98c1bf5ce16 Mon Sep 17 00:00:00 2001 From: BZLZHH Date: Sat, 15 Nov 2025 21:57:43 +0800 Subject: [PATCH] [Fix] (MG_State/FramebufferState): FramebufferAttachment::IsEmpty should be const. --- .../FramebufferState/FramebufferObject.cpp | 25 +++++++++---------- .../FramebufferState/FramebufferObject.h | 2 +- 2 files changed, 13 insertions(+), 14 deletions(-) diff --git a/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.cpp b/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.cpp index 43a8c7e2..ec95512b 100644 --- a/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.cpp +++ b/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.cpp @@ -21,7 +21,7 @@ namespace MobileGL { return false; } - Bool FramebufferAttachment::IsEmpty() { + Bool FramebufferAttachment::IsEmpty() const { return m_texture == nullptr && m_renderbuffer == nullptr; } @@ -63,8 +63,7 @@ namespace MobileGL { } // FramebufferObject - FramebufferObject::FramebufferObject(Uint externalIndex) : - m_externalIndex(externalIndex) { + FramebufferObject::FramebufferObject(Uint externalIndex) : m_externalIndex(externalIndex) { m_attachments.fill(FramebufferAttachment(false)); m_drawBuffers.fill(FramebufferAttachmentType::None); m_drawBuffers[0] = FramebufferAttachmentType::Color0; @@ -130,21 +129,21 @@ namespace MobileGL { } void FramebufferObject::SetDrawBuffer(Uint index, FramebufferAttachmentType buffer) { - if (m_drawBuffers[index] == buffer) - return; + if (m_drawBuffers[index] == buffer) return; m_drawBuffersDirty = true; m_drawBuffers[index] = buffer; } -// void FramebufferObject::SetDrawBuffers(const Vector& buffers) { -// m_drawBuffers = buffers; -// m_drawBuffersDirty = true; -// } -// void SetDrawBuffer(Uint index, FramebufferAttachmentType buffer) { -// -// } + // void FramebufferObject::SetDrawBuffers(const Vector& buffers) { + // m_drawBuffers = buffers; + // m_drawBuffersDirty = true; + // } + // void SetDrawBuffer(Uint index, FramebufferAttachmentType buffer) { + // + // } - const Array& FramebufferObject::GetDrawBuffers() const { + const Array& FramebufferObject:: + GetDrawBuffers() const { return m_drawBuffers; } diff --git a/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.h b/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.h index bd93f106..b8a91be9 100644 --- a/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.h +++ b/MobileGL/MG_State/GLState/FramebufferState/FramebufferObject.h @@ -72,7 +72,7 @@ namespace MobileGL { Bool IsTexture() const; Bool IsRenderbuffer() const; - Bool IsEmpty(); + Bool IsEmpty() const; SharedPtr GetTexture() const; SharedPtr GetRenderbuffer() const; Int GetTextureLevel() const;