[MG_Remote, MG_Test] (P12 review): a lost server window is answered before every ring record, and a stopping in-process server leaves a streaming client's queue unapplied

- Major: the window-lost release was picked up only between drain batches (PumpControlRequest), and a client streaming frames keeps the command ring from emptying for seconds - surfaceDestroyed waited out its 3 s bound on the UI thread, answered TimedOut, and the session kept presenting into the destroyed window. DrainRing now checks the request after its latch check, before every pop. ServerLoopLatchTest.ALostServerWindowIsReleasedMidBatchWhileTheClientStreams streams a 4 s batch under Detach.
- Stop while streaming: mobilegl_server_stop_inprocess ended the session through loop.Stop(), whose batch and final drain of a ring the client keeps refilling could outlast the bounded join (Fatal{ApplyThreadJoinTimeout} aborts the display Activity's process). RunSession now calls ServerLoop::AbandonQueuedRecords() first when the server is stopping: the drain stops after the record in hand and the exit path declines the rest, as a ReverseChannelForfeit does. ServerLoopTest.StoppingTheServerUnderAStreamingClientLeavesTheQueueAndJoinsPromptly.
This commit is contained in:
2026-09-24 14:03:46 +00:00
parent cb0404f2b9
commit 8f2a084354
4 changed files with 213 additions and 0 deletions
+11
View File
@@ -216,6 +216,15 @@ namespace MobileGL::MG_Remote::Server {
// Kill the doorbell, join the thread (bounded), then destroy the private backend object
// ON THAT THREAD before it exits. Blocking by contract - see the header note.
void Stop();
// P12 review fix: THE NEXT Stop() LEAVES THE QUEUE UNAPPLIED. A Stop() normally lets the
// apply thread finish its batch and drain what is still queued - the client's own drain
// bounds that. A SERVER that is stopping (the in-process display server's
// mobilegl_server_stop_inprocess) has a client that may still be streaming, and a batch plus
// a final drain of a ring that client keeps refilling can outlast the bounded join
// (Fatal{ApplyThreadJoinTimeout} aborts the display Activity's process). Called before Stop():
// the drain stops after the record in hand and the exit path declines the rest, as a
// ReverseChannelForfeit does. Reset by Start().
void AbandonQueuedRecords();
Bool Running() const;
@@ -486,6 +495,8 @@ namespace MobileGL::MG_Remote::Server {
ServerSession* m_session = nullptr;
std::atomic<Bool> m_running{false};
std::atomic<Bool> m_stopRequested{false};
// P12 review fix: AbandonQueuedRecords() - read after every popped record and at the exit.
std::atomic<Bool> m_abandonQueue{false};
std::thread m_thread;
// The apply thread's identity used to live here as an atomic<std::thread::id>. It is
// Detail::g_applyThreadKey now - see the block at the top of this header for why the