From 9bcf0a15a00e5e02a2e82363d09388818b7e8a80 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Sat, 22 Aug 2026 22:03:26 -0400 Subject: [PATCH] [Docs] (DirectGLES, DirectVulkan): correct what advertising cube map arrays actually unlocks --- .../MG_Backend/DirectGLES/BackendObject_DirectGLES.cpp | 9 +++++---- .../DirectVulkan/BackendObject_DirectVulkan.cpp | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/MobileGL/MG_Backend/DirectGLES/BackendObject_DirectGLES.cpp b/MobileGL/MG_Backend/DirectGLES/BackendObject_DirectGLES.cpp index a1e7c356..5b567dd9 100644 --- a/MobileGL/MG_Backend/DirectGLES/BackendObject_DirectGLES.cpp +++ b/MobileGL/MG_Backend/DirectGLES/BackendObject_DirectGLES.cpp @@ -1148,10 +1148,11 @@ namespace MobileGL::MG_Backend::DirectGLES { // and a samplerCubeArray shader does not even compile, which is exactly what the POST // reports. So the string follows the host capability rather than the version. // - // It is worth naming even though cube map arrays are core at the version claimed, because - // KHR-GL4*.texture_gather.plain-gather-*-cube-array checks the STRING and has no - // core-version fallback - five cases per version list sat NotSupported on a device that - // supports the feature. + // Named for the application's benefit rather than the suite's: measured on Adreno 830, + // KHR-GL43.texture_gather.plain-gather-*-cube-array already passed without the string, so + // this unlocks no conformance case. It is advertised because the feature is real and + // because an application that feature-detects cube map arrays off the string (rather than + // off the 4.0 version) would otherwise decline a path this backend serves. if (cubeMapArraySupported) { extensions.push_back(E_GL_ARB_texture_cube_map_array); } diff --git a/MobileGL/MG_Backend/DirectVulkan/BackendObject_DirectVulkan.cpp b/MobileGL/MG_Backend/DirectVulkan/BackendObject_DirectVulkan.cpp index 3019ba6f..554e153e 100644 --- a/MobileGL/MG_Backend/DirectVulkan/BackendObject_DirectVulkan.cpp +++ b/MobileGL/MG_Backend/DirectVulkan/BackendObject_DirectVulkan.cpp @@ -668,10 +668,11 @@ namespace MobileGL::MG_Backend::DirectVulkan { // view type cannot be created without the imageCubeArray device feature - so the string // follows the feature, not the version, exactly as the per-layer attachment bit does. // - // Worth naming even though cube map arrays are core at the version claimed, because - // KHR-GL4*.texture_gather.plain-gather-*-cube-array checks the STRING and has no - // core-version fallback - five cases per version list sat NotSupported on a device that - // supports the feature. + // Named for the application's benefit rather than the suite's: measured on Adreno 830, + // KHR-GL43.texture_gather.plain-gather-*-cube-array already passed without the string, so + // this unlocks no conformance case. It is advertised because the feature is real and + // because an application that feature-detects cube map arrays off the string (rather than + // off the 4.0 version) would otherwise decline a path this backend serves. if (cubeMapArraySupported) { extensions.push_back(E_GL_ARB_texture_cube_map_array); }