From 9caf34d5b16a27694987ea16f03e4c5d669f7f58 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Sun, 26 Jul 2026 18:14:56 -0400 Subject: [PATCH] [Fix] (Logging): rank WARN/ERROR above INFO so release builds keep them - the old ordering (DEBUG=0, WARN=1, ERROR=2, INFO=3) compiled every MGLOG_W/MGLOG_E out of the default MOBILEGL_LOG_LEVEL_INFO build, silently hiding backend shader-compile failures, unsupported-path skips, and enum-conversion fallbacks during the piglit runs --- MobileGL/MG_Util/Debug/Log.h | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/MobileGL/MG_Util/Debug/Log.h b/MobileGL/MG_Util/Debug/Log.h index 16b82b5b..e0b48f6d 100644 --- a/MobileGL/MG_Util/Debug/Log.h +++ b/MobileGL/MG_Util/Debug/Log.h @@ -9,10 +9,14 @@ #pragma once #include +// Severity-ordered: a build compiled at level X keeps X and everything MORE +// severe. INFO builds must keep WARN/ERROR/FATAL — the old ordering +// (WARN=1/ERROR=2 below INFO=3) compiled every warning and error out of +// release builds and hid real backend failures. #define MOBILEGL_LOG_LEVEL_DEBUG 0 -#define MOBILEGL_LOG_LEVEL_WARN 1 -#define MOBILEGL_LOG_LEVEL_ERROR 2 -#define MOBILEGL_LOG_LEVEL_INFO 3 +#define MOBILEGL_LOG_LEVEL_INFO 1 +#define MOBILEGL_LOG_LEVEL_WARN 2 +#define MOBILEGL_LOG_LEVEL_ERROR 3 #define MOBILEGL_LOG_LEVEL_FATAL 4 #define MOBILEGL_LOG_INTERNAL(levelTag, androidLogLevel, fmt, ...) \