mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-17 06:53:22 +09:00
[MG_IntegrationTest, docs] (P7): the spawn server does have MG_Impl - what it has not is a live context
- the verify-split block and notes/p7/verify-split.md 3.3 both said the spawn server runs no compare "because MG_Impl is not in it", which is false and sent a reader looking for a link-time gap: MobileGLServer is an executable over ServerEntry.cpp linked against the WHOLE library (top-level CMakeLists.txt), PipeFill.cpp included, so MGPipeVerifyReadHook is present and is called on every backend read - the true mechanism: the server image's main reaches MG_Backend::InitServerRoleForSpawn() and never MG_State::Init(), so MG_State::pGLContext is null and the hook returns at its ctx == nullptr line before comparing anything - the inproc-only conclusion is unchanged; what changes is the shape of the fix, which is a cross-process compare rather than a link edit - CONTRACT-P7 12 records that debt by name, and the note's 6 cites it
This commit is contained in:
@@ -4034,9 +4034,17 @@ if (MOBILEGL_BUILD_DISAGGREGATED AND MOBILEGL_PIPE_VERIFY)
|
||||
# (VerifySplitArming's DirectGLES entry with MOBILEGL_TRANSPORT=spawn): the client's entry
|
||||
# compare aborts at the first verb with Fatal{PipeVerifyDiffer, "GetClearColor@Clear", verb=1,
|
||||
# where=entry}, because the fill leaves every record-supplied field to the applier and the
|
||||
# applier now writes ANOTHER process's block; and the server process runs no compare at all,
|
||||
# because MG_Impl is not in it and the read hook finds no live context. A spawn verify lane
|
||||
# would be red at bring-up on the first half and blind on the second.
|
||||
# applier now writes ANOTHER process's block; and the server process runs no compare at all.
|
||||
#
|
||||
# THE SECOND HALF IS NOT "MG_Impl IS NOT IN THE SERVER" - it is, and saying otherwise sent a
|
||||
# reader looking for a link-time gap that does not exist. MobileGLServer is an executable over
|
||||
# ServerEntry.cpp linked against the WHOLE library (top-level CMakeLists.txt), PipeFill.cpp
|
||||
# included, so MGPipeVerifyReadHook is present in that process and is called on every backend
|
||||
# read. What is absent is its ORACLE: the server image's main reaches
|
||||
# MG_Backend::InitServerRoleForSpawn() and never MG_State::Init(), so MG_State::pGLContext is
|
||||
# null and the hook returns at its `ctx == nullptr` line before comparing anything. Same
|
||||
# conclusion, different mechanism, and the difference matters because the fix is a cross-
|
||||
# process compare shape (CONTRACT-P7 §12) rather than a link edit.
|
||||
|
||||
message(STATUS "Integration tests: P7 wave 3 - the verify comparator on the split (inproc) arm, "
|
||||
"both backends, under integration-verify-split")
|
||||
|
||||
Reference in New Issue
Block a user