mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-18 15:33:22 +09:00
[Fix] (Test, Pipe): ask the BUILD, not the source tree, whether a control's arm exists, and probe the CSO emitter by content
- the three capability markers were decided from source-tree file existence / file text alone, so
after packages C and D land they would have armed the PULL build too, where every arm they name
is compiled out: the AbaControl lane would have gone hard red on `ctest -L integration-gpu`
(gate G2 requires it green in both builds) and the Handles lane green against a library with no
{slot, gen} key at all. The whole block now sits under the same `if (MOBILEGL_PIPE_PUSH)` as
MGITEST_PIPE_PUSH_BUILD, and HandleRecycleScenario re-checks that marker before either push arm
asserts, so a hand-forced environment cannot arm an arm this build does not have either
- the two push-only knobs of those lanes (MOBILEGL_PIPE_LEGACY_MEMOS=0, MOBILEGL_PIPE_HANDLE_ABA_CONTROL=1)
are set only in a push build. In a pull build the legacy arm is the only arm and every subsystem
bit is clear, which is D14's startup Fatal{PipeLegacyMemosDisabled} - the process would abort
before the scenario could report its skip. Test NAMES are unaffected, so G2 still compares equal
- the CSO control armed itself off `MG_Impl/Pipe/Tracker.cpp`, a file the owning package does not
create: it implements the tracker and the cache header-only, so all four CsoContentAddressing
entries would have kept skipping after it landed, with a reason that had become false. The probe
now greps every source under MG_Impl/Pipe/ for the two counters the control actually reads
(RenderStateCsoMints / RenderStateCsoBinds), watching the directory and each file, so the owning
package keeps control of its file layout
- an unrecognised MGITEST_HANDLE_ARM is a FAIL in SetUp instead of a silent downgrade to the
Legacy arm, which would have passed while claiming to be the lane it was not
This commit is contained in:
@@ -53,11 +53,15 @@
|
||||
// file is written against the P2 contract commit, before that package lands. Until the tracker
|
||||
// exists there is no CSO to mint, csom is structurally 0 and an assertion about its ratio to csob
|
||||
// would be a statement about nothing. The build answers the question rather than a hand-maintained
|
||||
// list: MG_IntegrationTest/CMakeLists.txt looks for MG_Impl/Pipe/Tracker.cpp and passes the answer
|
||||
// in as MGITEST_PIPE_TRACKER_PRESENT, with a CONFIGURE_DEPENDS on that directory so the answer
|
||||
// cannot go stale. When the tracker lands the arms arm themselves; until then the entries are
|
||||
// registered, visible and SKIPPED with the reason - never absent, and never green for having
|
||||
// asserted nothing.
|
||||
// list: MG_IntegrationTest/CMakeLists.txt greps every source under MG_Impl/Pipe/ for the two
|
||||
// counters' names and passes the answer in as MGITEST_PIPE_TRACKER_PRESENT, with a
|
||||
// CONFIGURE_DEPENDS on that directory and on each file it finds so the answer cannot go stale.
|
||||
// It is a CONTENT probe, not a filename probe, precisely so that the owning package keeps control
|
||||
// of its own file layout - it implements the tracker and the cache header-only today, and a glob
|
||||
// for `Tracker.cpp` would have kept this control skipping forever after that package landed, with
|
||||
// a reason that had become false. When an emitter lands the arms arm themselves; until then the
|
||||
// entries are registered, visible and SKIPPED with the reason - never absent, and never green for
|
||||
// having asserted nothing.
|
||||
|
||||
#include <cstdlib>
|
||||
#include <cstring>
|
||||
@@ -213,10 +217,12 @@ void main() { oColor = vec4(0.0, 1.0, 0.0, 1.0); }
|
||||
return;
|
||||
}
|
||||
if (!BuildMarkerIsSet("MGITEST_PIPE_TRACKER_PRESENT")) {
|
||||
GTEST_SKIP() << "the CSO counters have no emitter in this build: MG_Impl/Pipe/Tracker.cpp "
|
||||
"does not exist, so nothing mints or binds a render-state CSO and "
|
||||
"csom / csob are structurally zero. P2 package B owns the tracker; this "
|
||||
"entry arms itself when it lands.";
|
||||
GTEST_SKIP() << "the CSO counters have no emitter in this build: no source under "
|
||||
"MobileGL/MG_Impl/Pipe/ names RenderStateCsoMints or "
|
||||
"RenderStateCsoBinds, so nothing mints or binds a render-state CSO "
|
||||
"and csom / csob are structurally zero. P2 package B owns the tracker "
|
||||
"and the CSO cache; this entry arms itself when they land, whatever "
|
||||
"files that package chooses to put them in.";
|
||||
return;
|
||||
}
|
||||
if (LibraryLogPath().empty()) {
|
||||
|
||||
Reference in New Issue
Block a user