mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-16 06:23:23 +09:00
[MGPipe] the Fatal texts no longer claim P5 does not chunk
R-10's "P5 does not chunk (R-10)" wording predates the stage chunk budget: buffer content ranges are cut at MGPipeStageChunkBytes() (1e7c372e) and a texture level at whole-width slabs (9469d48e), so the claim is false for the two rows that can outgrow SEG_STAGE - and these messages are what a bring-up reads. - PipeWireEncoder::StageAllocate's two Fatal{RingOverrun, "SEG_STAGE"} sites now say what reaching them means: a blob is staged whole, a row that cuts its content at the stage chunk budget never arrives, so this is a record type with no cut or a piece still larger than the arena. - EncodeRecord's MaxRecordBytes arm says the bound is about the record's own bytes - the stage chunk budget cuts blobs, not a header, payload or inline tail - and keeps the integrator decision it names. - Comments in PipeWireCodec.h, EmitTables.cpp's maxrecop line, Config.h's STAGE_MB knob, PipeStats.h's MaxRecordBytes gauge, SplitRuntimePeek.h and WireLedgerChecks.h said P5 does no chunking; they now say what is cut and what is not. - PipeWireCodecTest.ARecordLargerThanHalfTheRingIsFatalRingOverrun asserts the new diagnostic text instead of "does not chunk (R-10)".
This commit is contained in:
@@ -1058,7 +1058,7 @@ namespace MobileGL::MG_Remote::Client {
|
||||
// AND THE ROW, WHENEVER THE MAXIMUM MOVES. The summary line can carry the
|
||||
// number but not the name - MG_Util is below MG_Remote and has no WireOpName -
|
||||
// and the name is the actionable half: R-10 makes the integrator choose between
|
||||
// early chunking and a bigger ring, and that is a decision about a record
|
||||
// a cut for that row and a bigger ring, and that is a decision about a record
|
||||
// FAMILY. ClientSession::Stop prints the same pair at teardown, but a trace
|
||||
// replay never reaches it (measured: the OpenRA lane's library log ends mid-run
|
||||
// with no teardown line at all), so a stats-enabled run would otherwise publish
|
||||
@@ -1067,7 +1067,7 @@ namespace MobileGL::MG_Remote::Client {
|
||||
if (encoder.MaxRecordBytesSeen() > g_publishedMaxRecordBytes) {
|
||||
g_publishedMaxRecordBytes = encoder.MaxRecordBytesSeen();
|
||||
MGLOG_I("MGPipe: wire ledger: new maximum record - maxrec=%llu "
|
||||
"maxrecop=%s cap=%llu (R-10's proof obligation; P5 does not chunk)",
|
||||
"maxrecop=%s cap=%llu (R-10's proof obligation; blobs are cut, a record is not)",
|
||||
static_cast<unsigned long long>(g_publishedMaxRecordBytes),
|
||||
encoder.MaxRecordOpName(),
|
||||
static_cast<unsigned long long>(encoder.MaxRecordBytesCap()));
|
||||
|
||||
Reference in New Issue
Block a user