mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-16 14:33:24 +09:00
[MGPipe] the Fatal texts no longer claim P5 does not chunk
R-10's "P5 does not chunk (R-10)" wording predates the stage chunk budget: buffer content ranges are cut at MGPipeStageChunkBytes() (1e7c372e) and a texture level at whole-width slabs (9469d48e), so the claim is false for the two rows that can outgrow SEG_STAGE - and these messages are what a bring-up reads. - PipeWireEncoder::StageAllocate's two Fatal{RingOverrun, "SEG_STAGE"} sites now say what reaching them means: a blob is staged whole, a row that cuts its content at the stage chunk budget never arrives, so this is a record type with no cut or a piece still larger than the arena. - EncodeRecord's MaxRecordBytes arm says the bound is about the record's own bytes - the stage chunk budget cuts blobs, not a header, payload or inline tail - and keeps the integrator decision it names. - Comments in PipeWireCodec.h, EmitTables.cpp's maxrecop line, Config.h's STAGE_MB knob, PipeStats.h's MaxRecordBytes gauge, SplitRuntimePeek.h and WireLedgerChecks.h said P5 does no chunking; they now say what is cut and what is not. - PipeWireCodecTest.ARecordLargerThanHalfTheRingIsFatalRingOverrun asserts the new diagnostic text instead of "does not chunk (R-10)".
This commit is contained in:
@@ -856,8 +856,10 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
const Uint64 need = Align8(size);
|
||||
if (need > m_stageCapacity) {
|
||||
MGLOG_F("MGPipe: Fatal{RingOverrun, \"SEG_STAGE\"} a %llu byte blob cannot fit a "
|
||||
"%llu byte staging segment at any occupancy; P5 does not chunk (R-10) - "
|
||||
"raise MOBILEGL_IPC_STAGE_MB or report the record to the integrator",
|
||||
"%llu byte staging segment at any occupancy; a blob is staged whole, so a "
|
||||
"row that cuts its content at MGPipeStageChunkBytes() never reaches this - "
|
||||
"raise MOBILEGL_IPC_STAGE_MB or report the record type with no cut to the "
|
||||
"integrator",
|
||||
static_cast<unsigned long long>(size),
|
||||
static_cast<unsigned long long>(m_stageCapacity));
|
||||
std::abort();
|
||||
@@ -914,9 +916,9 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
ReclaimStagedBytes();
|
||||
}
|
||||
MGLOG_F("MGPipe: Fatal{RingOverrun, \"SEG_STAGE\"} a %llu byte blob does not fit a %llu "
|
||||
"byte staging segment with %llu bytes still in flight (retiredSeq=%llu); P5 "
|
||||
"does not chunk (R-10) - raise MOBILEGL_IPC_STAGE_MB or report the record to "
|
||||
"the integrator",
|
||||
"byte staging segment with %llu bytes still in flight (retiredSeq=%llu); a "
|
||||
"blob is staged whole and only the rows that cut at the stage chunk budget "
|
||||
"stay small - raise MOBILEGL_IPC_STAGE_MB or report that row to the integrator",
|
||||
static_cast<unsigned long long>(size),
|
||||
static_cast<unsigned long long>(m_stageCapacity),
|
||||
static_cast<unsigned long long>(m_stageHead - m_stageTail),
|
||||
@@ -1016,12 +1018,12 @@ namespace MobileGL::MG_Remote::Wire {
|
||||
|
||||
const Uint64 total = layout.TotalBytes;
|
||||
if (total > m_cmd->MaxRecordBytes()) {
|
||||
// R-10: P5 does no chunking and must instead PROVE it never needs any. This is
|
||||
// where the proof fails loudly if it was wrong.
|
||||
// R-10's record bound. The content rows cut their BLOBS at the stage chunk budget
|
||||
// (MGPipeStageChunkBytes); a record's own bytes have no such budget and die here.
|
||||
MGLOG_F("MGPipe: Fatal{RingOverrun, \"%s\"} a %llu byte record exceeds "
|
||||
"RingProducer::MaxRecordBytes() == %llu (half of a %llu byte SEG_CMD); P5 "
|
||||
"does not chunk (R-10) - report it to the integrator, who decides between "
|
||||
"early chunking and a bigger default ring",
|
||||
"RingProducer::MaxRecordBytes() == %llu (half of a %llu byte SEG_CMD); the stage chunk "
|
||||
"budget cuts blobs, not a record's own bytes - report the row to the "
|
||||
"integrator",
|
||||
WireOpName(op), static_cast<unsigned long long>(total),
|
||||
static_cast<unsigned long long>(m_cmd->MaxRecordBytes()),
|
||||
static_cast<unsigned long long>(m_cmd->Capacity()));
|
||||
|
||||
Reference in New Issue
Block a user