From bb45648c41198e58a18c5d1f6e25f7cc211e1fe1 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 6 Oct 2026 12:12:09 -0400 Subject: [PATCH] [Refactor] (P13 W5 S3): Magma's wire texture and vertex-input builders and the buffer shadow size follow the record-arm guard. --- MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp | 2 +- .../DirectVulkan/Renderer/VertexInputStateFactory.cpp | 2 +- MobileGL/MG_State/GLState/BufferState/BufferObject.cpp | 2 +- docs/Disaggregated/notes/p13/tools/s3-ops-3.txt | 3 +++ 4 files changed, 6 insertions(+), 3 deletions(-) create mode 100644 docs/Disaggregated/notes/p13/tools/s3-ops-3.txt diff --git a/MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp b/MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp index 8cdda031..bce350c1 100644 --- a/MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp +++ b/MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp @@ -3150,7 +3150,7 @@ namespace MobileGL::MG_Backend::DirectVulkan { } } -#if MOBILEGL_BUILD_DISAGGREGATED +#if MOBILEGL_BUILD_RECORD_ARM Bool UniformManager::PrepareWireTextureResources(const MagmaProgramSource& program, const ProgramFactory::VkProgramObject& programObj) { if (!program.IsWire()) return true; diff --git a/MobileGL/MG_Backend/DirectVulkan/Renderer/VertexInputStateFactory.cpp b/MobileGL/MG_Backend/DirectVulkan/Renderer/VertexInputStateFactory.cpp index cfd74b60..7f6350de 100644 --- a/MobileGL/MG_Backend/DirectVulkan/Renderer/VertexInputStateFactory.cpp +++ b/MobileGL/MG_Backend/DirectVulkan/Renderer/VertexInputStateFactory.cpp @@ -393,7 +393,7 @@ namespace MobileGL::MG_Backend::DirectVulkan { return entry; } -#if MOBILEGL_BUILD_DISAGGREGATED +#if MOBILEGL_BUILD_RECORD_ARM Bool VertexInputStateFactory::BuildWireVertexInput(const MG_Pipe::MGPipeVertexElementsRecord& elements, const MG_Pipe::MGPipeApplierState& state, Uint32 activeMask, BackendVertexInputState& out) const { out = BackendVertexInputState{}; diff --git a/MobileGL/MG_State/GLState/BufferState/BufferObject.cpp b/MobileGL/MG_State/GLState/BufferState/BufferObject.cpp index b9c924f6..5e2b13fe 100644 --- a/MobileGL/MG_State/GLState/BufferState/BufferObject.cpp +++ b/MobileGL/MG_State/GLState/BufferState/BufferObject.cpp @@ -991,7 +991,7 @@ namespace MobileGL::MG_State::GLState { return m_resource.Bytes(); } -#if MOBILEGL_BUILD_DISAGGREGATED +#if MOBILEGL_BUILD_RECORD_ARM SizeT BufferObject::ShadowAllocationBytes() const { // The extent of the very pointer MappedData() hands out, read by the same caller // (the tracker's registration) on the same thread: the same rule-E surface, the diff --git a/docs/Disaggregated/notes/p13/tools/s3-ops-3.txt b/docs/Disaggregated/notes/p13/tools/s3-ops-3.txt new file mode 100644 index 00000000..58122bd3 --- /dev/null +++ b/docs/Disaggregated/notes/p13/tools/s3-ops-3.txt @@ -0,0 +1,3 @@ +open | MobileGL/MG_Backend/DirectVulkan/Renderer/UniformManager.cpp | Bool UniformManager::PrepareWireTextureResources( +open | MobileGL/MG_Backend/DirectVulkan/Renderer/VertexInputStateFactory.cpp | Bool VertexInputStateFactory::BuildWireVertexInput( +open | MobileGL/MG_State/GLState/BufferState/BufferObject.cpp | SizeT BufferObject::ShadowAllocationBytes() const {