From c69e83735cb59b97d831908f4fdc401c65e426f2 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Sun, 2 Nov 2025 11:15:42 +0800 Subject: [PATCH] [Chore] (GL_Impl/Program): add more logging --- MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp b/MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp index 60b51258..21e19a6f 100644 --- a/MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp +++ b/MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp @@ -756,19 +756,23 @@ namespace MobileGL { switch (pname) { case GL_UNIFORM_BLOCK_DATA_SIZE: { *params = programObject->GetUBOSizeAt(uniformBlockIndex); + MGLOG_D("%s: GL_UNIFORM_BLOCK_DATA_SIZE = %d", __func__, pname, *params); break; } case GL_UNIFORM_BLOCK_NAME_LENGTH: { *params = programObject->GetUniformBlockName(uniformBlockIndex).length() + 1; + MGLOG_D("%s: GL_UNIFORM_BLOCK_NAME_LENGTH = %d", __func__, pname, *params); break; } case GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS: { // TODO: deduct global ubo? *params = programObject->GetActiveUniformBlocksCount(); + MGLOG_D("%s: GL_UNIFORM_BLOCK_ACTIVE_UNIFORMS = %d", __func__, pname, *params); break; } case GL_UNIFORM_BLOCK_BINDING: { // TODO + MGLOG_D("%s: GL_UNIFORM_BLOCK_BINDING = ", __func__, pname, *params); } case GL_UNIFORM_BLOCK_ACTIVE_UNIFORM_INDICES: case GL_UNIFORM_BLOCK_REFERENCED_BY_VERTEX_SHADER: @@ -778,11 +782,11 @@ namespace MobileGL { case GL_UNIFORM_BLOCK_REFERENCED_BY_FRAGMENT_SHADER: case GL_UNIFORM_BLOCK_REFERENCED_BY_COMPUTE_SHADER: default: - MGLOG_D("%s: pname = %s", __func__, MG_Util::ConvertGLEnumToString(pname).c_str()); + MGLOG_E("%s: unknown pname = %p %s", __func__, pname, MG_Util::ConvertGLEnumToString(pname).c_str()); MG_State::pGLContext->RecordError( ErrorCode::InvalidEnum, MakeShared("MG_Impl/GLImpl", __func__, "`pname` is not one of the accepted tokens.")); - return; + break; } }