From c73ae7d443767ed78a9a037c49fcd59aab37ce44 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Tue, 8 Sep 2026 00:40:47 -0400 Subject: [PATCH] [Test] (MG_IntegrationTest): pin MOBILEGL_PIPE_PUSH in the handle-arm lanes - an ENVIRONMENT property overrides only the variables it names, so the gate's all-pull control arm (MOBILEGL_PIPE_PUSH=0 over the whole integration-gpu label) leaked into the Handles and AbaControlHandles lanes, turned their LEGACY_MEMOS=0 into D14's armless combination and made the bring-up abort by design; the lanes now pin the P2 default bitmask themselves --- MobileGL/MG_IntegrationTest/CMakeLists.txt | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/MobileGL/MG_IntegrationTest/CMakeLists.txt b/MobileGL/MG_IntegrationTest/CMakeLists.txt index 40c2b40b..23232940 100644 --- a/MobileGL/MG_IntegrationTest/CMakeLists.txt +++ b/MobileGL/MG_IntegrationTest/CMakeLists.txt @@ -844,8 +844,15 @@ gtest_discover_tests(MobileGLIntegrationTest # precisely D14's startup Fatal{PipeLegacyMemosDisabled} condition - so a lane that set it there # would abort the process before the scenario could report its skip. MOBILEGL_PIPE_HANDLE_ABA_CONTROL # has no field to parse into in a pull build at all (Config.h declares it under #if MOBILEGL_PIPE_PUSH). +# A lane that needs an arm pins EVERY knob that selects it. A ctest ENVIRONMENT property overrides +# only the variables it names; the rest leak in from the job. The five-part gate's all-pull control +# arm runs `MOBILEGL_PIPE_PUSH=0 ctest -L integration-gpu` over the whole label, and without the +# explicit bitmask below that leaked PUSH=0 turned this lane's LEGACY_MEMOS=0 into D14's armless +# combination: the bring-up aborted, on purpose, and the lane went red for a reason that was never +# about handles. The mask is the P2 default (kMGPipeSubsystemsMigratedAtP2), not a hand-picked bit, +# so the lane keeps measuring the shape that ships. if (MOBILEGL_PIPE_PUSH) - set(MGL_ITEST_HANDLES_ARM_KNOBS "MOBILEGL_PIPE_LEGACY_MEMOS=0") + set(MGL_ITEST_HANDLES_ARM_KNOBS "MOBILEGL_PIPE_LEGACY_MEMOS=0" "MOBILEGL_PIPE_PUSH=0x7f") set(MGL_ITEST_ABA_ARM_KNOBS "MOBILEGL_PIPE_HANDLE_ABA_CONTROL=1") else() set(MGL_ITEST_HANDLES_ARM_KNOBS "")