From eadf7bc47401722ab36da5e10963db501ebd3dc0 Mon Sep 17 00:00:00 2001 From: Swung0x48 Date: Thu, 20 Aug 2026 00:42:34 -0400 Subject: [PATCH] [Fix] (TraceReplay): import iterationRP repair flags in the desktop CLI Initialize the desktop replay Request from the three iterationRP environment flags before loading MobileGL. Without this, the Request defaults caused the replay core to unset CI's exported flags, leaving all repairs disabled despite the workflow configuration. --- tools/trace_replay/trace_replay_cli.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/trace_replay/trace_replay_cli.cpp b/tools/trace_replay/trace_replay_cli.cpp index 892bc622..a8345942 100644 --- a/tools/trace_replay/trace_replay_cli.cpp +++ b/tools/trace_replay/trace_replay_cli.cpp @@ -72,8 +72,16 @@ bool ReadDouble(int argc, char **argv, int &index, double &out) { return true; } +bool ReadEnvFlag(const char *name) { + const char *value = std::getenv(name); + return value != nullptr && std::string(value) == "1"; +} + bool ParseArgs(int argc, char **argv, mobilegl_trace::Request &request) { request.backend = "DirectGLES"; + request.fixIterationRPSubgroupScratch = ReadEnvFlag("MOBILEGL_FIX_ITERATIONRP_SUBGROUP_SCRATCH"); + request.deriveNumSubgroups = ReadEnvFlag("MOBILEGL_DERIVE_NUM_SUBGROUPS"); + request.iterationRPFixBarrier = ReadEnvFlag("MOBILEGL_ITERATIONRP_FIX_BARRIER"); for (int i = 1; i < argc; ++i) { const std::string arg = argv[i];