1 Commits

Include renames

Author	SHA1	Message	Date
swung0x48	fdd611e83d	[MG_Backend, MG_Test, MG_IntegrationTest, scripts, docs] (P7): the depth mip chain is baked, and every baked header in the tree now has to match its source ... CONTRACT-P7 §5.1's (A) and (D), and (D) is what makes (A) safe to have. (A) WireDepthMipmap.{vert,frag,inc}. VK_FORMAT_FEATURE_BLIT_DST is OPTIONAL for depth formats, so a depth chain through a shader is the ordinary case and not the exotic one - the monolith arm has carried such a fallback since before the split. The wire arm had none, so a depth texture the device would not blit died on the first disjunction of `mipmap-shader-format-or-shape`, and a DEPTH|STENCIL one died a guard earlier as `depth-stencil-mipmap@P7` whether or not it could be blitted. The monolith's fallback is not reusable, which is the whole of (A): it builds a GL ProgramObject, two ShaderObjects and a GL sampler, binds through the uniform manager's global UBO and writes uSrcTexelSize as a default-block uniform - four frontend objects and a GL compiler on the server's apply thread. The baked program is the same shader with the same arithmetic on a push constant and its own descriptor set. The fragment stage is a PORT and not a rewrite: §3.2 retires a refusal by making the wire arm observably the monolith's, so the 2x2 box lands where the monolith's lands, including the half texel its ivec2(texCoord * srcTexelSize) sits off the destination centre. `depth-stencil-mipmap@P7` therefore splits. DEPTH-only retires into the baked program. DEPTH|STENCIL declines - MGLOG_E_ONCE and return, before the chain is grown, so a level this verb will not fill is not created and then recorded as defined. A decline rather than a Fatal because the monolith does no better: its fallback asserts depth-only, and an assert is nothing in the release build both arms ship as. Nothing in GL promises a stencil mip either, and this pass writes gl_FragDepth - it would leave the stencil aspect of the level it just produced undefined. (D) MOBILEGL_BAKED_INTERNAL_SHADERS. A baked header is a compiler output committed with its input beside it and nothing connecting the two: edit the source and the build stays green while the shader that runs is the one from before the edit. MG_Test's BakedInternalShadersTest recompiles all eight arrays - WireColorBlit x2, WireDepthMipmap x2, the iterationRP witness, the three probe stages - from their committed GLSL with the in-tree glslang and compares word for word. THE GATE IS THE BAKER. scripts/bake_internal_shaders.py compiles nothing; it runs this binary with MOBILEGL_BAKE_INTERNAL_SHADERS and splices the words it emits. A gate that used the glslang LIBRARY while the baker shelled out to a glslangValidator BINARY would be two compilers with no rule about which is right, and the day their defaults diverge the gate reds on a header nobody can regenerate. What the first run measured, which is the one thing nobody could know beforehand: WireColorBlitSpirv.h and all three arrays of PrimitivesGeneratedNoXfbProbeSpv.h were already fresh - the hand-run glslangValidator words reproduce exactly. The iterationRP witness was stale, as its own prose said; it is regenerated here (2142 -> 2143 words), and the witness magic 0x50323033 is still there because it is a constant in the .comp rather than a property of the words. All three provenance comments now point at the script and the gate instead of at a tool on somebody's PATH. Scenarios, on the three Magma arms: GenerateMipmapDepthWithoutNativeBlitPixels runs DEPTH_COMPONENT24 and DEPTH_COMPONENT32F under MGITEST_MAGMA_FORCE_SHADER_MIPMAP=1 and reads level one back through a real sampled attachment, asserting per half and leaving row 3 - the straddle band - unpinned, because pinning it would assert the half-texel offset rather than the mip. GenerateMipmapDepthStencilDeclinesAndKeepsTheSession takes no knob (the decline is on the aspect, before blit support is asked about) and pins that the session survives and level zero still holds what was cleared into it. Red once, three of them, executed and reverted: - a one-character edit to WireDepthMipmap.frag (no rebuild - the gate reads the source at runtime) reds the WireDepthMipmapFragment row at word 279; - with the depth arm disabled, the DepthMip entries die with Fatal{UnmigratedVerb, "Magma:mipmap-shader-format-or-shape format=125 ... aspect=0x2 ... missing=COLOR_ATTACHMENT"} - format 125 is X8_D24_UNORM_PACK32, which slice 1's diagnostic names for us; - with the Fatal restored, the decline case dies as Fatal{UnmigratedVerb, "Magma:depth-stencil-mipmap@P7"}. Gates: integration-magma-split 77 (+2), -spawn 56 (+2), -tcp 58 (+2), 0 red; ctest -L unit 2410 (+8, the gate's rows); informational integration-magma-full-split 513, 0 red, 59 skip (base 510/0/57); fatal_census green (79 abort sites, 43 words, 0 unmarked); link_ratchet --assert-monotone unchanged at 186, p7-magma 101. G1 holds and it was not obvious: the witness header is compiled into the pull build too, and its word count changed. Pull .text is still 0xa52203 and the defined-symbol name list is identical to ~/w7/p7-before/pull-syms.txt line for line (30570) - the change lands in .rodata and widens no instruction encoding. VulkanRenderer.h is edited outside this package's file list: the new pass needs four private declarations next to the colour blit's. Flagged for the integrator.	2026-09-22 16:37:54 -04:00