3 Commits

Include renames

Author	SHA1	Message	Date
swung0x48	3d9a38a979	[MG_IntegrationTest, CI] (P7): the split arms take a backend, so Magma has two-process lanes at last ... P7 exit gate 1 asks for integration green "under Magma push and split". Until now it was not merely unmet, it was UNMEASURABLE: every arm of mgl_itest_register_split_arms hardcoded MOBILEGL_BACKEND_TYPE=DirectGLES (:2002/:2025/:2031) and MGL_ITEST_MAGMA_WIRE_ENVIRONMENT hardcoded MOBILEGL_TRANSPORT=inproc (:2456), so the shared integration-split / -spawn / -tcp labels held ZERO DirectVulkan entries and the 73 integration-magma-split cases only ever ran in one process. The registration macro now takes the backend as its first argument; the old name is a thin wrapper, so all 32 call sites are untouched and every DirectGLES name, label and private log path is byte-for-byte what it was. Two tiers come out of it, and the CMake comment states both: * GATED - integration-magma-{split,spawn,tcp}. The six hand-laid Magma lanes (Fm, Buffers, RunAhead, Caches, NamedBlit, P5fRsp) grow arms through one shared shape macro; the inproc arm keeps its names, its labels and its log paths, so the CI steps and the two magma_* checker scripts that name them by hand keep working unchanged. * INFORMATIONAL - integration-magma-all-{split,spawn,tcp}, in no gating step. Every scenario the split arms run, on Magma, on all three transports, generated by REPLAYING the macro's recorded call list - so a scenario added to the split arms tomorrow joins the Magma census the same day. Its job is to be able to go red while CI stays green; a case moves up into the gated tier with the commit that retires its blocker. The label spellings are chosen against ctest -L's regex (ID-131 again): the tier word goes in the MIDDLE, because integration-magma-spawn-all WOULD have been selected by -L integration-magma-spawn and pulled ~100 expected-red entries into a gated lane. Sub-labels mirror it: the inproc arm keeps integration-magma-buffers, the others put the arm word first. MagmaRunAheadScenario and MagmaWireCacheScenario stay on the inproc arm alone, and that is MEASURED rather than assumed: with all three arms registered, all 21 entries red on spawn and tcp with no Fatal in either role log - the first arms its hold through ServerLoopInstance().SetBeforeRetireHookForTesting, a hook on THIS process's server loop, and the second asserts transportName == "inproc" in its SetUp. Both are named in the CMakeLists and in spawn_lane_parity.py rather than allowed to widen a tolerance. split_log_paths.py's is_split prefixes gain DirectVulkan.Spawn. / .Tcp. - on those arms two processes append to one path, so a shared log does not merely blur attribution, it interleaves two sessions. spawn_lane_parity.py gains the Magma dimension, normalising only the ARM segment: RunAhead.Credit1. and .Credit3. are two entries of one case and a tail-stripping normaliser would fold them together and then report an equal-sized set that had lost one. Measured on this tree (lavapipe): magma-split 73 unchanged and green, magma-spawn 52/52, magma-tcp 52/52, the three informational lanes 102 each, GLES split 186 / spawn 102 / tcp 104 all unchanged and green. G14 against ~/w7/p7-before: 4155 to 4565, removed 0, added 410.	2026-09-22 14:24:19 -04:00
swung0x48	018fab0f5b	[WIP] (MG_Remote): implement P6.5 TCP and stream transport	2026-09-22 07:19:18 -04:00
swung0x48	15f5b54bbd	[MG_IntegrationTest, CI] (P6/t6): integration-spawn, and the set identity made structural instead of maintained ... Exit gates 9.2 and 9.3. Until now nothing ran the integration suite across a process boundary at all - the spawn shape was proven only by the retrace lane, which exercises one trace per case and no scenario assertions. integration-spawn: 102 cases, 102 green. THE SET IDENTITY IS THE POINT, AND IT IS NOT MAINTAINED BY HAND. 9.2 asks that the spawn lane's case-name set equal the split lane's. Registering the spawn arm as a second copy of each block would satisfy that today and drift the first time somebody adds a scenario to one of them - and a spawn lane covering LESS goes green while proving less, with nothing about a smaller green lane looking wrong. The eleven split-environment blocks become eleven calls to one macro that emits BOTH arms from one filter, so a case added to either is added to both or to neither. scripts/ci/spawn_lane_parity.py asserts it anyway, because a macro is one edit from a hand-written block. It compares SETS rather than counts - a count can agree while the membership does not - and carries exactly one sanctioned asymmetry, named in the file: integration-split also labels the PUSH-MONOLITH arm, whose scenario is monolith-only by construction. R-16: introduce a split-only block and it reds naming the case and the macro to use. THREE CASES SKIP UNDER SPAWN, BY NAME. CtWireScenario reads PipeApplier's in-process tallies through ServerVerbs(); under spawn those live in the SERVER's process and this one's copy is 0 forever, so the assertions were failing about somebody else's memory. That is a harness limit, not a product defect - the records themselves cross, which the retrace lane proves. They are SKIPPED and not deregistered: a case dropped from the registration would make the two sets differ silently, which is the drift the macro exists to prevent. What retires the skip is cross-process telemetry, which is also what S8's SessionFaultCount needs. TWO REAL REGRESSIONS THE EXISTING GATES CAUGHT, both from this refactor: * the macro dropped the per-block TEST_LIST variables, which were what SplitLogPaths fed to give every entry a PRIVATE MOBILEGL_LOG_FILE_PATH. SplitLogPaths.PrivateAndDistinct went red naming the first orphan. The macro accumulates list NAMES now, so a block added later is covered without anyone remembering to extend a list - and the names have to be unique, because gtest_discover_tests' TEST_LIST is populated when CTEST runs, not at configure time, so one shared variable held only the last block's entries. That matters more on the spawn arm: there TWO PROCESSES append to the path, so a shared file interleaves two sessions rather than merely being ambiguous. * the configure_file that substitutes those names ran BEFORE the F1 and Ct blocks registered, so it captured neither. Same gate, naming F1WireScenario.ClearBufferfiPixels. It now runs last. junit_tally gains --require-spawn-ran beside --require-split-ran: the prefix IS the arm, and a shared flag would let one lane tally the other's entries and call itself run. Verified to discriminate - the spawn junit reads 96/0/5 under its own flag and 0/0/0 under the split flag, which correctly fails. Two death tests follow the ADOPT_TIER message the census commit retagged with Fatal{UnimplementedAdoptTier}; their regexes asserted the old wording. Unit 2353 (one pre-existing environmental failure), integration-split 186/186, integration-spawn 102/102, retrace 6/6, fatal census 0 unmarked, G1 0 symbols and .text unchanged at 0xa52203.	2026-09-21 20:20:24 -04:00