# P0 polish package: findings from the final review of feat/disaggregated 8349babe..aa005720 All line numbers refer to the tree at aa005720 (~/w7/pipe). Fix every item below. ## MAJOR ### T-1 (transport, inproc doorbell has no death state -> Shutdown can never join a parked waiter) `InProcessChannel::Close()` (MobileGL/MG_Remote/Transport/InProcessTransport.cpp:74-88) rings each `CondVarDoorbell` once and the comment at :83-84 claims this stops a peer parked mid-frame from hanging. It does not: `Doorbell::Wait` (Doorbell.h:136-176) consumes that one ring, re-tests `ready()` (false, nothing was published), tests `Dead()` - which `CondVarDoorbell` never overrides (Doorbell.h:113, :199-211; Doorbell.cpp:29-71 has no death state) - and with `kWaitForever` loops straight back into `Park()`, forever. `Shutdown()` of the inproc transport can therefore never join a server thread that is in the design's own steady state (consumer spins, sets consumerParked, then blocks). No test covers it (every `Wait` in MG_Test/Wire uses 5000/30/0 ms). Fix: give `CondVarDoorbell` an `std::atomic m_dead` + `void Kill()` (set under the mutex, `notify_all`), override `Dead()`, make `Park` return false immediately when dead, have `Close()` call `Kill()` (keep `Notify()` for raw `Park` callers), and add `InProcessTransportTest.ShutdownUnparksAWaiterWithNoDeadline` (a thread in `Wait(parked, []{return false;}, kDefaultSpinUs, kWaitForever)`, `Shutdown()` from the test thread, join within a bound). Verify the test hangs (or times out) without the fix. ### T-2 (transport, ring accepts records it can never place -> silent producer stall) Ring.cpp:126 only refuses `total > m_capacity`, but a record with `capacity/2 < total <= capacity` is unreservable at any offset where neither `spaceToEnd >= total` nor `offset >= total` holds, even in an empty ring: `Reserve` (:137-148) needs `spaceToEnd + total` bytes when a pad is required, which exceeds capacity there. Concrete: 256-byte ring, one 16-byte record written, popped and retired (head offset 16, FreeBytes()==256), `Reserve(1, kRecNone, 240)` (total 248) returns nullptr forever; a producer waiting on `FreeBytes() >= 248` deadlocks. For `total <= capacity/2` the worst case is `2*total-8 <= capacity-8`, so half is the correct bound. Fix: reject `total > m_capacity / 2` at Ring.cpp:126 (same message, "half the ring"), state `Capacity()/2` as the chunking bound in Ring.h:169-174 and in the G3 chunking comment in MobileGL/MG_Pipe generated header comments / gen_pipe.py where the "record larger than the segment -> chunk" rule is stated, and add `RingTest.RecordLargerThanHalfTheRingIsRefused` plus the offset-16/248 scenario as the negative control (today it spins on nullptr). ### P-1 (interface hole: the six backend-owned compute limits have no carrier) `MGPCaps` (MobileGL/MG_Pipe/MGPipeTypes.h:123-140) is `DynamicBackendParameters` + `CallMask` + two blobs, and `DynamicBackendParameters` (MobileGL/MG_Backend/BackendObject.h:316-530) carries `MaxComputeWorkGroupInvocations` but no per-axis `MaxComputeWorkGroupCount[3]` / `MaxComputeWorkGroupSize[3]`. Those six are exactly the backend-owned answers that survive the getter retirement (GL_Getter.cpp:1160-1177, MG_Util/ShaderTranspiler/CompileEnv.cpp:134-138, DirectVulkan.cpp:672-703 from VkPhysicalDeviceLimits), yet the .def footer (MobileGL/MG_Pipe/PipeCalls.def:143-145) repeats the disproved claim that "only GL_COMPUTE_WORK_GROUP_SIZE is a real backend answer and it lives in MGPCaps". Fix: add `Int MaxComputeWorkGroupCount[3]; Int MaxComputeWorkGroupSize[3];` to `DynamicBackendParameters` and fill them in BOTH backends at capability init (DirectGLES from `glGetIntegeri_v(GL_MAX_COMPUTE_WORK_GROUP_COUNT/SIZE, i)` where the other limits are probed; DirectVulkan from `VkPhysicalDeviceLimits::maxComputeWorkGroupCount/Size`), keep the `GetIntegeri_v` table path working exactly as today (do NOT change GL_Getter/CompileEnv behaviour in this package - that is P0.5), add the unit/integration assertion that the new fields equal what `glGetIntegeri_v` answers (AdvertisedLimitsScenario is the natural home), and rewrite the .def footer to say the six limits live in MGPCaps and GL_COMPUTE_WORK_GROUP_SIZE is a frontend link artifact. Update the MGPCaps size assertion accordingly (it is a composition of sizeof(DynamicBackendParameters)+...). ## MINOR (one hygiene commit) - S-1 stats: `PipeStats.cpp` `OnPresent()` does `store(0)` on `g_frameBytes/Calls/Gate*` which races with a concurrent `Bump` from another thread (buffer/texture staging is multi-threaded per the header): a frame-scoped add can be lost from the Tracy plot. Fix: `exchange(0, relaxed)` and plot the exchanged value. - T-3 FdPassing.cpp:207-209: when `MSG_CMSG_CLOEXEC` is absent (macOS/BSD) received fds have no CLOEXEC; add `fcntl(fd, F_SETFD, FD_CLOEXEC)` for every received fd under `#if !defined(MSG_CMSG_CLOEXEC)`. Same platform: `MSG_NOSIGNAL` (FdPassing.cpp:136, Doorbell.cpp:94) is undefined there; `#ifndef MSG_NOSIGNAL` -> 0 plus `SO_NOSIGPIPE` on the socket. - T-4 CMakeLists.txt:444-445: `set(... CACHE BOOL ... FORCE)` writes OFF into the cache, so after the operator runs `git submodule update` a plain re-configure still yields OFF with no message. Use a normal-variable `set(MOBILEGL_BUILD_DISAGGREGATED OFF)` (shadows the cache for this configure only) with the same message(WARNING). - P-2 PipeCalls.def: three live GLFunctionsTable entries have no carrier: `GetGpuTimestampNs` (GL_Getter.cpp:1355/2265, glGetInteger64v(GL_TIMESTAMP), synchronous server answer), `QueryCounterTimestamp` (glQueryCounter, not a begin/end pair), `WaitSync` (GPU-side wait, distinct from FenceWait's client wait). Records are append-only: APPEND `QueryTimestamp` (kCtxQuery, kReplySlot), `QueryCounter` (kCtxQuery) and `FenceWaitServer` (kScreen) at the end of their groups' natural place BUT without renumbering any existing opcode (append to the end of the list if opcodes are positional), regenerate with gen_pipe.py, update the catalogue counts in the .def header and the PipeCatalogueTest expectations. - P-3 MGPipeTypes.h:411-417 inlines a 32 B `MGHostSpan` in every `MGPBufferRange` of every class, and `MGPStreamOutputTargets` (:429-436) reuses it: 32 B/entry of dead space for SSBO/atomic/XFB records, and the plan's D-B8 says not to freeze this payload's shape before the `stage-ubo-named` numbers exist. Keep the range at 24 B and carry the named-UBO host span as an optional var-tail (flag kHostSpan on set_shader_buffers already exists) - adjust the payload, its field list, the size assertion and the test. - P-4 (accepted in review 1, never reworked): ConfigLoader.cpp:164-183 `QueryEnvUint64` accepts `-1` and silently reads octal via `strtoull(...,0)` - parse base 10 (and 0x prefix explicitly if wanted), reject a leading '-' with the warning; test.yml pipe-gates stdio grep misses `fprintf(stdout` - extend the alternation; `MGPSubData` has no buffer offset/size convention - document (and if needed add) how the buffer half of resource_subdata expresses [offset,size) (e.g. UnionBox.x/w with target==Buffer) and assert it in the test; `gen_pipe.py` does not check that every call payload has a verify field list - make it fail when a payload named in PipeCalls.def has no entry in PipeFields.def (except the documented memcmp-fallback types), and add the check to `--check`. - The first-review minor "MGPPixelPackState size assertion is tautological" (it asserts sizeof against itself): assert against the literal 28 that PixelStoreParameters measured.