Files
MobileGL/docs/Disaggregated/notes/handoff/review-f-fix.md
T

1.8 KiB
Raw Blame History

Review: F fix round (pipe 0293aebb c69d8dfd 8c8fc319 9cea5140) — integrator (Fable 5.1, main session)

Verdict: land (two nits, recorded in CONTRACT-P7 §12 / ph-f.md; no code change required before push).

  1. nit — ServerMain.cpp RunSession: between session.Accept() returning and ::close(sourceFd) a DataBind the supervisor already forwarded is closed with the child's queue (the passed fd goes with it), so that one peer sees a bare close instead of Refuse{Authentication}. Window is microseconds; acceptable; record.
  2. nit — scripts/ci/protocol_revision_pin.py: any byte change to protocol.fbs (comment/whitespace) forces a revision bump; strict by design, say so in the docstring. Verified from the diffs: child closes pair[1] after Accept (supervisor's SendFd then fails ECONNREFUSED/ENOTCONN → TRANSPORT_CLOSED → named refusal on the extra connection; MSG_NOSIGNAL already set, MSG_DONTWAIT maps EAGAIN → TIMEOUT → same refusal); the refusal is written on the extra connection and its object is closed by the caller as before; listener closed only on the single-session (ListenerSource) path, --serve keeps the supervisor's listener; DrainUnread bounded 256×4 KiB; MalformedHello is a generated RefuseCode (already in the vocabulary, census unchanged 79/44/3); pin script LF-normalises, two-sided (stale row / missing row), --write refuses re-pin, CI step in flatc-check with nonzero exit; token compare width = max(64, configured length) with both operands zero-padded, the >64 length class leak stated; MintNonce failure now sends Refuse{LinkTerms} and still exits 67; PH-8 log line fires only when a peer asks for more than granted; no pull-build file touched (G1 holds by construction; gate on 9cea5140: unit 2436, tcp 223, spawn 220, magma 100/79/71, verify 1148/1082).