mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-16 06:23:23 +09:00
1.8 KiB
1.8 KiB
Review: F fix round (pipe 0293aebb c69d8dfd 8c8fc319 9cea5140) — integrator (Fable 5.1, main session)
Verdict: land (two nits, recorded in CONTRACT-P7 §12 / ph-f.md; no code change required before push).
- nit —
ServerMain.cppRunSession: betweensession.Accept()returning and::close(sourceFd)a DataBind the supervisor already forwarded is closed with the child's queue (the passed fd goes with it), so that one peer sees a bare close instead ofRefuse{Authentication}. Window is microseconds; acceptable; record. - nit —
scripts/ci/protocol_revision_pin.py: any byte change toprotocol.fbs(comment/whitespace) forces a revision bump; strict by design, say so in the docstring. Verified from the diffs: child closespair[1]after Accept (supervisor'sSendFdthen fails ECONNREFUSED/ENOTCONN → TRANSPORT_CLOSED → named refusal on the extra connection;MSG_NOSIGNALalready set,MSG_DONTWAITmaps EAGAIN → TIMEOUT → same refusal); the refusal is written on the extra connection and its object is closed by the caller as before; listener closed only on the single-session (ListenerSource) path,--servekeeps the supervisor's listener;DrainUnreadbounded 256×4 KiB;MalformedHellois a generatedRefuseCode(already in the vocabulary, census unchanged 79/44/3); pin script LF-normalises, two-sided (stale row / missing row),--writerefuses re-pin, CI step in flatc-check with nonzero exit; token compare width = max(64, configured length) with both operands zero-padded, the >64 length class leak stated;MintNoncefailure now sendsRefuse{LinkTerms}and still exits 67; PH-8 log line fires only when a peer asks for more than granted; no pull-build file touched (G1 holds by construction; gate on9cea5140: unit 2436, tcp 223, spawn 220, magma 100/79/71, verify 1148/1082).