mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-07 18:13:23 +09:00
The spawn work had the two roles append to one MOBILEGL_LOG_FILE_PATH under O_APPEND. It was correct - two processes at one offset would corrupt the file, O_APPEND made each write atomic - but it put two sessions' lines in one place and made every per-side assertion a search. This splits the sink: the client role writes <base>.client.log and the server role writes <base>.server.log. THE BASE NAME NAMES NO FILE ANY MORE, AND THAT IS THE POINT. Leaving the client at the old unsuffixed path would have been the compatible choice and the wrong one: a reader that was not updated would go on finding a file, go on passing, and go on seeing only half the session - and a refusal census that reports a confident zero for the half it cannot see is worse than one that fails. With both names moved, an un-updated reader gets "file not found" and says so. There were 34 such readers; every one is moved here. THE ROLE IS PER-THREAD, not per-process, because under inproc both roles are threads of one process. Log.cpp keys the sink on a thread-local role: the apply thread declares itself server (ServerLoop.cpp), a spawned image is server for its whole life (MOBILEGL_IPC_ROLE=server, read once), and everything else is the client. The naming rule (RoleLogPath) and the two whole-log operations (ReadRoleLogs / TruncateRoleLogs) are EXPORTED from the library, so no reader reimplements the derivation - a second copy is the copy that falls behind. Readers, by how they read: - unit mains set MOBILEGL_LOG_FILE_PATH and read a role file: they keep the base in the env and derive the client path from the library helper. - the death-test child runners (ReadLog) now concatenate BOTH roles: a death test asserts the CHILD said something, and the applier's refusals - the very diagnostics these check - are written under the server role. - the offset-based Emit readers derive the client path once after setenv. - PipeStatsWindow reads both, because draws/vbs increment in the backend's PrepareForDraw - the apply thread, the server role - so the summary line is in the server file even under inproc. - run_trace_case.cmake's split census reads both files; the client keeps the transport markers. - split_log_paths.py (and its self-test, and the control stub) derive both role files from the declared base. - the Android script pulls both role files off the device and concatenates them, so every downstream check is unchanged - and it judges a role file by CONTENT, because `run-as test -f` through `exec-out` returned 0 for a missing file on the device and `exec-out` folds cat's own not-found line into stdout. The monolith arm legitimately has no server file, and that is a silent skip rather than a one-line server log. Guarded so a pull build is untouched: RoleLogPath and the role sink are wholly inside MOBILEGL_BUILD_DISAGGREGATED; a non-disaggregated build writes the base path exactly as before. G1 re-measured - 0 symbol diff, .text unchanged at 0xa52203. Verified on device 2f7cbe2e: monolith writes only the client log (no phantom server log), inproc and spawn each write both and pass their transport proofs (spawn: server role in pid 16125). Unit 2353 (one pre-existing environmental failure), integration-split 186/186, integration-spawn 102/102, retrace 6/6, control smoke 12/12, split-log-paths self-test 9/9.
665 lines
28 KiB
Bash
665 lines
28 KiB
Bash
#!/bin/sh
|
|
set -eu
|
|
|
|
ADB="${ADB:-adb}"
|
|
PYTHON="${PYTHON:-python3}"
|
|
INFRASTRUCTURE_FAILURE_EXIT_CODE=75
|
|
|
|
usage() {
|
|
cat <<'EOF'
|
|
Usage:
|
|
sh android-plugin/trace-replay-ci.sh \
|
|
--apk-file FILE \
|
|
--package PACKAGE \
|
|
--backend BACKEND \
|
|
--result-root DIR \
|
|
--fixture-root DIR \
|
|
--case NAME \
|
|
--trace-archive FILE \
|
|
--trace-file FILE_IN_ARCHIVE \
|
|
--golden FILE \
|
|
[--alternate-golden FILE] \
|
|
--target-call N \
|
|
--width N \
|
|
--height N \
|
|
--ssim-threshold N \
|
|
--crop-x N \
|
|
--crop-y N \
|
|
--crop-width N \
|
|
--crop-height N \
|
|
[--use-pbuffer] \
|
|
[--avoid-angle-llvmpipe-sampler-mipmap-min-filter] \
|
|
[--avoid-angle-llvmpipe-explicit-lod-bias] \
|
|
[--coherent-as-flush] \
|
|
[--dump-texture-2d CALL,TEXTURE,LEVEL,DIR] \
|
|
[--env "K=V;K=V"] \
|
|
[--require-inproc] \
|
|
[--require-spawn] \
|
|
[--benchmark] \
|
|
[--benchmark-tail-frames N] \
|
|
[--benchmark-finish 0|1] \
|
|
[--reuse-fixture] \
|
|
--timeout-seconds N
|
|
|
|
Set MOBILEGL_ESPRYT_USE_ANGLE=1 to run DirectGLES replay with packaged ANGLE
|
|
instead of the device system GLES driver.
|
|
Set MOBILEGL_TRACE_ANGLE_VARIANT to the packaged ANGLE short hash used by
|
|
DirectGLES replay.
|
|
Set MOBILEGL_RETRACE_USE_PBUFFER=1 or pass --use-pbuffer to run
|
|
against an offscreen EGL pbuffer instead of the Activity surface.
|
|
Set MOBILEGL_MAGMA_FIX_ITERATIONRP_SUBGROUP_SCRATCH=1,
|
|
MOBILEGL_MAGMA_DERIVE_NUM_SUBGROUPS=1, and MOBILEGL_MAGMA_ITERATIONRP_FIX_BARRIER=1 to
|
|
forward the corresponding iterationRP SPIR-V repairs into the APK process.
|
|
Pass --avoid-angle-llvmpipe-sampler-mipmap-min-filter for DirectGLES traces that
|
|
need ANGLE llvmpipe sampler mipmap filters downgraded to avoid driver stalls.
|
|
Pass --avoid-angle-llvmpipe-explicit-lod-bias for DirectGLES traces whose shaders
|
|
sample with an explicit LOD that ANGLE llvmpipe cannot take a LOD bias on
|
|
(MOBILEGL_ESPRYT_AVOID_EXPLICIT_LOD_BIAS=1).
|
|
Pass --coherent-as-flush for traces whose engine writes persistent
|
|
GL_MAP_FLUSH_EXPLICIT_BIT maps it never flushes (MOBILEGL_COHERENT_AS_FLUSH=1).
|
|
Pass --benchmark to replay the whole trace as a frame-timing benchmark instead of
|
|
snapshotting one frame and comparing it against the golden. The run then also
|
|
copies benchmark.json (per-frame times plus mean/median/p95) out of the app, and
|
|
"passed" only means the replay reached the end of the trace without an error.
|
|
Pass --reuse-fixture to skip re-extracting and re-pushing the trace, for repeat
|
|
runs of a case whose fixture is already in /data/local/tmp.
|
|
Pass --env "K=V;K=V" (or set MOBILEGL_TRACE_ENV) to hand arbitrary environment
|
|
variables to the replay process. They are applied last, immediately before
|
|
libMobileGL.so is loaded, so they override every flag above; an entry with no "="
|
|
unsets the variable instead. This is the generic passthrough: a MOBILEGL_* knob
|
|
that has no flag of its own needs no plumbing to be forwarded.
|
|
Pass --require-spawn to require the same proof for transport=spawn, plus the one
|
|
sentence a monolith fallback can never write: the pid of the server process.
|
|
Pass --require-inproc to require the library's real transport-resolution log,
|
|
strict errors and separate role state, plus zero Fatal records. This checks the
|
|
APK process after replay; a host environment echo or an SSIM-only pass is not proof.
|
|
EOF
|
|
}
|
|
|
|
die() {
|
|
echo "trace-replay-ci.sh: $*" >&2
|
|
usage >&2
|
|
exit 2
|
|
}
|
|
|
|
host_path_for_adb() {
|
|
if command -v cygpath >/dev/null 2>&1; then
|
|
cygpath -w "$1"
|
|
else
|
|
printf '%s' "$1"
|
|
fi
|
|
}
|
|
|
|
adb_device_path() {
|
|
MSYS_NO_PATHCONV=1 MSYS2_ARG_CONV_EXCL='*' "${ADB}" "$@"
|
|
}
|
|
|
|
next_arg() {
|
|
if [ "$#" -lt 2 ]; then
|
|
die "$1 requires a value"
|
|
fi
|
|
printf '%s' "$2"
|
|
}
|
|
|
|
require_value() {
|
|
value="$1"
|
|
name="$2"
|
|
if [ -z "${value}" ]; then
|
|
die "missing ${name}"
|
|
fi
|
|
}
|
|
|
|
apk_file=""
|
|
package_name=""
|
|
backend=""
|
|
result_root=""
|
|
fixture_root=""
|
|
case_name=""
|
|
trace_archive=""
|
|
trace_file=""
|
|
golden_path=""
|
|
alternate_golden_path=""
|
|
target_call=""
|
|
width=""
|
|
height=""
|
|
ssim_threshold=""
|
|
crop_x=""
|
|
crop_y=""
|
|
crop_width=""
|
|
crop_height=""
|
|
use_pbuffer=0
|
|
avoid_angle_llvmpipe_sampler_mipmap_min_filter=0
|
|
avoid_angle_llvmpipe_explicit_lod_bias=0
|
|
coherent_as_flush=0
|
|
texture_2d_dumps=""
|
|
env_overrides="${MOBILEGL_TRACE_ENV:-}"
|
|
require_inproc=0
|
|
require_spawn=0
|
|
benchmark=0
|
|
benchmark_tail_frames=200
|
|
benchmark_finish=1
|
|
reuse_fixture=0
|
|
timeout_seconds=""
|
|
|
|
while [ "$#" -gt 0 ]; do
|
|
case "$1" in
|
|
--apk-file) apk_file="$(next_arg "$@")"; shift 2 ;;
|
|
--package) package_name="$(next_arg "$@")"; shift 2 ;;
|
|
--backend) backend="$(next_arg "$@")"; shift 2 ;;
|
|
--result-root) result_root="$(next_arg "$@")"; shift 2 ;;
|
|
--fixture-root) fixture_root="$(next_arg "$@")"; shift 2 ;;
|
|
--case) case_name="$(next_arg "$@")"; shift 2 ;;
|
|
--trace-archive) trace_archive="$(next_arg "$@")"; shift 2 ;;
|
|
--trace-file) trace_file="$(next_arg "$@")"; shift 2 ;;
|
|
--golden) golden_path="$(next_arg "$@")"; shift 2 ;;
|
|
--alternate-golden)
|
|
if [ "$#" -lt 2 ] || [ "${2#--}" != "$2" ]; then
|
|
alternate_golden_path=""
|
|
shift 1
|
|
else
|
|
alternate_golden_path="$2"
|
|
shift 2
|
|
fi
|
|
;;
|
|
--target-call) target_call="$(next_arg "$@")"; shift 2 ;;
|
|
--width) width="$(next_arg "$@")"; shift 2 ;;
|
|
--height) height="$(next_arg "$@")"; shift 2 ;;
|
|
--ssim-threshold) ssim_threshold="$(next_arg "$@")"; shift 2 ;;
|
|
--crop-x) crop_x="$(next_arg "$@")"; shift 2 ;;
|
|
--crop-y) crop_y="$(next_arg "$@")"; shift 2 ;;
|
|
--crop-width) crop_width="$(next_arg "$@")"; shift 2 ;;
|
|
--crop-height) crop_height="$(next_arg "$@")"; shift 2 ;;
|
|
--use-pbuffer) use_pbuffer=1; shift 1 ;;
|
|
--avoid-angle-llvmpipe-sampler-mipmap-min-filter)
|
|
avoid_angle_llvmpipe_sampler_mipmap_min_filter=1
|
|
shift 1
|
|
;;
|
|
--avoid-angle-llvmpipe-explicit-lod-bias)
|
|
avoid_angle_llvmpipe_explicit_lod_bias=1
|
|
shift 1
|
|
;;
|
|
--coherent-as-flush) coherent_as_flush=1; shift 1 ;;
|
|
--dump-texture-2d) texture_2d_dumps="$(next_arg "$@")"; shift 2 ;;
|
|
--env) env_overrides="$(next_arg "$@")"; shift 2 ;;
|
|
--require-inproc) require_inproc=1; shift 1 ;;
|
|
--require-spawn) require_spawn=1; shift 1 ;;
|
|
--benchmark) benchmark=1; shift 1 ;;
|
|
--benchmark-tail-frames) benchmark_tail_frames="$(next_arg "$@")"; shift 2 ;;
|
|
--benchmark-finish) benchmark_finish="$(next_arg "$@")"; shift 2 ;;
|
|
--reuse-fixture) reuse_fixture=1; shift 1 ;;
|
|
--timeout-seconds) timeout_seconds="$(next_arg "$@")"; shift 2 ;;
|
|
-h|--help) usage; exit 0 ;;
|
|
*) die "unknown argument: $1" ;;
|
|
esac
|
|
done
|
|
|
|
require_value "${apk_file}" "--apk-file"
|
|
require_value "${package_name}" "--package"
|
|
require_value "${backend}" "--backend"
|
|
require_value "${result_root}" "--result-root"
|
|
require_value "${fixture_root}" "--fixture-root"
|
|
require_value "${case_name}" "--case"
|
|
require_value "${trace_archive}" "--trace-archive"
|
|
require_value "${trace_file}" "--trace-file"
|
|
require_value "${golden_path}" "--golden"
|
|
require_value "${target_call}" "--target-call"
|
|
require_value "${width}" "--width"
|
|
require_value "${height}" "--height"
|
|
require_value "${ssim_threshold}" "--ssim-threshold"
|
|
require_value "${crop_x}" "--crop-x"
|
|
require_value "${crop_y}" "--crop-y"
|
|
require_value "${crop_width}" "--crop-width"
|
|
require_value "${crop_height}" "--crop-height"
|
|
require_value "${timeout_seconds}" "--timeout-seconds"
|
|
|
|
test -f "${apk_file}" || die "APK does not exist: ${apk_file}"
|
|
test -f "${trace_archive}" || die "trace archive does not exist: ${trace_archive}"
|
|
test -f "${golden_path}" || die "golden image does not exist: ${golden_path}"
|
|
if [ -n "${alternate_golden_path}" ]; then
|
|
test -f "${alternate_golden_path}" || die "alternate golden image does not exist: ${alternate_golden_path}"
|
|
fi
|
|
safe_case="$(printf '%s' "${case_name}" | sed 's/[^A-Za-z0-9._-]/_/g')"
|
|
app_dir="/data/user/0/${package_name}/files/trace-replay"
|
|
|
|
collect_run_diagnostics() {
|
|
diagnostics_dir="$1"
|
|
mkdir -p "${diagnostics_dir}"
|
|
adb_state="$(adb_device_path get-state 2>/dev/null | tr -d '\r' || true)"
|
|
printf '%s\n' "${adb_state}" > "${diagnostics_dir}/adb-state.txt"
|
|
: > "${diagnostics_dir}/logcat.txt"
|
|
if [ "${adb_state}" != "device" ]; then
|
|
return
|
|
fi
|
|
# Depth matters, not just content: is_infrastructure_failure below decides "the emulator
|
|
# broke, retry" by finding a system_server crash in this window, and MobileGL logs into the
|
|
# same buffer under its own tag. A tail that is too short lets routine MobileGL output evict
|
|
# the crash line and charges an infrastructure fault to the trace under test.
|
|
"${ADB}" logcat -d -t 20000 > "${diagnostics_dir}/logcat.txt" || true
|
|
adb_device_path shell pidof "${package_name}" > "${diagnostics_dir}/pidof.txt" 2>&1 || true
|
|
adb_device_path shell dumpsys activity activities > "${diagnostics_dir}/activity.txt" 2>&1 || true
|
|
adb_device_path shell run-as "${package_name}" ls -laR "${app_dir}" > "${diagnostics_dir}/app-files.txt" 2>&1 || true
|
|
adb_device_path exec-out run-as "${package_name}" cat "${app_dir}/output/retrace.log" > "${diagnostics_dir}/retrace.log" || true
|
|
collect_role_logs "${app_dir}/output/mobilegl.log" "${diagnostics_dir}/mobilegl.log" || true
|
|
}
|
|
|
|
# Records why a retrace was charged to the infrastructure rather than the code
|
|
# under test, so the workflow can count the classes it retried.
|
|
record_infrastructure_reason() {
|
|
printf '%s\n' "$1" >> "${result_root}/infrastructure-failure-reason.txt"
|
|
}
|
|
|
|
# True when the replay never got a usable window surface out of ANGLE. EGL
|
|
# 0x300b is EGL_BAD_NATIVE_WINDOW and -1000000001 is VK_ERROR_SURFACE_LOST_KHR,
|
|
# which ANGLE reports out of vkCreateAndroidSurfaceKHR when the Activity's
|
|
# native window is not usable. Observed intermittently on cases that pass in
|
|
# every other run, so it is an environment fault, not a property of a trace.
|
|
is_angle_surface_lost() {
|
|
diagnostics_dir="$1"
|
|
retrace_log="${diagnostics_dir}/retrace.log"
|
|
mobilegl_log="${diagnostics_dir}/mobilegl.log"
|
|
|
|
if [ ! -s "${retrace_log}" ]; then
|
|
return 1
|
|
fi
|
|
if ! grep -Eq 'EGL surface creation failed: 0x300b|Vulkan error -1000000001|VK_ERROR_SURFACE_LOST_KHR' \
|
|
"${retrace_log}"; then
|
|
return 1
|
|
fi
|
|
# Co-signature, and the reason this cannot swallow a real regression: a lost
|
|
# surface at startup stops MobileGL at init, before it ever runs the capability
|
|
# probe. If the probe ran, the replay had a working context and lost it later -
|
|
# that is a genuine defect and must stay a failure.
|
|
if [ -s "${mobilegl_log}" ] && grep -q 'OpenGL ES capabilities:' "${mobilegl_log}"; then
|
|
return 1
|
|
fi
|
|
return 0
|
|
}
|
|
|
|
is_infrastructure_failure() {
|
|
diagnostics_dir="$1"
|
|
adb_state="$(cat "${diagnostics_dir}/adb-state.txt" 2>/dev/null || true)"
|
|
if [ "${adb_state}" != "device" ]; then
|
|
echo "trace-replay-ci.sh: Android device is unavailable (state: ${adb_state:-unknown})" >&2
|
|
record_infrastructure_reason "device-unavailable"
|
|
return 0
|
|
fi
|
|
if grep -Eq 'Fatal signal [0-9]+.*[(]system_server[)]|F system_server[ :]' "${diagnostics_dir}/logcat.txt"; then
|
|
echo "trace-replay-ci.sh: Android system_server crashed during retrace" >&2
|
|
record_infrastructure_reason "system-server-crash"
|
|
return 0
|
|
fi
|
|
if is_angle_surface_lost "${diagnostics_dir}"; then
|
|
echo "trace-replay-ci.sh: ANGLE could not create its window surface (EGL_BAD_NATIVE_WINDOW / VK_ERROR_SURFACE_LOST_KHR) before MobileGL finished init" >&2
|
|
record_infrastructure_reason "angle-surface-lost"
|
|
return 0
|
|
fi
|
|
return 1
|
|
}
|
|
|
|
copy_app_artifact() {
|
|
source_path="$1"
|
|
destination_path="$2"
|
|
if ! adb_device_path exec-out run-as "${package_name}" cat "${source_path}" > "${destination_path}"; then
|
|
echo "trace-replay-ci.sh: warning: failed to copy ${source_path}" >&2
|
|
rm -f "${destination_path}"
|
|
fi
|
|
}
|
|
|
|
# P6: the library writes ONE LOG PER ROLE - <base>.client.log and <base>.server.log - because
|
|
# under inproc both roles are threads of one process. Pull both and concatenate into the single
|
|
# <dest> every downstream reader still expects: the client-only markers (ConfigLoader's transport
|
|
# line, `spawn ARMED`, the client Config: IPC line) are present, and the Fatal census and the
|
|
# capabilities probe see BOTH roles - the applier's refusals and its GL_RENDERER line live on the
|
|
# server side. The two source files are also kept beside <dest> for a human reading the artifact.
|
|
collect_role_logs() {
|
|
base_source="$1" # e.g. <app_dir>/output/mobilegl.log
|
|
dest="$2" # e.g. <result_dir>/mobilegl.log
|
|
base_no_ext="${base_source%.log}"
|
|
dest_no_ext="${dest%.log}"
|
|
: > "${dest}"
|
|
wrote_any=0
|
|
for role in client server; do
|
|
role_src="${base_no_ext}.${role}.log"
|
|
role_dst="${dest_no_ext}.${role}.log"
|
|
# PULL, THEN JUDGE BY CONTENT. `run-as test -f` is unreliable through `exec-out` on some
|
|
# devices (measured: it returned 0 for a file that does not exist), and `exec-out` folds the
|
|
# device-side `cat: ... No such file` error into the stdout stream - so a missing role file
|
|
# arrives as a one-line log that begins with `cat:`. The monolith arm legitimately has no
|
|
# server file, and that must be a silent skip rather than a one-line server log. So: pull,
|
|
# then drop anything empty or carrying cat's own not-found line.
|
|
adb_device_path exec-out run-as "${package_name}" cat "${role_src}" > "${role_dst}" 2>/dev/null || true
|
|
if [ -s "${role_dst}" ] && ! head -1 "${role_dst}" | grep -q '^cat: .*: No such file'; then
|
|
cat "${role_dst}" >> "${dest}"
|
|
wrote_any=1
|
|
else
|
|
rm -f "${role_dst}"
|
|
fi
|
|
done
|
|
[ "${wrote_any}" -eq 1 ] || rm -f "${dest}"
|
|
}
|
|
|
|
copy_texture_2d_dumps() {
|
|
[ -n "${texture_2d_dumps}" ] || return 0
|
|
saved_ifs="${IFS}"
|
|
IFS=';'
|
|
set -- ${texture_2d_dumps}
|
|
IFS="${saved_ifs}"
|
|
for dump_point in "$@"; do
|
|
dump_dir="${dump_point#*,}"
|
|
dump_dir="${dump_dir#*,}"
|
|
dump_dir="${dump_dir#*,}"
|
|
[ -n "${dump_dir}" ] || continue
|
|
dump_name="$(basename "${dump_dir}")"
|
|
destination_dir="${result_dir}/${dump_name}"
|
|
mkdir -p "${destination_dir}"
|
|
if ! adb_device_path exec-out run-as "${package_name}" tar -C "${dump_dir}" -cf - . | tar -xf - -C "${destination_dir}"; then
|
|
echo "trace-replay-ci.sh: warning: failed to copy texture dump ${dump_dir}" >&2
|
|
rm -rf "${destination_dir}"
|
|
fi
|
|
done
|
|
}
|
|
|
|
prepare_fixture() {
|
|
fixture_dir="${fixture_root}/${safe_case}"
|
|
rm -rf "${fixture_dir}"
|
|
mkdir -p "${fixture_dir}"
|
|
tar -xzf "${trace_archive}" -C "${fixture_dir}"
|
|
|
|
extracted_trace="${fixture_dir}/${trace_file}"
|
|
test -f "${extracted_trace}" || die "trace file not found in archive: ${trace_file}"
|
|
|
|
adb_device_path push "$(host_path_for_adb "${extracted_trace}")" "/data/local/tmp/mobilegl-${safe_case}.trace"
|
|
adb_device_path push "$(host_path_for_adb "${golden_path}")" "/data/local/tmp/mobilegl-${safe_case}.golden.png"
|
|
if [ -n "${alternate_golden_path}" ]; then
|
|
adb_device_path push "$(host_path_for_adb "${alternate_golden_path}")" "/data/local/tmp/mobilegl-${safe_case}.alternate-golden.png"
|
|
fi
|
|
adb_device_path shell chmod 0644 "/data/local/tmp/mobilegl-${safe_case}.trace" "/data/local/tmp/mobilegl-${safe_case}.golden.png"
|
|
if [ -n "${alternate_golden_path}" ]; then
|
|
adb_device_path shell chmod 0644 "/data/local/tmp/mobilegl-${safe_case}.alternate-golden.png"
|
|
fi
|
|
}
|
|
|
|
copy_fixture_to_app() {
|
|
trace_tmp="/data/local/tmp/mobilegl-${safe_case}.trace"
|
|
golden_tmp="/data/local/tmp/mobilegl-${safe_case}.golden.png"
|
|
alternate_golden_tmp="/data/local/tmp/mobilegl-${safe_case}.alternate-golden.png"
|
|
|
|
adb_device_path shell run-as "${package_name}" rm -rf "${app_dir}"
|
|
adb_device_path shell run-as "${package_name}" mkdir -p "${app_dir}/input" "${app_dir}/output"
|
|
adb_device_path shell run-as "${package_name}" cp "${trace_tmp}" "${app_dir}/input/trace.trace"
|
|
adb_device_path shell run-as "${package_name}" cp "${golden_tmp}" "${app_dir}/input/golden.png"
|
|
if [ -n "${alternate_golden_path}" ]; then
|
|
adb_device_path shell run-as "${package_name}" cp "${alternate_golden_tmp}" "${app_dir}/input/alternate-golden.png"
|
|
fi
|
|
}
|
|
|
|
run_retrace() {
|
|
result_dir="${result_root}/${safe_case}-${backend}"
|
|
alternate_golden_app_path=""
|
|
use_angle=0
|
|
if [ -n "${alternate_golden_path}" ]; then
|
|
alternate_golden_app_path="${app_dir}/input/alternate-golden.png"
|
|
fi
|
|
if [ "${MOBILEGL_ESPRYT_USE_ANGLE:-}" = "1" ] && [ "${backend}" = "DirectGLES" ]; then
|
|
use_angle=1
|
|
test -n "${MOBILEGL_TRACE_ANGLE_VARIANT:-}" || die "MOBILEGL_TRACE_ANGLE_VARIANT is required for DirectGLES ANGLE replay"
|
|
fi
|
|
if [ "${MOBILEGL_RETRACE_USE_PBUFFER:-}" = "1" ]; then
|
|
use_pbuffer=1
|
|
fi
|
|
|
|
mkdir -p "${result_dir}"
|
|
# A repeat run of a case the previous invocation already installed and pushed only needs
|
|
# the on-device copy back into a fresh app output directory.
|
|
# MOBILEGL_TRACE_SKIP_INSTALL=1: the caller installed the APK itself (ColorOS shows an install-confirmation
|
|
# dialog whose tap drops adb for a few seconds, so the install has to be done and settled outside a run).
|
|
if [ "${reuse_fixture}" -eq 0 ] && [ "${MOBILEGL_TRACE_SKIP_INSTALL:-0}" != "1" ]; then
|
|
"${ADB}" install -r "$(host_path_for_adb "${apk_file}")"
|
|
fi
|
|
copy_fixture_to_app
|
|
adb_device_path shell am force-stop "${package_name}"
|
|
"${ADB}" logcat -c
|
|
set -- am start -a top.mobilegl.plugin.TRACE_REPLAY \
|
|
-n "${package_name}/top.mobilegl.plugin.trace.TraceReplayActivity" \
|
|
--es trace_path "${app_dir}/input/trace.trace" \
|
|
--es golden_path "${app_dir}/input/golden.png"
|
|
if [ -n "${alternate_golden_app_path}" ]; then
|
|
set -- "$@" --es alternate_golden_path "${alternate_golden_app_path}"
|
|
fi
|
|
if [ "${use_angle}" -eq 1 ]; then
|
|
set -- "$@" --ez use_angle true
|
|
set -- "$@" --es angle_variant "${MOBILEGL_TRACE_ANGLE_VARIANT}"
|
|
fi
|
|
# PBUFFER IS A SURFACE SHAPE, NOT A BACKEND PROPERTY, and the DirectGLES condition that used to
|
|
# guard this line made it one. It was harmless while the only caller was the ANGLE lane; P6 needs
|
|
# it on BOTH backends, because until P12 the spawn arm can only use pbuffer/surfaceless - an
|
|
# ANativeWindow* is a pointer into the CLIENT's process and SetWindowHandle is refused by name
|
|
# with Fatal{UnmigratedSurface, "AndroidNativeWindow@P12"} on the way across. Magma creates an
|
|
# EGL pbuffer exactly as Espryt does.
|
|
if [ "${use_pbuffer}" -eq 1 ]; then
|
|
set -- "$@" --ez use_pbuffer true
|
|
fi
|
|
if [ "${avoid_angle_llvmpipe_sampler_mipmap_min_filter}" -eq 1 ] && [ "${backend}" = "DirectGLES" ]; then
|
|
set -- "$@" --ez avoid_angle_llvmpipe_sampler_mipmap_min_filter true
|
|
fi
|
|
if [ "${avoid_angle_llvmpipe_explicit_lod_bias}" -eq 1 ] && [ "${backend}" = "DirectGLES" ]; then
|
|
set -- "$@" --ez avoid_angle_llvmpipe_explicit_lod_bias true
|
|
fi
|
|
if [ "${coherent_as_flush}" -eq 1 ]; then
|
|
set -- "$@" --ez coherent_as_flush true
|
|
fi
|
|
if [ "${MOBILEGL_MAGMA_FIX_ITERATIONRP_SUBGROUP_SCRATCH:-}" = "1" ]; then
|
|
set -- "$@" --ez fix_iterationrp_subgroup_scratch true
|
|
fi
|
|
if [ "${MOBILEGL_MAGMA_DERIVE_NUM_SUBGROUPS:-}" = "1" ]; then
|
|
set -- "$@" --ez derive_num_subgroups true
|
|
fi
|
|
if [ "${MOBILEGL_MAGMA_ITERATIONRP_FIX_BARRIER:-}" = "1" ]; then
|
|
set -- "$@" --ez iterationrp_fix_barrier true
|
|
fi
|
|
if [ -n "${texture_2d_dumps}" ]; then
|
|
set -- "$@" --es texture_2d_dumps "${texture_2d_dumps}"
|
|
fi
|
|
if [ -n "${env_overrides}" ]; then
|
|
# adb joins the argv with spaces and hands the result to the device shell, so a value
|
|
# holding the ';' that separates entries would otherwise be read there as a command
|
|
# separator. The single quotes make it one token again.
|
|
set -- "$@" --es mobilegl_env "'${env_overrides}'"
|
|
fi
|
|
if [ "${benchmark}" -eq 1 ]; then
|
|
set -- "$@" --ez benchmark true
|
|
set -- "$@" --ei benchmark_tail_frames "${benchmark_tail_frames}"
|
|
set -- "$@" --es benchmark_result_path "${app_dir}/output/benchmark.json"
|
|
if [ "${benchmark_finish}" = "0" ]; then
|
|
set -- "$@" --ez benchmark_finish false
|
|
else
|
|
set -- "$@" --ez benchmark_finish true
|
|
fi
|
|
fi
|
|
set -- "$@" \
|
|
--es output_dir "${app_dir}/output" \
|
|
--es diff_path "${app_dir}/output/${safe_case}-diff.png" \
|
|
--es backend "${backend}" \
|
|
--el target_call "${target_call}" \
|
|
--ei width "${width}" \
|
|
--ei height "${height}" \
|
|
--es ssim_threshold "${ssim_threshold}" \
|
|
--ei crop_x "${crop_x}" \
|
|
--ei crop_y "${crop_y}" \
|
|
--ei crop_width "${crop_width}" \
|
|
--ei crop_height "${crop_height}"
|
|
adb_device_path shell "$@"
|
|
|
|
app_exited=0
|
|
saw_app_process=0
|
|
for _ in $(seq 1 "${timeout_seconds}"); do
|
|
if adb_device_path shell run-as "${package_name}" ls "${app_dir}/output/result.json" >/dev/null 2>&1; then
|
|
break
|
|
fi
|
|
if adb_device_path shell pidof "${package_name}" >/dev/null 2>&1; then
|
|
saw_app_process=1
|
|
elif [ "${saw_app_process}" -eq 1 ]; then
|
|
app_exited=1
|
|
break
|
|
fi
|
|
sleep 1
|
|
done
|
|
|
|
collect_run_diagnostics "${result_dir}"
|
|
if ! adb_device_path shell run-as "${package_name}" ls "${app_dir}/output/result.json" >/dev/null 2>&1; then
|
|
if [ "${app_exited}" -eq 1 ]; then
|
|
echo "trace-replay-ci.sh: app process exited before result.json was created" >&2
|
|
else
|
|
echo "trace-replay-ci.sh: result.json was not created after ${timeout_seconds}s" >&2
|
|
fi
|
|
if [ -s "${result_dir}/retrace.log" ]; then
|
|
echo "trace-replay-ci.sh: retrace.log:" >&2
|
|
cat "${result_dir}/retrace.log" >&2
|
|
fi
|
|
if [ -s "${result_dir}/mobilegl.log" ]; then
|
|
echo "trace-replay-ci.sh: tail of mobilegl.log:" >&2
|
|
tail -200 "${result_dir}/mobilegl.log" >&2
|
|
fi
|
|
echo "trace-replay-ci.sh: recent relevant logcat lines:" >&2
|
|
grep -E 'MobileGLTraceRunner|AndroidRuntime|FATAL EXCEPTION|trace_replay|MobileGL|libc' "${result_dir}/logcat.txt" | tail -200 >&2 || true
|
|
echo "trace-replay-ci.sh: app trace-replay files:" >&2
|
|
cat "${result_dir}/app-files.txt" >&2 || true
|
|
if is_infrastructure_failure "${result_dir}"; then
|
|
echo "trace-replay-ci.sh: requesting one infrastructure retry" >&2
|
|
exit "${INFRASTRUCTURE_FAILURE_EXIT_CODE}"
|
|
fi
|
|
exit 1
|
|
fi
|
|
adb_device_path exec-out run-as "${package_name}" cat "${app_dir}/output/result.json" > "${result_dir}/result.json"
|
|
cat "${result_dir}/result.json"
|
|
# A benchmark run takes no snapshot, so there is no actual/diff pair to copy.
|
|
if [ "${benchmark}" -eq 0 ]; then
|
|
copy_app_artifact "${app_dir}/output/actual.png" "${result_dir}/${safe_case}-${backend}-actual.png"
|
|
copy_app_artifact "${app_dir}/output/${safe_case}-diff.png" "${result_dir}/${safe_case}-${backend}-diff.png"
|
|
fi
|
|
copy_app_artifact "${app_dir}/output/retrace.log" "${result_dir}/retrace.log"
|
|
collect_role_logs "${app_dir}/output/mobilegl.log" "${result_dir}/mobilegl.log"
|
|
if [ "${benchmark}" -eq 1 ]; then
|
|
copy_app_artifact "${app_dir}/output/benchmark.json" "${result_dir}/benchmark.json"
|
|
fi
|
|
copy_texture_2d_dumps
|
|
|
|
# A replay that wrote result.json but did not pass used to print nothing but
|
|
# the JSON, which for a non-zero statusCode says only "retrace failed with
|
|
# status N". The logs that say why are already on disk here, so echo their
|
|
# tails the same way the missing-result.json path does; the job log is the one
|
|
# place a failure stays readable after the result artifact expires.
|
|
if ! grep -q '"passed"[[:space:]]*:[[:space:]]*true' "${result_dir}/result.json"; then
|
|
if [ -s "${result_dir}/retrace.log" ]; then
|
|
echo "trace-replay-ci.sh: tail of retrace.log:" >&2
|
|
tail -200 "${result_dir}/retrace.log" >&2
|
|
fi
|
|
if [ -s "${result_dir}/mobilegl.log" ]; then
|
|
echo "trace-replay-ci.sh: tail of mobilegl.log:" >&2
|
|
tail -200 "${result_dir}/mobilegl.log" >&2
|
|
fi
|
|
# A replay that writes result.json still reaches here on an environment
|
|
# fault: ANGLE failing to make a window surface reports statusCode 5 rather
|
|
# than dying, so it never hit the missing-result.json branch above and used
|
|
# to be charged to the trace.
|
|
if is_infrastructure_failure "${result_dir}"; then
|
|
echo "trace-replay-ci.sh: requesting one infrastructure retry" >&2
|
|
exit "${INFRASTRUCTURE_FAILURE_EXIT_CODE}"
|
|
fi
|
|
fi
|
|
|
|
"${PYTHON}" -c 'import json, sys; result = json.load(open(sys.argv[1], encoding="utf-8")); sys.exit(0 if result.get("passed") else f"trace replay failed: {result}")' "${result_dir}/result.json" || return "$?"
|
|
if [ "${require_inproc}" -eq 1 ]; then
|
|
"${PYTHON}" - "${result_dir}/mobilegl.log" "${result_dir}/transport-proof.json" <<'PY'
|
|
import json
|
|
from pathlib import Path
|
|
import re
|
|
import sys
|
|
|
|
log_path, proof_path = map(Path, sys.argv[1:])
|
|
text = log_path.read_text(encoding="utf-8", errors="replace") if log_path.is_file() else ""
|
|
# ConfigLoader's InProcess arm emits this sentence only after selecting the
|
|
# compiled transport. "Accepted env variable: MOBILEGL_TRANSPORT=inproc" is not it.
|
|
marker = "Config: MOBILEGL_TRANSPORT=inproc - the MGPipe record stream"
|
|
configs = re.findall(r"Config: IPC[^\r\n]*", text)
|
|
fatals = re.findall(r"^.*Fatal\{.*$", text, re.MULTILINE)
|
|
required = {"strict": "1", "role-split-state": "1", "run-ahead": "1"}
|
|
config_ok = bool(configs) and all(
|
|
all(re.search(r"\b" + re.escape(key) + "=" + value + r"\b", line) for key, value in required.items())
|
|
for line in configs
|
|
)
|
|
passed = marker in text and config_ok and not fatals
|
|
proof = {"required_transport": "inproc", "library_log": str(log_path),
|
|
"transport_resolution_marker": marker in text, "ipc_config_lines": configs,
|
|
"required_ipc_settings": required, "ipc_settings_match": config_ok,
|
|
"fatal_count": len(fatals), "fatal_lines": fatals, "passed": passed}
|
|
proof_path.write_text(json.dumps(proof, indent=2), encoding="utf-8")
|
|
if not passed:
|
|
sys.exit("trace replay failed actual inproc/strict/role/zero-Fatal proof: " + json.dumps(proof))
|
|
print("Android retrace: real inproc transport, strict role state and zero Fatal records confirmed")
|
|
PY
|
|
fi
|
|
if [ "${require_spawn}" -eq 1 ]; then
|
|
"${PYTHON}" - "${result_dir}/mobilegl.log" "${result_dir}/transport-proof.json" <<'PY'
|
|
import json
|
|
from pathlib import Path
|
|
import re
|
|
import sys
|
|
|
|
log_path, proof_path = map(Path, sys.argv[1:])
|
|
text = log_path.read_text(encoding="utf-8", errors="replace") if log_path.is_file() else ""
|
|
|
|
# TWO SENTENCES, AND THE SECOND IS THE ONE THAT MATTERS.
|
|
#
|
|
# ConfigLoader's marker proves the VALUE RESOLVED - it exists only in ConfigLoader's Spawn arm,
|
|
# which exists only under MOBILEGL_BUILD_DISAGGREGATED, so a pull library cannot write it. That
|
|
# is a statement about a parser.
|
|
#
|
|
# `spawn ARMED - the server role runs in pid N` is written by ClientSession::StartSpawned only
|
|
# after the launch, the connect and the handshake have ALL succeeded, and the pid in it is the
|
|
# SERVER's. It is the only line in this log a same-process run cannot produce: inproc resolves
|
|
# its own marker while running the server role on a thread HERE. Requiring only the first would
|
|
# accept a session that resolved spawn and then never reached another process.
|
|
marker = "Config: MOBILEGL_TRANSPORT=spawn - the MGPipe record stream"
|
|
armed = re.search(r"spawn ARMED - the server role runs in pid (\d+)", text)
|
|
|
|
# `any`, NOT the `all` the inproc gate uses, and the difference is load-bearing.
|
|
#
|
|
# This log is the CONCATENATION of the two role files (collect_role_logs), so it carries the
|
|
# SERVER's own `Config: IPC` line as well as the client's - and the server's reads strict=0
|
|
# role-split-state=0 by construction, because the launcher scrubs every MOBILEGL_IPC_* out of
|
|
# the child's environment (anti-recursion catch (b)). Demanding that EVERY line match would red
|
|
# every spawn run for the one thing the design requires; `any` asks that the CLIENT's line is
|
|
# present, which is the one that carries the knobs.
|
|
configs = re.findall(r"Config: IPC[^\r\n]*", text)
|
|
fatals = re.findall(r"^.*Fatal\{.*$", text, re.MULTILINE)
|
|
required = {"strict": "1", "role-split-state": "1", "run-ahead": "1"}
|
|
def matches(line):
|
|
return all(re.search(r"\b" + re.escape(key) + "=" + value + r"\b", line)
|
|
for key, value in required.items())
|
|
client_configs = [line for line in configs if matches(line)]
|
|
config_ok = bool(client_configs)
|
|
|
|
passed = marker in text and armed is not None and config_ok and not fatals
|
|
proof = {"required_transport": "spawn", "library_log": str(log_path),
|
|
"transport_resolution_marker": marker in text,
|
|
"server_pid": int(armed.group(1)) if armed else None,
|
|
"ipc_config_lines": configs, "required_ipc_settings": required,
|
|
"client_ipc_line_present": config_ok,
|
|
"fatal_count": len(fatals), "fatal_lines": fatals, "passed": passed}
|
|
proof_path.write_text(json.dumps(proof, indent=2), encoding="utf-8")
|
|
if not passed:
|
|
sys.exit("trace replay failed actual spawn/second-process/zero-Fatal proof: " + json.dumps(proof))
|
|
print("Android retrace: real spawn transport, server role in pid "
|
|
f"{proof['server_pid']}, and zero Fatal records confirmed")
|
|
PY
|
|
fi
|
|
}
|
|
|
|
mkdir -p "${fixture_root}" "${result_root}"
|
|
if [ "${reuse_fixture}" -eq 0 ]; then
|
|
prepare_fixture
|
|
fi
|
|
|
|
run_retrace
|