Files
MobileGL/MobileGL/MG_State/GLState/TextureState/MipmapStorage.cpp
T
BZLZHH 7db5b35a3e [Perf] (MG_State): remember every dirty rect, not just their union
A Minecraft frame updates ~95 scattered 16x16 sprites in a 1024x512
atlas; MipmapStorage's single union dirty box turned ~95KB of changed
texels into a ~2MB upload on every backend. The storage now keeps a
bounded (96-slot) list of pairwise-disjoint dirty rects BEHIND the
untouched union box: rects cascade-merge on touch or overlap, overflow
folds the pair with minimum enlargement and re-cascades, whole-level
dirties and respecifies just clear the list (empty list = "union box
tells all"). GetDirtyRects hands the list out only when it has 2+
rects, fits the caller's capacity, and its summed area is under 75% of
the union box - fewer driver calls beat equal bytes - so consumers can
never stage more than the union box did.

The list is maintained inside the same four mutation funnels every
texel writer already goes through (MarkDirty, MarkDirtyRegion,
AllocateLevel, TruncateToLevelCount - callers enumerated at the
declaration), so list and union box cannot disagree. Backends OPT IN:
the union-box API and its update order are byte-identical, and an
unmodified backend keeps rendering exactly as before.

96 slots is measured, not guessed: on the bench's 95-sprite lattice a
16-slot list collapses to >93% of the union box, 96 slots reach 4.8%
(~2MB -> ~95KB staged per frame). Verified by a 2859-check fuzz run
against a reference dirty bitmap (union exactness, full coverage,
disjointness, bounds, profitability). Unit tests 421/421.
2026-08-06 20:17:19 -04:00

301 lines
16 KiB
C++

// MobileGL - MobileGL/MG_State/GLState/TextureState/MipmapStorage.cpp
// Copyright (c) 2025-2026 MobileGL-Dev
// Licensed under the GNU Lesser General Public License v3.0:
// https://www.gnu.org/licenses/gpl-3.0.txt
// https://www.gnu.org/licenses/lgpl-3.0.txt
// SPDX-License-Identifier: LGPL-3.0-only
// End of Source File Header
#include "MipmapStorage.h"
namespace MobileGL {
namespace MG_State {
namespace GLState {
namespace {
// Overlapping OR abutting ([lo, hi) intervals meeting edge-to-edge) in
// every axis: merging abutting boxes keeps scanline/tile write patterns
// as one rect instead of a picket fence.
Bool RegionsTouch(const MipmapDirtyRegion& a, const MipmapDirtyRegion& b) {
return a.lo.x() <= b.hi.x() && b.lo.x() <= a.hi.x() && a.lo.y() <= b.hi.y() &&
b.lo.y() <= a.hi.y() && a.lo.z() <= b.hi.z() && b.lo.z() <= a.hi.z();
}
MipmapDirtyRegion RegionUnion(const MipmapDirtyRegion& a, const MipmapDirtyRegion& b) {
return {IntVec3{std::min(a.lo.x(), b.lo.x()), std::min(a.lo.y(), b.lo.y()),
std::min(a.lo.z(), b.lo.z())},
IntVec3{std::max(a.hi.x(), b.hi.x()), std::max(a.hi.y(), b.hi.y()),
std::max(a.hi.z(), b.hi.z())}};
}
} // namespace
SizeT MipmapStorage::GetLevelCount() const {
return m_data.size();
}
void MipmapStorage::AllocateLevel(Uint level, MipmapInput input) {
// Grow only. GL respecifies exactly the level it is handed, so allocating level 0
// must not disturb the levels above it - but resize() shrinks as readily as it
// grows, so this used to truncate the whole chain to a single level. Callers that
// genuinely redefine the complete level set say so with TruncateToLevelCount.
const SizeT requiredLevelCount = static_cast<SizeT>(level) + 1;
if (m_data.size() < requiredLevelCount) {
m_data.reserve(std::bit_ceil(requiredLevelCount));
m_data.resize(requiredLevelCount);
m_texelSizes.reserve(std::bit_ceil(requiredLevelCount));
m_texelSizes.resize(requiredLevelCount);
m_isDirty.resize(requiredLevelCount, false);
m_dirtyRegions.resize(requiredLevelCount);
m_dirtyRects.resize(requiredLevelCount);
m_compressedData.resize(requiredLevelCount);
m_compressedFormats.resize(requiredLevelCount, GL_NONE);
}
m_texelSizes[level] = input.texelSize;
// A respecified level invalidates any pending sub-region: its extents were
// measured against the old size. If the level is still flagged dirty the
// pending upload widens to the whole (new) level.
if (level < m_dirtyRegions.size()) {
m_dirtyRegions[level] =
m_isDirty[level]
? MipmapDirtyRegion{IntVec3{0, 0, 0},
IntVec3{input.texelSize.x(), input.texelSize.y(),
std::max(input.texelSize.z(), 1)}}
: MipmapDirtyRegion{};
}
// The rect list mirrors the union box's reset: whatever rects were
// pending measured the OLD extents. Empty list = union box tells all.
if (level < m_dirtyRects.size()) {
m_dirtyRects[level].clear();
}
auto& data = m_data[level];
data.resize(input.byteSize, 0);
// Respecifying a level drops whatever compressed image it used to hold. Without this,
// a glTexImage2D or glTexStorage2D over a level a previous glCompressedTexImage2D had
// shadowed would leave GL_TEXTURE_COMPRESSED answering true and glGetCompressedTexImage
// handing back the stale blob. Every allocation path funnels through here, so clearing
// once covers all of them; the compressed path re-arms the tag immediately afterwards
// via SetCompressedImage.
m_compressedFormats[level] = GL_NONE;
m_compressedData[level].clear();
m_compressedData[level].shrink_to_fit();
}
void MipmapStorage::SetCompressedImage(Uint level, GLenum internalFormat, const void* data, SizeT size) {
MOBILEGL_ASSERT(level < m_compressedData.size(), "SetCompressedImage: level out of range");
m_compressedFormats[level] = internalFormat;
auto& blob = m_compressedData[level];
// Zero-filled when data is null: glCompressedTexImage* with a null pointer defines the
// level's size and format but leaves its contents undefined, and zeros are the one
// reproducible answer a later glGetCompressedTexImage can give.
blob.assign(size, 0);
if (data != nullptr && size > 0) {
Memcpy(blob.data(), data, size);
}
}
GLenum MipmapStorage::GetCompressedFormat(Uint level) const {
if (level >= m_compressedFormats.size()) return GL_NONE;
return m_compressedFormats[level];
}
SizeT MipmapStorage::GetCompressedByteSize(Uint level) const {
if (level >= m_compressedData.size()) return 0;
return m_compressedData[level].size();
}
const void* MipmapStorage::MapCompressedData(Uint level) const {
if (level >= m_compressedData.size()) return nullptr;
return m_compressedData[level].data();
}
void MipmapStorage::TruncateToLevelCount(SizeT levelCount) {
if (levelCount >= m_data.size()) return;
m_data.resize(levelCount);
m_texelSizes.resize(levelCount);
m_isDirty.resize(levelCount);
m_dirtyRegions.resize(levelCount);
m_dirtyRects.resize(levelCount);
m_compressedData.resize(levelCount);
m_compressedFormats.resize(levelCount);
}
void MipmapStorage::UpdateSubData(Uint level, DataPtr input) {
auto& targetData = m_data;
MOBILEGL_ASSERT(level < targetData.size(), "UpdateSubData: level out of range");
auto& levelData = targetData[level];
MOBILEGL_ASSERT(input.size <= levelData.size(), "UpdateSubData: input data larger than allocated");
if (input.data && input.size > 0) {
const Uint8* src = static_cast<const Uint8*>(input.data);
// Clamp so a size mismatch can never write past the allocation.
Memcpy(levelData.data(), src, std::min(input.size, levelData.size()));
MarkDirty(level, true); // whole-level write: dirty region covers everything
}
}
void* MipmapStorage::MapData(Uint level) {
auto& targetData = m_data;
MOBILEGL_ASSERT(level < targetData.size(), "UpdateSubData: level out of range");
auto& levelData = targetData[level];
return levelData.data();
}
IntVec3 MipmapStorage::GetTexelSize(Uint level) const {
auto& targetTexelSizes = m_texelSizes;
if (level >= targetTexelSizes.size()) return {0, 0, 0};
return targetTexelSizes[level];
}
SizeT MipmapStorage::GetByteSize(Uint level) const {
if (level >= m_data.size()) return 0;
return m_data[level].size();
}
void MipmapStorage::MarkDirty(Uint level, bool dirty) {
MOBILEGL_ASSERT(level < m_isDirty.size(), "MarkDirty: level out of range");
m_isDirty[level] = dirty;
if (level < m_dirtyRegions.size()) {
if (dirty) {
const IntVec3 size = level < m_texelSizes.size() ? m_texelSizes[level] : IntVec3{0, 0, 0};
m_dirtyRegions[level] = {IntVec3{0, 0, 0},
IntVec3{size.x(), size.y(), std::max(size.z(), 1)}};
} else {
m_dirtyRegions[level] = {};
}
}
// Both directions collapse the rect list to "just the union box": a
// whole-level dirty IS the union box, a clean level has nothing to say.
// clear() keeps the vector's capacity, so per-frame streaming levels
// allocate their slots once and reuse them.
if (level < m_dirtyRects.size()) {
m_dirtyRects[level].clear();
}
}
bool MipmapStorage::IsDirty(Uint level) const {
MOBILEGL_ASSERT(level < m_isDirty.size(), "IsDirty: level out of range");
return m_isDirty[level];
}
void MipmapStorage::MarkDirtyRegion(Uint level, IntVec3 offset, IntVec3 size) {
MOBILEGL_ASSERT(level < m_isDirty.size(), "MarkDirtyRegion: level out of range");
const IntVec3 levelSize = level < m_texelSizes.size() ? m_texelSizes[level] : IntVec3{0, 0, 0};
MipmapDirtyRegion incoming;
incoming.lo = {std::max(offset.x(), 0), std::max(offset.y(), 0), std::max(offset.z(), 0)};
incoming.hi = {std::min(offset.x() + size.x(), levelSize.x()),
std::min(offset.y() + size.y(), levelSize.y()),
std::min(offset.z() + std::max(size.z(), 1), std::max(levelSize.z(), 1))};
if (incoming.Empty()) return;
// Rect list first, while the union box still holds only the PREVIOUS
// writes: a level that is already dirty with an empty list is in the
// "union box tells all" resting state, so that box seeds the list
// before the incoming rect refines it.
if (level < m_dirtyRects.size()) {
auto& rects = m_dirtyRects[level];
if (!m_isDirty[level]) {
rects.clear(); // stale-safety; MarkDirty(false) already cleared it
} else if (rects.empty() && level < m_dirtyRegions.size() &&
!m_dirtyRegions[level].Empty()) {
rects.push_back(m_dirtyRegions[level]);
}
InsertDirtyRect(level, incoming);
}
if (level < m_dirtyRegions.size()) {
MipmapDirtyRegion& region = m_dirtyRegions[level];
if (m_isDirty[level] && !region.Empty()) {
region.lo = {std::min(region.lo.x(), incoming.lo.x()),
std::min(region.lo.y(), incoming.lo.y()),
std::min(region.lo.z(), incoming.lo.z())};
region.hi = {std::max(region.hi.x(), incoming.hi.x()),
std::max(region.hi.y(), incoming.hi.y()),
std::max(region.hi.z(), incoming.hi.z())};
} else {
region = incoming;
}
}
m_isDirty[level] = true;
}
void MipmapStorage::InsertDirtyRect(Uint level, MipmapDirtyRegion incoming) {
auto& rects = m_dirtyRects[level];
if (rects.capacity() < kMaxDirtyRects) {
rects.reserve(kMaxDirtyRects);
}
// Cascade-merge: absorb every rect the incoming touches. The absorbed
// union can reach rects a smaller box did not, so rescan until stable;
// every merge shrinks the list, so this terminates. Swap-with-back keeps
// removal O(1) - the list is unordered by design.
Bool merged = true;
while (merged) {
merged = false;
for (SizeT i = 0; i < rects.size(); ++i) {
if (RegionsTouch(rects[i], incoming)) {
incoming = RegionUnion(rects[i], incoming);
rects[i] = rects.back();
rects.pop_back();
merged = true;
break;
}
}
}
if (rects.size() < kMaxDirtyRects) {
rects.push_back(incoming);
return;
}
// Full: fold the incoming rect into the neighbour whose box grows least
// (least new area dragged into the upload), then re-insert the grown
// box - it may now touch others. The removal above guarantees the
// recursion appends on the second pass at the latest.
SizeT best = 0;
SizeT bestGrowth = ~static_cast<SizeT>(0);
for (SizeT i = 0; i < rects.size(); ++i) {
const SizeT growth = RegionUnion(rects[i], incoming).TexelCount() - rects[i].TexelCount();
if (growth < bestGrowth) {
bestGrowth = growth;
best = i;
}
}
incoming = RegionUnion(rects[best], incoming);
rects[best] = rects.back();
rects.pop_back();
InsertDirtyRect(level, incoming);
}
MipmapDirtyRegion MipmapStorage::GetDirtyRegion(Uint level) const {
if (level >= m_dirtyRegions.size()) return {};
return m_dirtyRegions[level];
}
SizeT MipmapStorage::GetDirtyRects(Uint level, MipmapDirtyRegion* outRects, SizeT maxRects) const {
if (outRects == nullptr || level >= m_dirtyRects.size() || level >= m_dirtyRegions.size()) {
return 0;
}
const auto& rects = m_dirtyRects[level];
// 0 or 1 rects: the union box already says exactly this. More than the
// caller can take: never truncate - a dropped rect is a dropped write.
if (rects.size() < 2 || rects.size() > maxRects) {
return 0;
}
// Total-bytes accounting: when the scattered rects add up to most of
// the union box anyway (>= 3/4), one driver call on the box beats many
// calls moving nearly the same bytes.
SizeT summedArea = 0;
for (const auto& rect : rects) {
summedArea += rect.TexelCount();
}
const SizeT unionArea = m_dirtyRegions[level].TexelCount();
if (summedArea * 4 >= unionArea * 3) {
return 0;
}
for (SizeT i = 0; i < rects.size(); ++i) {
outRects[i] = rects[i];
}
return rects.size();
}
} // namespace GLState
} // namespace MG_State
} // namespace MobileGL