9.2 KiB
Brief: p5c-audit — where the inproc split still reads the other role's memory
You are auditing the MobileGL disaggregation branch (feat/disaggregated, head a79a0af6), working tree = the current directory (C:\Users\geekerwan\AndroidStudioProjects\FoldCraftLauncher\MobileGL-disagg). This is a READ-ONLY audit: do not edit any repository file, do not run builds or tests, do not touch git (no commit/checkout/stash), do not touch any adb device, do not fetch git LFS. You may write scratch files only under C:/Users/GEEKER~1/AppData/Local/Temp/claude/C--Users-geekerwan-AndroidStudioProjects-FoldCraftLauncher-MobileGL-disagg/0614b2e9-9ce2-49e4-a44c-6d023a133184/scratchpad/. If you need Linux tooling, run it as wsl.exe -d Arch -- bash -lc "<cmd>"; the same tree is checked out at ~/w7/pipe inside that distro (also at a79a0af6), and the notes/evidence directories are ~/w7/notes/ — read-only for you as well.
The question
MGPipe splits the GL frontend (client role, the application's GL thread) from the backend (server role, the mgl-srv-apply thread). Under MOBILEGL_TRANSPORT=inproc (build flavour -DMOBILEGL_PIPE_PUSH=ON -DMOBILEGL_BUILD_DISAGGREGATED=ON -DMOBILEGL_BUILD_DISAGGREGATED_INPROC=ON) the two roles are two threads of one process. The intended design is that everything crosses as wire: records in the SEG_CMD ring, bulk bytes in SEG_STAGE blobs, answers in SEG_REPLY slots, the caps snapshot, and the one-slot control mailbox for rare EGL operations. The next phase (P6, spawn) puts the server in another process, where any read of the other role's memory that is not one of those carriers simply cannot work.
Find every place where, today, one role reads (or writes) the other role's memory directly instead of going through a carrier. Both directions, and the shared process globals that only work because the address space is shared. The verb barrier (ClientSession::EmitAndWait waits for appliedSeq == emitSeq on every class-B verb, MOBILEGL_IPC_VERB_BARRIER=1) is what makes these reads "safe" today — so anything that is only correct because of the barrier belongs in your inventory too.
Where to start (read these first, they already name most of the debt)
MobileGL/MG_Remote/CONTRACT-P5.md§3 (field ownership: RECORD-SUPPLIED / APPLIER-DERIVED / BARRIER-PULLED / FATAL; the sticky forwards; "two sets with no field ids") and §4 (role and thread ownership of every process global).MobileGL/MG_Remote/CONTRACT-P5B.md§3–§4 and §6.docs/Disaggregated/ARCHITECTURE.md§17 (P5/P5b landed shape) anddocs/Disaggregated/CURRENT_STAGE_PROGRESS.md§5 (open items: the three "inproc dependencies" P5b left — named blit's scoped client-shadow binding, the mip descriptor's barrier-held registry lookup, FBO death's inproc mailbox).- Generated tables:
MobileGL/MG_Pipe/generated/PipeFieldOwnership.inc(36 rows arekBarrierPulled),PipeFilled.inc,MobileGL/MG_Pipe/FieldOwnership.def,Coverage.def,FillPoints.def.
Then the code:
- Client role:
MobileGL/MG_Remote/Client/*(EmitTables.cpp— the A/B/C slot partition and the pre-verb hooks;ClientSession.cpp;BackendObject_Remote.cpp;CapsMirror.cpp;PersistentMapTracker.cpp;GpuWritePending.cpp),MobileGL/MG_Impl/Pipe/PipeFill.cpp(the residual fill ofgPipeInputs),MobileGL/MG_Pipe/PipeRoute.{h,cpp}. - Server role:
MobileGL/MG_Remote/Server/*(PipeApplier.cppincl.ServerVerbSink,ServerLoop.cpp,ServerSession.cpp,StagedShadow.h),MobileGL/MG_Remote/Wire/PipeWireCodec.cpp(WireVerbSink, the segment resolver,MGHostSpandecoding),MobileGL/MG_Pipe/PipeApply.cpp,MobileGL/MG_Backend/MGPipe/PipeInputs.{h,cpp}. - Backends' handle arms:
MobileGL/MG_Backend/DirectGLES/{Managers.cpp,DirectGLES.cpp,Utils.cpp,BackendObject_DirectGLES.cpp}andMobileGL/MG_Backend/DirectVulkan/*— look forMGB_CTX->,MappedData(,GetStorage(,MipmapStorage,SharedPtr<,ProgramObject,TextureObject,BufferObject,pActiveBackendObject,pDefaultFramebufferInfo,MGPipeUnmigratedEmulation,liveHostBase,RequireStagedCoverageForPendingRanges,Fatal{StageSnapshotTooNarrow,Fatal{UncarriedInitialBytes,Fatal{InitialBytesNotCarried,Fatal{UnmigratedEmulation, registry lookups keyed by frontend identity. - Callbacks:
MobileGL/MG_Pipe/MGPipeCallbacks.hand wherever the split build installs them — underinproc, does the apply thread callOnGlError/OnGpuWritten/OnBufferWriteback/OnTextureWriteback/OnMipLevelsGenerated/OnSurfaceChanged/OnCapsInvalidated/OnLog/OnXfbScatterReady/OnTexturePullRequeststraight into client-ownedMG_Stateobjects? (SEG_EVENTexists inTransport/EventRing.h; is it used?) - Program artifacts:
MobileGL/MG_Pipe/ProgramArtifactsCodec.{h,cpp}— under split, doesCreateShaderStatecarry the archive as a blob, or does the server read the frontendProgramObject'sLinkArtifactsdirectly? (Fatal{ArtefactsMissing}/Fatal{ArchiveEmpty}exist somewhere.) - Caps:
MobileGL/MG_Remote/CapsCodec.cppandClient/CapsMirror.cpp— the format-capability table and the renderer string ("the twoGetCapsblobrefs") — carried in the snapshot, or read from the sharedpActiveBackendObject? AlsoBackendObject_DirectGLES.cpp/Utils.cppformat-capability lookups that CONTRACT-P5 §4 says are backend-internal reads ofpActiveBackendObject. - Textures: how
ResourceSubDatabytes reach Espryt under split (blob inSEG_STAGE→StagedShadowStore? or a pointer into the client'sMipmapStorage?); the mip-generation path (GenerateMipmap, "GLES mip storage descriptor"),CopyImageSubData's shadow mirror,GetTexImage,CopyTexImage2D/CopyTexSubImage2D. - Buffers:
Ops_H_*inManagers.cpp,EnsureBufferResourceForHandle(its "frontend object held" arm),HasDefinedContent(), persistent maps (PersistentMapTracker,MOBILEGL_IPC_ADOPT_TIER=2emulated tier),SyncGpuWrites/MarkGpuWritten, XFB capture / scatter. - Process globals under inproc: everything in CONTRACT-P5 §4's table plus anything it missed (e.g.
MGPipeSlots()and the otherMG_Impl/Pipesingletons — does any server-side code read them?g_syncedRenderStateParameters? Espryt twins that still hold a frontend pointer?g_rawDepthFetchSamplerState?). - Client reads of server memory: any
MG_Impl/MG_Remote/Clientread ofg_applier/MGPipeApplierState/MGPipeGetResourceOps()/ backend twins /pActiveBackendObject(beyond the caps mirror) under split;MG_IntegrationTest/Harness/Pipe*Peekare test-only — list them separately.
Use grep aggressively (ripgrep is available on Windows as rg, or grep -rn); then open each hit and decide. Do not trust the contracts' line numbers — they are from older heads; re-resolve every site on a79a0af6 and cite file:line exactly (the repo has scripts/check_doc_citations.py which checks path:line citations against HEAD; your citations must resolve).
What to write: p5c-audit-v1.md in the scratchpad directory named above (write it FIRST, before your final message)
- Inventory table, one row per site or per tightly-coupled family (aim for completeness over brevity; 30–60 rows is plausible). Columns:
#· direction (S→C read= server reads client memory,C→S read,S→C write,C→S write,shared global) · what memory (object/field) · reader/writer site (file:line, function) · owner of that memory · when it happens (verb class / call / frequency: per draw, per upload, once) · why it works today (barrier / same address space / single writer) · what breaks underspawn· current guard (Fatal{...}name,MOBILEGL_IPC_STRICT_ERRORS,MOBILEGL_IPC_AUDIT,rspcounter, none) · the natural carrier (a new/extended record field, aSEG_STAGEblob, a reply slot, aSEG_EVENTevent, the caps snapshot, the control mailbox, or "server-derived — no carrier needed") · suggested phase (P5c now / P6 / P7 / P8 / P9 / P10) — with one line of reasoning. - Summary counts by direction and by carrier, and the top 10 by frequency (per-draw first).
- Already wire-clean: a short list of the paths you checked that DO go through a carrier (buffers via
StagedShadowStore, ReadPixels reply, DrawVbo user indices, fence handles, …), so the plan is bounded by evidence, not assumption. - Surprises / disagreements with what the contracts and
ARCHITECTURE.md§17 claim (e.g. a field the tables call RECORD-SUPPLIED that the backend still pulls; a callback delivered directly; agMGPipeSegmentResolverorMGHostSpan::Ptrshort-cut). - Existing numbers you found without running anything: any
rsp=values in~/w7/notes/p5b/p5b-results/*.md,~/w7/notes/p5/p5-results/*.mdor~/w7/p5b-final-census-348d22a4/logs (cite the file), so the plan can size the debt.
Keep prose minimal; tables over paragraphs. Be precise: if you are not sure a site is reached under inproc (e.g. it is inside #if !MOBILEGL_BUILD_DISAGGREGATED or behind a class-C refusal), say so in the row rather than dropping it. Cite the git head you read (git rev-parse HEAD).
When the report file is written, reply with at most 150 words: the row count, the top three findings, and anything you could not resolve.