mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-09-08 12:18:30 +09:00
BZLZHH
1011d9fea1
Two unit tests asserted behaviour the conformance tests had since contradicted, so they were testing MobileGL's old answer rather than GL's. QueryTest expected glIsQuery to report a name straight out of glGenQueries as a query object. It is not one: GenQueries reserves names, and they "acquire query state only when they are first used by calling BeginQuery" (GL 4.6 core 4.2.1). The test now checks that a reserved name reads FALSE, that BeginQuery is what turns it into an object, and that a sibling name left untouched stays FALSE. A companion case covers the direct state access half, where glCreateQueries does create the object outright - which is the whole reason the two entry points both exist. The DirectGLES binding test built its texture with glGenTextures and glBindTexture and nothing else, then expected BindCurrentTextures to bind it natively. A texture with no image is incomplete and samples as (0, 0, 0, 1), which DirectGLES expresses by leaving the native target unbound, so the setup no longer produced the binding the test then went on to clear. It now gives the texture a format and a 1x1 level 0 - one level is the entire mip chain at that size, so it is complete under any filter - and asserts that directly, so a future completeness change fails on the setup line instead of on the assertion three calls later.