swung0x48
aba329cc53
Two things land together: the plan and contract draft P6 needs before it starts, and the
working notes that until now existed on exactly one machine.
1. P6's plan and contract draft (neither started; not one line of code)
docs/Disaggregated/P6-SPAWN-PLAN.md the package plan
docs/Disaggregated/P6-CONTRACT-DRAFT.md the contract draft (moves to
MG_Remote/CONTRACT-P6.md when c6 lands)
The three findings that mattered, all written into the documents:
a. P6 is SMALLER than its roadmap cell suggests. The transport primitives are already in
the tree and already tested: SocketDoorbell including hangup detection and the two
lost-wakeup fences (Doorbell.cpp:211-360, four cases in FdPassingTest), SCM_RIGHTS fd
passing, ShmSegment::Adopt, and the SurfaceOp / WindowKind schema already defined in
protocol.fbs. inproc uses a real second shm mapping rather than an alias, and
SessionRings.h:22-28 says that was done so today is not the first time it runs. P6 is
assembly plus a control plane plus a process, not "write a socket transport".
b. The evidence for "P6 is only a transport swap" has EXPIRED. It was bought by P5c, whose
audit found 59 direct memory accesses in a tree that already looked clean. P5e changed
the tree again. So the first package, a6, is a read-only audit that writes no code, and
every contract row that depends on it is marked PENDING a6 rather than decided in
advance.
c. P6 does not get a game running on the phone. ANativeWindow* is meaningless in the child,
and protocol.fbs:186-196's own comment says Android transfers the window out of band -
that band is P12. P6 lands pbuffer / surfaceless / offscreen, which is what HeadlessGL,
the split-equivalent lane and trace replay need, and which is exactly what P6's own exit
gate measures. A real window reaching the server is a named refusal. This gets its own
section because "P6 is done" would otherwise read as "the game runs now".
The contract adds rule G: a role may not name a process-local handle. It extends P5c's
rule E (a role may not name the other role's memory) from memory to identity - EGLDisplay /
EGLSurface / EGLContext / ANativeWindow* / fd number / pid / mapped address either cross as
a token this contract defines or they do not cross, and a descriptor crosses only through
SCM_RIGHTS, where the kernel renumbers it.
What P5e left for P6 gets its own section. The latch semantics are already designed
(ARCHITECTURE.md:504) and are copied unchanged. What is new is that after run-ahead the
client no longer waits while the peer process can DIE: the client holds records that were
published and will never be applied, and Android's freezer suspends the child without
closing anything. So slow and dead must be distinguishable WITHOUT a timeout threshold.
That is P6's only new design; everything else is carriage. It shares a predicate with E1's
outstanding re-specification (ID-122), and the two should be designed together.
Two gates carried over from P5e's lessons: G2 requires integration-spawn's test-name set to
match integration-split's name for name, because a differing set means the lane is quietly
running less; and the arm-proof gate requires every entry to record the child pid and
transport=spawn in its OWN private log - ID-124 established that this kind of false green
really happens, and a spawn lane that actually ran monolith would pass every other gate.
S2's shape must be settled before it is written, and the document says why: E1 is the
cautionary case.
2. The working notes move into the repository (docs/Disaggregated/notes/, 415 .md files)
ROADMAP / CURRENT_STAGE_PROGRESS / MEASUREMENTS cite ruling numbers, audit line numbers and
the provenance of gate figures from ~/w7/notes/, a directory that exists on one machine and
is under no version control. A record cited hundreds of times that lives only locally is not
a record, so it moves in whole, with its directory structure intact.
Only .md moves. Scripts, run logs, census and gate result JSON, patches, APKs and nm dumps
stay where they are: they are evidence DATA rather than documents - large, regenerated per
run, and mostly carrying absolute paths and device serials that mean something only on the
machine that produced them. The mapping and this split are written in
docs/Disaggregated/notes/README.md.
Two exceptions are recorded there too: P6's BRIEF has been promoted to a first-class
document and keeps no copy under notes/, so the two cannot drift apart; and recovered/ holds
material salvaged from failed workflow runs, which may duplicate the like-named phase
directories and is kept because a few of those were the only complete version at the time.
CI's citation lint takes docs/Disaggregated/*.md only (non-recursive), and notes/ is
deliberately outside it: those notes' file:line citations were written against their own
code heads, and resolving them against today's HEAD would fail wholesale - which is not an
error, it is their correct state as a historical record. To check one, use the revision it
declares (--rev).
3. Inconsistencies fixed in passing
- README.md's status line still said P5e was in progress while the stage table already said
closed.
- CURRENT_STAGE_PROGRESS's next-step item 1 still listed the exit gate as pending, though
(a) and (b) were run in the previous commit; rewritten to closed plus the one item that
actually remains (E1).
- ROADMAP's P6 row still had the pre-phase plan in three of its cells; it now carries the
package order, the scope boundary and the two new gates.
Checked with check_doc_citations.py: 125 citations across docs/Disaggregated/*.md, 0 problems.
5.4 KiB
TASK-mv — the multi-draw path stops reading the frontend VAO
Read PACKAGE-PREAMBLE-P5E.md first. Your tree is ~/w7/p5e-mv, branch p5e/mv, base 7c6f6886.
Your slug for the gate driver is mv.
1 What is measured
Per-entry marker census at your base (~/w7/p5e-logs/strict-census/census2.tsv): 9 entries
abort with Fatal{UnmigratedPipeInput, "GetBoundVertexArray@DrawArrays"}, and every one of them is
a multi-draw case:
DirectGLES.Split.IndexedDrawFamilyScenario.MultiDrawElementsBaseVertexPaintsEverySubDraw
DirectGLES.Split.MultiDrawScenario.BaseVertexBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.BaseVertexBeyondIndexTypeRangeMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.PlainBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.PrimitiveRestartStripBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.PrimitiveRestartUnsignedShortBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.UnsignedByteBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.UnsignedShortBatchMatchesUnrolledDraws
DirectGLES.Split.MultiDrawScenario.ZeroCountSubDrawsMatchUnrolledDraws
That confinement is the point: package vi already retired the bound-VAO row on the ORDINARY draw
path. SyncCurrentVertexAttributeValues takes fromRecords ? noVao : MGB_CTX->GetBoundVertexArray()
(DirectGLES.cpp:2291) and PrepareForDraw takes
vertexInputFromRecords ? noFrontendVao : MGB_CTX->GetBoundVertexArray() (:5986). What is left is
a path vi did not own.
2 The site
MobileGL/MG_Backend/DirectGLES/MultiDraw.cpp:93-98:
const SharedPtr<MG_State::GLState::BufferObject>& BoundIndexBuffer() {
static const SharedPtr<MG_State::GLState::BufferObject> none;
const auto& vao = MGB_CTX->GetBoundVertexArray(); // <-- unconditional, no arm test
if (!vao) return none;
return vao->GetIndexBufferBindingSlot().GetBoundObject();
}
and its caller BoundIndexBufferId() just below, which turns it into a GL name through
BufferImpl::EnsureBufferResource. Read the whole file first: the multi-draw tiers swap in a
scratch index buffer and restore the original binding, and the comment at :102-105 explains why
restoring the exact name matters (the VAO twin memoises that it already synced this index binding).
Audit MultiDraw.cpp for any OTHER frontend read on the apply thread while you are in there, and
report what you find even if you do not change it.
3 The wire already carries the answer
No wire change. The applier state already holds the index buffer:
MGPIndexBuffer IndexBufferandUint64 IndexBufferSerialin the applier state (MobileGL/MG_Pipe/PipeApply.h:688-690), applied byMGPipeApplySetIndexBuffer(:1247).
So the handle arm answers BoundIndexBuffer from MGPipeApplier().IndexBuffer and resolves the
buffer resource by handle, the way the other by-handle resolvers do. Find the buffer-side
by-handle resolver that package vi / sb landed (BufferImpl::EnsureBufferResourceForHandle is one;
read Managers.h's block of Pipe*RecordForHandle declarations around :735) and use it rather
than minting a new one.
If it turns out the multi-draw tiers need something from the VAO that the index-buffer record genuinely cannot answer, STOP and report rather than inventing a wire row. The integrator wants to hear it.
4 Requirements on the arm selection
- The arm is decided by
MG_Config::Transport, through the family's existing selector (BufferImpl::VertexInputReadsRecords()is the one this path's siblings use; check what it resolves to and use the same one), never inferred from a pointer being null. This is ruling ID-81. The phase has already paid for breaking it: fix1 (66621767) and rulings ID-107 / ID-109 / ID-110 exist because one seam read "a handle was noted" as "the record arm is selected". Readdocs/Disaggregated/CURRENT_STAGE_PROGRESS.md§2.5 before you write it. - A missing record on the handle arm is a named refusal, not a silent fall-back to the
frontend. Copy
RefuseNullFrontendTextureOffTheHandleArm's shape (searchManagers.cpp). - The pull build gains no call; the monolith arm keeps its bytes.
5 Red-once (required, quoted verbatim in your report)
- Revert the arm selection: the strict lane goes red again with
GetBoundVertexArray@DrawArrayson those 9 entries. - Make the record lookup miss on the handle arm: your named refusal fires, quoted from the entry's
own log (
MOBILEGL_LOG_FILE_PATH—MGLOG_Fdoes not reach ctest's captured stdout; the working recipe is~/w7/notes/p5e/strict_census2.sh). - Put both back and show green.
6 Gate before you report
build rc=0 · unit 2250/2250 · isplit 116/116 · gpu 1294/1294 (new step, ID-109: the
monolith runtime arm, and how an ID-81 violation gets caught) · gens all rc=0 · strict: the
full per-entry marker census via strict_census2.sh. You succeed when
GetBoundVertexArray@DrawArrays is gone from that table and nothing new has appeared.
Pay particular attention to the multi-draw correctness lane: MultiDrawScenario asserts that a
batch matches unrolled draws, which is exactly the thing a wrong index buffer would break quietly.
7 Report
~/w7/notes/p5e/reports/mv-v1.md: the site inventory you actually found, the design and why, the
three red-onces verbatim, the before/after marker census, the gate table, and anything left undone
with the reason.