mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-07 01:53:24 +09:00
swung0x48
b8d10d0730
The B3 review (ID-P7-34) counted 12 of the 52 rows with no site at all - TexViewFormat, TexNoApplierRecord, TexRecordDeadOrStale and the nine Shape* rows were declared and never counted - and ten sites that counted with no (MGLOG_D included) line, so "a name, a tally and a decline line" did not describe the tree. - SyncWireTextureShape: all nine Shape* exits now count; the ViewOf exit and the preserve-flush exit were bare `return false` and are now MGL_WIRE_DECLINE_AT; the image-flags exit logged only MGLOG_D, which a Release build compiles away, and is promoted likewise. - The preserve-copy exit was the one Shape exit with no row: appended as ShapePreserveCopyFailed (rows are append-only), 53 rows. - SyncTextureResourceByHandle / UploadPendingWireLevels: the count-only sites without a log of their own are promoted to MGL_WIRE_DECLINE_AT; the ones already under a W/E _ONCE line keep that line and gain the count. - scripts/ci/wire_declines_audit.py: fails on a row with no site, a site naming no row, or a bare Count() with no MGLOG_W/E within 8 lines above it. WireDeclineTally.h (the macro's definition) is not a site. Wired into the job that runs the fatal census. Audit before: 52 rows, 40 with sites, 10 unlogged under the W/E rule (rc 1). After: 53 rows, 53 with sites, 0 unlogged (rc 0). Forced red (ShapeNoVkFormat made true for 1x1 textures, reverted): Split.Fm.F1WireScenario.VertexIdSampler... fails on pixels with ShapeNoVkFormat=2 / TexShapeSync=2 in the shutdown tally.
101 lines
4.4 KiB
Python
Executable File
101 lines
4.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
"""P7 wave 2 package B3: WireDeclines.def rows and their sites must agree.
|
|
|
|
CONTRACT-P7 §0 rule I admits two shapes for a wire-arm refusal, a decline and a named Fatal.
|
|
The decline half is only real if:
|
|
|
|
(1) every row in WireDeclines.def is actually counted somewhere - a row with no site is a
|
|
name that can never move, which reads in a report as "this cannot happen here" when it
|
|
only means "nobody wired it up"; and
|
|
(2) every site emits a line - a counter with no log puts the next reader back on a bisect,
|
|
which is the thing the package exists to remove.
|
|
|
|
Rows are APPEND-ONLY (the lanes assert specific counters), so (1) cannot be fixed later by
|
|
deleting a row once a release has shipped it. This check is why it cannot rot.
|
|
|
|
Sites reached through MGL_WIRE_DECLINE_AT satisfy both at once. A bare
|
|
WireDeclineTally::Count(WireDeclineSite::X) is allowed ONLY when an MGLOG_ statement carrying
|
|
the same reason already stands just above it.
|
|
|
|
usage: wire_declines_audit.py [repo-root]
|
|
"""
|
|
import os
|
|
import re
|
|
import sys
|
|
|
|
RENDERER = "MobileGL/MG_Backend/DirectVulkan/Renderer"
|
|
DEF = os.path.join(RENDERER, "WireDeclines.def")
|
|
SOURCES = (".cpp", ".inc", ".h")
|
|
# How far above a bare Count() an MGLOG_ may stand and still be "the line for this site".
|
|
LOG_WINDOW = 8
|
|
|
|
ROW = re.compile(r"^\s*MGL_WIRE_DECLINE\(([A-Za-z][A-Za-z0-9]*)\)\s*$")
|
|
AT_SITE = re.compile(r"MGL_WIRE_DECLINE_AT\(\s*([A-Za-z][A-Za-z0-9]*)\s*,")
|
|
COUNT_SITE = re.compile(r"WireDeclineTally::Count\(\s*WireDeclineSite::([A-Za-z][A-Za-z0-9]*)\s*\)")
|
|
# Warning or error only: an MGLOG_D / MGLOG_V is compiled away in the Release builds that ship,
|
|
# so it is not a line anybody can read off a device.
|
|
LOGGED = re.compile(r"MGLOG_[WE](_ONCE)?\s*\(")
|
|
|
|
|
|
def main() -> int:
|
|
root = os.path.abspath(sys.argv[1] if len(sys.argv) > 1 else ".")
|
|
def_path = os.path.join(root, DEF)
|
|
if not os.path.isfile(def_path):
|
|
print("wire-declines: %s not found" % DEF, file=sys.stderr)
|
|
return 2
|
|
|
|
rows = []
|
|
for line in open(def_path, encoding="utf-8"):
|
|
m = ROW.match(line)
|
|
if m:
|
|
rows.append(m.group(1))
|
|
if len(rows) != len(set(rows)):
|
|
dupes = sorted({r for r in rows if rows.count(r) > 1})
|
|
print("wire-declines: duplicate rows: %s" % ", ".join(dupes), file=sys.stderr)
|
|
return 1
|
|
|
|
counted = {} # name -> [(file, line)]
|
|
unlogged_counts = [] # (file, line, name)
|
|
src_dir = os.path.join(root, RENDERER)
|
|
for entry in sorted(os.listdir(src_dir)):
|
|
if not entry.endswith(SOURCES):
|
|
continue
|
|
# The header that DEFINES the macro and the enum names them all without being a site.
|
|
if entry == "WireDeclineTally.h":
|
|
continue
|
|
path = os.path.join(src_dir, entry)
|
|
lines = open(path, encoding="utf-8", errors="replace").read().splitlines()
|
|
for i, line in enumerate(lines):
|
|
for m in AT_SITE.finditer(line):
|
|
counted.setdefault(m.group(1), []).append((entry, i + 1))
|
|
for m in COUNT_SITE.finditer(line):
|
|
name = m.group(1)
|
|
counted.setdefault(name, []).append((entry, i + 1))
|
|
window = lines[max(0, i - LOG_WINDOW):i]
|
|
if not any(LOGGED.search(w) for w in window):
|
|
unlogged_counts.append((entry, i + 1, name))
|
|
|
|
orphan_rows = [r for r in rows if r not in counted]
|
|
unknown_sites = sorted(set(counted) - set(rows))
|
|
|
|
for name in orphan_rows:
|
|
print("wire-declines: row %s has NO SITE - it can never be counted" % name, file=sys.stderr)
|
|
for name in unknown_sites:
|
|
for where in counted[name]:
|
|
print("wire-declines: %s:%d counts %s, which is not a row in WireDeclines.def"
|
|
% (where[0], where[1], name), file=sys.stderr)
|
|
for entry, line, name in unlogged_counts:
|
|
print("wire-declines: %s:%d counts %s with no MGLOG_ within %d lines above it - a decline "
|
|
"must be readable from the log, not only from a counter"
|
|
% (entry, line, name, LOG_WINDOW), file=sys.stderr)
|
|
|
|
bad = len(orphan_rows) + len(unknown_sites) + len(unlogged_counts)
|
|
print("wire-declines: %d rows, %d with sites, %d site(s) total, %d unlogged, %d unknown"
|
|
% (len(rows), len(rows) - len(orphan_rows), sum(len(v) for v in counted.values()),
|
|
len(unlogged_counts), len(unknown_sites)))
|
|
return 1 if bad else 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|