swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-09-12 14:18:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] (MG_State/GL_Program): wrong guard condition in Uniformv_State

Browse Source
This commit is contained in:
swung0x48
2025-10-27 11:20:23 +08:00
parent 5e5d0f3dbe
commit 034aeb9b12
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Impl/GLImpl/Program/GL_Program.cpp
+1 -1
View File
@@ -473,7 +473,7 @@ namespace MobileGL {
return; return;
} }
if (location >= programObject->GetUniformCount() || location < -1) { if (location > programObject->GetMaxUniformLocation() || location < -1) {
MG_State::pGLContext->RecordError( MG_State::pGLContext->RecordError(
ErrorCode::InvalidOperation, ErrorCode::InvalidOperation,
MakeShared<GenericErrorInfo>("MG_Impl/GLImpl", __func__, MakeShared<GenericErrorInfo>("MG_Impl/GLImpl", __func__,
MobileGL/MG_State/GLState/ProgramState/ProgramObject.h
+3 -1
View File
@@ -25,7 +25,9 @@ namespace MobileGL {
Uint GetMaxUniformLocation() const { return m_maxUniformLocation; } Uint GetMaxUniformLocation() const { return m_maxUniformLocation; }
Int GetUniformLocation(const String& name) { Int GetUniformLocation(const String& name) {
const auto it = m_uniformLocations.find(name); const auto it = m_uniformLocations.find(name);
return (it == m_uniformLocations.end()) ? -1 : (Int)it->second; if (it == m_uniformLocations.end())
return -1;
return (Int)it->second;
} }
GLenum GetUniformType(Uint index) const { return m_uniformTypes[index]; } GLenum GetUniformType(Uint index) const { return m_uniformTypes[index]; }