swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-11-08 02:23:23 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Fix] (MG_Impl/Pipe): zero the pixel pack record's padding before it is sent

Browse Source
This commit is contained in:
swung0x48
2026-11-07 07:39:14 -04:00
parent cefb70d1a7
commit 4256a66d09
1 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Impl/Pipe/PipeFill.cpp
+14 -2
View File
@@ -2602,8 +2602,20 @@ namespace MobileGL::MG_Pipe {
// boundary reads unpack state, and the staged-repack upload path does not even issue
// glPixelStorei (ARCHITECTURE.md 4.6 D5).
Uint64 EmitPixelPackState(GLContext& ctx) {
MGPPixelPackState pack{};
pack.Pack = ctx.GetPixelStoreParameters(false);
// Field by field into zeroed bytes: the two bytes of padding after the Bools would
// otherwise carry whatever the context's heap block held, onto the wire and into the
// recorder's hash.
MGPPixelPackState pack;
std::memset(&pack, 0, sizeof(pack));
const PixelStoreParameters live = ctx.GetPixelStoreParameters(false);
pack.Pack.SwapBytes = live.SwapBytes;
pack.Pack.LSBFirst = live.LSBFirst;
pack.Pack.RowLength = live.RowLength;
pack.Pack.ImageHeight = live.ImageHeight;
pack.Pack.SkipPixels = live.SkipPixels;
pack.Pack.SkipRows = live.SkipRows;
pack.Pack.SkipImages = live.SkipImages;
pack.Pack.Alignment = live.Alignment;
MGPipeRouteSetPixelPackState(pack);
return sizeof(MGPPixelPackState);
}