mirror of
https://github.com/MobileGL-Dev/MobileGL
synced 2026-11-20 08:21:56 +09:00
[MG_Pipe, MG_Backend, MG_Remote, MG_Test, scripts] (P7): the Magma wire fatals and the two Staged aborts go through Session::Fail
Five deaths in the split server image raised their own std::abort(). Three of them are funnels - MagmaWireFatal (Renderer/WireFramebuffer.inc), WireDescriptorFatal (Renderer/UniformManager.cpp) and WireBufferLegacyFatal (Renderer/WireDraw.inc) - and the fifteen `@P7` refusals on the tree (8 in UniformManager.cpp, 4 in WireFramebuffer.inc, 2 in WireDraw.inc, 1 in VulkanRenderer.cpp; plan section 1.3's count confirmed) all die through two of them. Every one of those deaths published NO SessionFault frame, so the peer read a bare EOF; bumped NO SessionFaultCount(), so exit gate S8 could neither confirm nor falsify it; and carried a hand-typed family word with no path to FatalFamilies.def's projection. MG_Backend may not name an MG_Remote symbol on its own account, so the route is a seam in MG_Pipe with MGP_TRIP_WIRE_REPORT's shape (PipeApply.cpp:66, and the new code sits beside it): MG_Pipe/PipeSessionFail.h declares MGPipeSessionFail, PipeApply.cpp defines it inside `#if MOBILEGL_BUILD_DISAGGREGATED`, the DEFAULT behaviour is byte-identical to what the three funnels did on their own, and MG_Remote::InstallPipeSessionFailHook() points it at SessionFail. The install is in InitServerRoleCommon (MG_Backend/Init.cpp), step 0, because that is the one function BOTH server roles run - the inproc role and the spawn/TCP session child - so there is no per-transport install to get wrong. MGPipeFatalFamily is a two-value boundary enum, NOT MGFatalFamily cast to an integer: the .def's enumerators are positional and a row inserted in its middle would silently re-point every hook call at a different family. FatalFunnel.cpp's adapter is the one place the two vocabularies meet, as a switch with a named default. The family word stays UnmigratedVerb rather than becoming a new MagmaWireRefusal. Three reasons: the message strings are required to stay byte-identical (5.2), and the retrace refusal censuses recorded since P5b count these deaths by that word - a rename invalidates every `@P7` measurement taken against them; `Magma:` in the detail already separates the Magma arm from the GLES UnmigratedVerb deaths, so a new word adds no discrimination a grep does not have; and its wire projection would be ProtocolCorruption, exactly UnmigratedVerb's. Recorded for the integrator. Ph slice (2) in the same commit: Server/StagedShadow.h's RequireCovered and Server/StagedTextureStore.h's RequireLevelBytes were MGLOG_F + bare abort. Both are inside MG_Remote already, so they call SessionFail directly, message verbatim; check_include_closure.py's four probes do not reach either header and the gate is green. Census: 83 abort sites -> 79 over 20 files (five sites retired, one gained for the seam's no-hook default, which is argued into FUNNEL_SITES), baseline rewritten in this commit - the downward ratchet's notice is what asked for it. Two gate bugs the widening exposed and this commit fixes: the SessionFail call regex also matched `MGPipeSessionFail(` (a lookbehind now), and a funnel's anchor needed a wider window than a marker's (kFunnelAnchorWindow). Red-once, three ways. Pointing MagmaWireFatal back at its own abort reds the census naming WireFramebuffer.inc 0 -> 1. Making the seam skip the hook reds both new death cases - `TheMagmaWireVerbDeathReachesSessionFailAndBumpsTheFaultCount` on the exit code, because it reads SessionFaultCount() out of a SIGABRT handler and gets 0 instead of 1, and `TheSeamHandsTheInstalledHookItsFamilyAndItsLineVerbatim` on the line the hook echoed.
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
// MobileGL - MobileGL/MG_Pipe/PipeSessionFail.h
|
||||
// Copyright (c) 2025-2026 MobileGL-Dev
|
||||
// Licensed under the GNU Lesser General Public License v3.0:
|
||||
// https://www.gnu.org/licenses/gpl-3.0.txt
|
||||
// https://www.gnu.org/licenses/lgpl-3.0.txt
|
||||
// SPDX-License-Identifier: LGPL-3.0-only
|
||||
// End of Source File Header
|
||||
|
||||
// P7 wave 0 (plan section 1.3 row `@P7`, item (0); Ph slice (2)). HOW A BACKEND DEATH REACHES
|
||||
// Session::Fail WITHOUT THE BACKEND KNOWING MG_Remote EXISTS.
|
||||
//
|
||||
// The three Magma wire funnels - MagmaWireFatal (Renderer/WireFramebuffer.inc),
|
||||
// WireDescriptorFatal (Renderer/UniformManager.cpp) and WireBufferLegacyFatal
|
||||
// (Renderer/WireDraw.inc) - each logged their line and raised their OWN std::abort(). Fifteen
|
||||
// `@P7` refusals and two more sites die through them, and every one of those deaths:
|
||||
//
|
||||
// * published NO SessionFault frame, so the peer read a bare EOF and could not name what
|
||||
// ended the session (CONTRACT-P6 5.2's whole point);
|
||||
// * bumped NO SessionFaultCount(), so exit gate S8's "zero faults over a good run" could
|
||||
// neither confirm nor falsify them;
|
||||
// * carried a HAND-TYPED family word with no path to FatalFamilies.def's projection, so
|
||||
// nothing checked that `UnmigratedVerb` in the string still meant UnmigratedVerb.
|
||||
//
|
||||
// Calling SessionFail() from the .inc files directly would be the obvious fix and is the wrong
|
||||
// one: MG_Backend's renderer would then name an MG_Remote symbol on its own account rather than
|
||||
// through the two staging headers it already borrows under `#if MOBILEGL_BUILD_DISAGGREGATED`,
|
||||
// and the layering that P13's module boundaries have to establish would be one more edge worse.
|
||||
//
|
||||
// So the shape is MGP_TRIP_WIRE_REPORT's (PipeApply.cpp:66): MG_Pipe owns the entry point, the
|
||||
// DEFAULT behaviour is exactly what the site did before (same log line, same abort), and the
|
||||
// richer behaviour is a function pointer that a layer above installs. MG_Remote installs
|
||||
// InstallPipeSessionFailHook() at server-role init (MG_Backend/Init.cpp's InitServerRoleCommon,
|
||||
// which both the inproc server role and the spawn child run), and from then on these deaths go
|
||||
// through SessionFail like every other one.
|
||||
//
|
||||
// THE MESSAGE STRING IS PASSED VERBATIM, family word and all - the same rule FatalFunnel.h
|
||||
// states. The lines these three funnels write are already counted by name in the retrace refusal
|
||||
// census and in every recorded `@P7` measurement, so they are byte-identical before and after.
|
||||
|
||||
#pragma once
|
||||
|
||||
namespace MobileGL::MG_Pipe {
|
||||
|
||||
// THE FAMILIES THAT CROSS THIS BOUNDARY, AND ONLY THOSE. Not `MGFatalFamily` cast to an
|
||||
// integer: the .def's enumerators are positional, and a row inserted in the middle of it
|
||||
// would silently re-point every hook call at a different family. Two words is what the three
|
||||
// funnels use today, and a third one costs a row here and an arm in the adapter - which is
|
||||
// the point, because that arm is where the choice gets argued.
|
||||
enum class MGPipeFatalFamily : unsigned {
|
||||
// The Magma wire arms' refusal to honour a verb/shape the split path does not implement.
|
||||
// Deliberately the SAME word the sites already print: `Magma:` in the detail is what
|
||||
// separates them from the GLES `UnmigratedVerb` deaths, and renaming the family would
|
||||
// invalidate every census number recorded against it since P5b.
|
||||
UnmigratedVerb,
|
||||
// A call that reached an arm this build did not compile, or ran on the wrong role.
|
||||
RoleViolation,
|
||||
};
|
||||
|
||||
// What the layer above installs. `line` is the FULLY FORMATTED message, so the hook forwards
|
||||
// it rather than re-formatting it - a second vsnprintf is a second chance to disagree about
|
||||
// what the death said. A hook is expected not to return; MGPipeSessionFail aborts anyway if
|
||||
// one does, because a death that keeps running is the one outcome nothing downstream handles.
|
||||
using MGPipeSessionFailHook = void (*)(MGPipeFatalFamily family, const char* line);
|
||||
|
||||
// Idempotent and last-writer-wins. Installed once per process at server-role init; a unit
|
||||
// case installs its own and restores nullptr afterwards.
|
||||
void MGPipeInstallSessionFailHook(MGPipeSessionFailHook hook);
|
||||
|
||||
// The installed hook, or nullptr. A test reads it to prove installation happened without
|
||||
// having to die to find out.
|
||||
MGPipeSessionFailHook MGPipeSessionFailHookInstalled();
|
||||
|
||||
// Formats `fmt`, hands the line to the hook if one is installed, and otherwise does exactly
|
||||
// what the three funnels used to do on their own: MGLOG_F the line and std::abort().
|
||||
[[noreturn]]
|
||||
#if defined(__GNUC__) || defined(__clang__)
|
||||
__attribute__((format(printf, 2, 3)))
|
||||
#endif
|
||||
void MGPipeSessionFail(MGPipeFatalFamily family, const char* fmt, ...);
|
||||
|
||||
} // namespace MobileGL::MG_Pipe
|
||||
Reference in New Issue
Block a user