swung0x48/MobileGL
1
0
Fork 0
mirror of https://github.com/MobileGL-Dev/MobileGL synced 2026-09-17 00:28:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

[Feat] (MG_Pipe): give MGPSubData's pad byte to HasLiveHostWrites - the live-host-writer fact is content-shaped, and MGPResourceDesc's only carrier costs a buffer a spurious reallocation on every map

Browse Source
This commit is contained in:
swung0x48
2026-09-11 14:31:46 -04:00
parent ff2994d9a8
commit eaf2b28b8c
2 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
MobileGL/MG_Pipe/MGPipeTypes.h
+21 -1
View File
@@ -1075,7 +1075,27 @@ namespace MobileGL::MG_Pipe {
// Replaces the backend's `uploadData == mipData` pointer comparison: are these
// bytes an untransformed level shadow?
Uint8 SourceIsVerbatimLevelShadow;
Uint8 Pad0[3];
// P5 (b1): DOES THIS RESOURCE HAVE A LIVE HOST WRITER RIGHT NOW? One byte out of the
// pad, so MGP_ASSERT_POD(MGPSubData, 72) below does not move.
//
// It is here rather than on MGPResourceDesc, and that is a ruling with a reason. The
// fact is CONTENT-shaped - "someone may be writing these bytes without telling you" -
// and MGPResourceDesc's only carrier is resource_respecify, which for a BUFFER is
// never classified as metadata-only (PipeApply.cpp's RespecifyRedefinesNoStorage
// refuses the buffer target outright, so that ID-18 M4's "no reallocation ack" is true
// by construction). Announcing a map on a descriptor would therefore have cost a
// spurious reallocation per map - precisely the failure the brief warned about - or a
// change to that rule, which is a P4a contract the buffer family should not be
// re-opening for a flag.
//
// WHO SETS IT: MGPipeEmitResourceSubData, from BufferObject::HasLiveHostWritesForWire.
// WHO READS IT: ApplyBufferWrite, into MGPipeResourceRecord::HasLiveHostWrites, which
// is what IsBufferDrawCleanByHandle asks instead of the frontend object's IsMapped().
// ZERO IS THE ANSWER, NOT THE ABSENCE OF ONE: a record that does not set it says "no
// live writer", which is what every monolith emission means and why the monolith path
// needs no edit at all.
Uint8 HasLiveHostWrites;
Uint8 Pad0[2];
MGPBox UnionBox;
Uint32 RegionCount; // MGPSubRegion[] in the variable tail
Uint32 Pad1;
MobileGL/MG_Pipe/PipeFields.def
+2 -1
View File
@@ -173,7 +173,8 @@
F(X) F(Y) F(Z) F(W) F(H) F(D) F(SrcOffset) F(SrcRowStride) F(SrcSliceStride)
#define MGP_FIELDS_MGPSubData(F) \
F(Res) F(Target) F(Level) F(SourceIsVerbatimLevelShadow) F(UnionBox) F(RegionCount) F(Blob)
F(Res) F(Target) F(Level) F(SourceIsVerbatimLevelShadow) F(HasLiveHostWrites) F(UnionBox) \
F(RegionCount) F(Blob)
#define MGP_FIELDS_MGPSubDataComplete(F) \
F(Res) F(Target) F(FirstLevel) F(LevelCount) F(PullSerial)