[Chore] (trace-replay): remove local progress notes

This commit is contained in:
2026-06-20 06:08:18 +08:00
parent ada6923039
commit f10ea4ebcd
2 changed files with 0 additions and 78 deletions
-76
View File
@@ -1,76 +0,0 @@
Trace replay fixture validation attempts
========================================
Current fixture under investigation:
- minecraft-1.21.4-fabric-iris-photon-v1.1-in-world
- Archive: tools/trace_replay/fixtures/minecraft-1.21.4-fabric-iris-photon-v1.1-in-world.tgz
- Golden: tools/trace_replay/fixtures/minecraft-1.21.4-fabric-iris-photon-v1.1-in-world.0000159866.png
- Target call: 159866
- Size: 854x480
- Current validation tolerance: 20, fuzz percent: 20
Baseline validation:
- DirectGLES passes locally with mismatchPixels=8.
- DirectVulkan fails locally with mismatchPixels=32274 after the current R11G11B10F upload/backing experiment.
- DirectVulkan actual is structurally complete, but the sky/atmosphere is too dim/brown compared to the golden.
DirectVulkan R11G11B10F investigation:
- Native VK_FORMAT_B10G11R11_UFLOAT_PACK32 backing produced severe structural corruption:
black/green regions and mismatchPixels around 228523.
- Mapping GL_R11F_G11F_B10F to VK_FORMAT_R16G16B16A16_SFLOAT and expanding uploaded
packed R11G11B10F source data to RGBA16F fixed the structural corruption, but did
not fully match the golden.
- A sampled R/B component swizzle experiment with native R11 backing made the result worse
with mismatchPixels around 268190, so it was reverted.
- Always applying offscreen Y flip made the result worse with mismatchPixels around 129932,
so it was reverted.
- Folding source/destination alpha blend factors for vec3/RGB attachments did not change
the Photon result, so it was reverted.
Trace evidence:
- The first obvious divergence appears before the final composite, around program 7 writing
framebuffer 10 / texture 61.
- texture 61 is GL_R11F_G11F_B10F at 192x108.
- program 7 writes layout(location = 0) out vec3 sky_map and samples texture45, texture51,
texture52, texture53, and texture54.
- Later program 173 samples texture61 and writes framebuffer 16 / texture46, also
GL_R11F_G11F_B10F, at 854x480.
- Because the final image is complete but sky/atmosphere is wrong, the current leading
hypothesis is a remaining GL unsigned packed-float render-target conversion semantic,
especially non-negative clamp/quantization when fragment outputs are written to
GL_R11F_G11F_B10F.
- A SPIR-V-level experiment was added locally to clamp fragment location outputs with
max(value, 0) when drawing to an R11G11B10F attachment. It built successfully, but
Photon DirectVulkan still failed with mismatchPixels=32274, unchanged. This indicates
the remaining Photon error is not explained by simple negative color output writes.
The experiment should not be kept as a fix.
- Descriptor probing for the divergent sky-map shader showed the relevant Vulkan program
resolves sampler units as expected: customtex0 -> unit 5, customtex1 -> unit 3,
customtex2 -> unit 4, depthtex1 -> unit 7, and noisetex -> unit 6. These match the
trace's texture bindings around call 159207, so the first divergence is not a sampler
unit remapping issue.
- VAO 131 uses attribute 0 as vec3 Position and attribute 1 as vec2 UV0 with stride 20
and offsets 0/12, matching the shader's Position/UV0 declarations. This makes a basic
vertex attribute binding mismatch unlikely.
- A temporary SPIR-V pass that zero-initialized user Output variables at entry was tested
because the vertex shader has `sky_color += ...` without a prior obvious assignment.
The experiment made the 159207 output black and worsened final DirectVulkan validation
to mismatchPixels=314782, so it was reverted and should not be kept.
- Retesting native VK_FORMAT_B10G11R11_UFLOAT_PACK32 for GL_R11F_G11F_B10F on the current
tree still produced the earlier severe DirectVulkan failure with mismatchPixels=228523.
The RGBA16F fallback remains the better current state, but does not fully fix Photon.
Implementation constraints noted during investigation:
- Do not raise tolerance to hide rendering bugs.
- Do not commit temporary debug/probe logging.
- Do not put side-effectful calls inside MOBILEGL_ASSERT.
- Prefer SPIR-V/glslang/SPIRV-Cross facilities for shader changes; do not patch shader
source text unless there is no viable structured path.
- Use MOBILEGL_ASSERT for impossible states rather than silent fallback.
2026-06-19T20:26:20 - Photon DirectVulkan R11 experiment stashed before checking remaining unregistered fixtures.
2026-06-19T20:33:00 - Nostalgia local validation on clean Chocapic head: DirectGLES failed tolerance 20 with mismatchPixels=16608 but actual is visually close to golden; DirectVulkan failed severely with mismatchPixels=307321 and an overexposed/washed-out scene. Not registered in CI yet.
2026-06-19T20:40:00 - Bliss local validation on clean Chocapic head: DirectGLES failed tolerance 20 with mismatchPixels=31; DirectVulkan failed with mismatchPixels=1023 and sparse black speckles. The speckles first appear after program 182 / framebuffer 25 around call 113333.
2026-06-19T20:48:00 - Bliss experiments: applying the Photon R11G11B10F RGBA16F backing experiment changed DirectVulkan mismatchPixels only from 1023 to 1021, so it is not the Bliss fix. Clamping Vulkan sampler maxLod to the visible mip range also left mismatchPixels at 1021 and was reverted.
2026-06-19T20:55:00 - Created remaining.txt queue in processing order: Bliss, Nostalgia, Photon.
2026-06-19T21:05:00 - Bliss fix candidate: enabled glslang's setNanMinMaxClamp(true), which emits NMin/NMax/NClamp for min/max/clamp and prevents NaN dither values from becoming sparse black pixels in DirectVulkan. Bliss DirectVulkan improved from mismatchPixels=1023 to 29; DirectGLES remained at mismatchPixels=31. Registered Bliss with TOLERANCE 40 to cover residual dither-level pixel noise. The registered Bliss DirectGLES and DirectVulkan CTest entries both passed locally.
2026-06-19T21:20:00 - Full registered retrace suite passed locally after adding Bliss: 28/28 tests passed in /home/swung/mobilegl-builds/retrace-arch. Bliss removed from remaining.txt; next queue item is Nostalgia.
-2
View File
@@ -1,2 +0,0 @@
minecraft-1.21.4-fabric-iris-nostalgia-in-world
minecraft-1.21.4-fabric-iris-photon-v1.1-in-world